[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #16 from r.ro...@outlook.com --- All good on my side, too. Tested with the same songs that broke the lock screen. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #15 from sasori.n...@gmail.com --- (In reply to David Edmundson from comment #14) > Git commit 419b9708ee9e36c4d5825ff6f58ca71f61d32d83 by David Edmundson. > Committed on 11/11/2019 at 16:40. > Pushed by davidedmundson into branch 'Plasma/5.17'. > > Fix binding loop in lockscreen media controls > > Summary: > When we load and position the Image the height is constrained, the width > is not. The image fillMode is set as PreserveAspectFit so the width > will adjust to fit the aspect ratio, > > Therefore we only want to set a fixed height on the sourceSize, it will > automatically match the resultant width. > FIXED-IN: 5.17.3 > > Test Plan: > I was unable to reproduce the state. > Patch is based on reading the code and docs > > Reviewers: #plasma, broulik, ngraham > > Reviewed By: #plasma, broulik, ngraham > > Subscribers: broulik, filipf, plasma-devel > > Tags: #plasma > > Differential Revision: https://phabricator.kde.org/D25252 > > M +1-1lookandfeel/contents/lockscreen/MediaControls.qml > > https://commits.kde.org/plasma-workspace/ > 419b9708ee9e36c4d5825ff6f58ca71f61d32d83 Tested the fix locally using the method already talked about. I can confirm the patch works. Thanks David :) -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 David Edmundson changed: What|Removed |Added Latest Commit||https://commits.kde.org/pla ||sma-workspace/419b9708ee9e3 ||6c4d5825ff6f58ca71f61d32d83 Status|REPORTED|RESOLVED Version Fixed In||5.17.3 Resolution|--- |FIXED --- Comment #14 from David Edmundson --- Git commit 419b9708ee9e36c4d5825ff6f58ca71f61d32d83 by David Edmundson. Committed on 11/11/2019 at 16:40. Pushed by davidedmundson into branch 'Plasma/5.17'. Fix binding loop in lockscreen media controls Summary: When we load and position the Image the height is constrained, the width is not. The image fillMode is set as PreserveAspectFit so the width will adjust to fit the aspect ratio, Therefore we only want to set a fixed height on the sourceSize, it will automatically match the resultant width. FIXED-IN: 5.17.3 Test Plan: I was unable to reproduce the state. Patch is based on reading the code and docs Reviewers: #plasma, broulik, ngraham Reviewed By: #plasma, broulik, ngraham Subscribers: broulik, filipf, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D25252 M +1-1lookandfeel/contents/lockscreen/MediaControls.qml https://commits.kde.org/plasma-workspace/419b9708ee9e36c4d5825ff6f58ca71f61d32d83 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 Val L. changed: What|Removed |Added CC||lopez.valn...@yahoo.com --- Comment #13 from Val L. --- Just wanted to chime in after encountering this very issue myself. OS: Manjaro 18.1.2 Juhraya Kernel: x86_64 Linux 5.3.8-3-MANJARO CPU: Intel Core i7-9750H Qt Version 5.13.1 Plasma Version 5.17.2 Player: Strawberry Version 0.6.5 Initially I wasn't seeing this crash but I realized media controls were turned off in Screen Locking in my settings at that time. So I had a track in pause then I left my PC for a bit until in auto-locked itself then the segfault happened. I can also confirm that commenting out "fillMode: Image.PreserveAspectFit" or using "sourceSize: Qt.size(paintedWidth, paintedHeight)" fixes the issue. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #12 from sasori.n...@gmail.com --- (In reply to David Edmundson from comment #11) > Opened the file, one thing jumps out. > > implicitHeight: controlsRow.height + controlsRow.y > > > Regardless of whether this causes the bug, this needs fixing. > > An implicitHeight should never depend on a current height as that's a loop > > An implicit size should only propagate an implicit size upwards. Thanks for the feedback David. Could you give the fix for this line, please? I'm not a kde dev and my knowledge of Qt is very limited, but given the fixed line, I could test and report if it is a fix for this bug or not. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #11 from David Edmundson --- Opened the file, one thing jumps out. implicitHeight: controlsRow.height + controlsRow.y Regardless of whether this causes the bug, this needs fixing. An implicitHeight should never depend on a current height as that's a loop An implicit size should only propagate an implicit size upwards. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #10 from sasori.n...@gmail.com --- (In reply to Filip Fila from comment #9) > Just an idea but can those of you that can reproduce the bug restore the > 'fillMode: Image.PreserveAspectFit' line and then change the sourceSize line > to be: > > sourceSize: Qt.size(paintedWidth, paintedHeight) > > and then test with /usr/lib/kscreenlocker_greet --testing Hi Filip, thanks for looking into it. I've just tested your proposed fix and I'm glad to report that it works on my system. Tested with square and non-square (3:1 ratio) cover arts. No more core dumps, no more binding loops. Manjaro (Arch) on kernel 5.3.6-1 Plasma 5.16.5 Clementine 1.3.1-771 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #9 from Filip Fila --- Just an idea but can those of you that can reproduce the bug restore the 'fillMode: Image.PreserveAspectFit' line and then change the sourceSize line to be: sourceSize: Qt.size(paintedWidth, paintedHeight) and then test with /usr/lib/kscreenlocker_greet --testing -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 Filip Fila changed: What|Removed |Added CC||filipfila@gmail.com --- Comment #8 from Filip Fila --- I made that patch but I can't reproduce this. I'm also using Audacious from git. Tested with both squared and non squared album art. The lock screen shows up immediately and everything works. I don't get any binding loops either. Operating System: Manjaro Linux KDE Plasma Version: 5.17.2 KDE Frameworks Version: 5.63.0 Qt Version: 5.13.1 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #7 from Jacques W --- (In reply to Jacques W from comment #6) > (In reply to sasori.nami from comment #5) > > PS: I've been working since 2019-10-19 with the line commented and can > > confirm that I didn't have the problem once in that time. > > I got the exact same problem. Best way to reproduce is just use > /usr/lib/kscreenlocker_greet --testing command to test. With the line > commented out screen locking works again :-) I use: Mellowplayer Linux 5.3.8-3 Plasma 5.17.2 KDE Frameworks 5.63.0 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 Jacques W changed: What|Removed |Added CC||nuclearjo...@gmail.com --- Comment #6 from Jacques W --- (In reply to sasori.nami from comment #5) > PS: I've been working since 2019-10-19 with the line commented and can > confirm that I didn't have the problem once in that time. I got the exact same problem. Best way to reproduce is just use /usr/lib/kscreenlocker_greet --testing command to test. With the line commented out screen locking works again :-) -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 Tristan Miller changed: What|Removed |Added CC||psychon...@nothingisreal.co ||m -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #5 from sasori.n...@gmail.com --- PS: I've been working since 2019-10-19 with the line commented and can confirm that I didn't have the problem once in that time. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #4 from sasori.n...@gmail.com --- Hi, sorry for not following through. I've been busy. I just tried with a 500x500 cover, with the line restored in my file. It didn't crash, but the lock screen took a long time to display (staying black for at least 20s), then displayed properly. Logs were filled with the loop warning, but no core dump. Manjaro (Arch) on kernel 5.3.6-1 Plasma 5.16.5 Clementine 1.3.1-771 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 r.ro...@outlook.com changed: What|Removed |Added CC||r.ro...@outlook.com --- Comment #3 from r.ro...@outlook.com --- Can reproduce with Rhythmbox and songs with square album art. Logs get hammered with the binding loop message and segfaults thrice. Commenting out the line in question causes everything to work fine. OpenSUSE Tumbleweed 20191023 Linux 5.3.6 KDE Plasma 5.17.0 KDE Frameworks 5.63.0 Qt 5.13.1 Mesa 19.1.7 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 --- Comment #2 from Kai Uwe Broulik --- Thanks for your investigation. Does it happen with any player and any music file or do you need to play a specific file (presumably one with non-square album art)? -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 sasori.n...@gmail.com changed: What|Removed |Added CC||sasori.n...@gmail.com --- Comment #1 from sasori.n...@gmail.com --- I'm having the same problem, with a core dump of kscreenlocker at the end (I woke up this morning to find the "Screen locker is broken..." message). Anyway, here are more info and my own conclusions at the end. The following tests were made with plasma 5.16.5 on a Manjaro system with the BreezeDark screen locker and VLC with a media loaded (playing or paused). It does the same with Clementine or other media players. Output of /usr/lib/kscreenlocker_greet --testing /usr/lib/kscreenlocker_greet --testing OpenGL vendor string: Intel Open Source Technology Center OpenGL renderer string: Mesa DRI Intel(R) Haswell Desktop OpenGL version string: 3.0 Mesa 19.2.1 OpenGL shading language version string: 1.30 Driver: Intel GPU class: Haswell OpenGL version: 3.0 GLSL version: 1.30 Mesa version: 19.2.1 Linux kernel version: 5.3.6 Requires strict binding:yes GLSL shaders: yes Texture NPOT support: yes Virtual Machine:no file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/main.qml:59: TypeError: Property 'setAction' of object ScreenLocker::WallpaperIntegration(0x5583239e9090) is not a function file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/main.qml:59: TypeError: Property 'setAction' of object ScreenLocker::WallpaperIntegration(0x5583239e9090) is not a function Locked at 1571501528 UdevQt: unable to create udev monitor connection Connecting to deprecated signal QDBusConnectionInterface::serviceOwnerChanged(QString,QString,QString) file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/SessionManagementScreen.qml:64:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/ActionButton.qml:33:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/KeyboardLayoutButton.qml:29:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/Battery.qml:48:9: Unable to assign [undefined] to double file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/SessionManagementScreen.qml:64:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/ActionButton.qml:33:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/KeyboardLayoutButton.qml:29:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/Battery.qml:48:9: Unable to assign [undefined] to double file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/UserDelegate.qml:41:5: Unable to assign [undefined] to int file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/components/UserDelegate.qml:41:5: Unable to assign [undefined] to int QXcbClipboard: SelectionRequest too old QXcbClipboard: SelectionRequest too old QXcbClipboard: SelectionRequest too old QXcbClipboard: SelectionRequest too old QXcbClipboard: SelectionRequest too old QXcbClipboard: SelectionRequest too old file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/MediaControls.qml:96:9: QML Image: Binding loop detected for property "sourceSize" # This is repeated a *lot* of times (so much I couldn't copy-paste it all, my computer started to panic) Segmentation fault (core dumped) Output of journalctl -r after the core dump oct. 19 18:12:13 spike-manjaro systemd-coredump[14640]: Process 14618 (kscreenlocker_g) of user 1000 dumped core. Stack trace of thread 14618: #0 0x7f769c8d0330 __vfprintf_internal (libc.so.6) #1 0x7f769c8d3586 buffered_vfprintf (libc.so.6) #2 0x7f769c8d0724 __vfprintf_internal (libc.so.6) #3 0x7f769c8bd19a fprintf (libc.so.6) #4 0x7f769ccd5557 n/a (libQt5Core.so.5) #5 0x7f769ccd1031 n/a (libQt5Core.so.5)
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 413087] lockscreen broken when mediacontrols active
https://bugs.kde.org/show_bug.cgi?id=413087 Kai Uwe Broulik changed: What|Removed |Added Version|5.17.0 |unspecified Component|Lock/logout applet |greeter Target Milestone|1.0 |--- CC||bhus...@gmail.com, ||k...@privat.broulik.de Product|plasmashell |kscreenlocker -- You are receiving this mail because: You are watching all bug changes.
