[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #14 from Nate Graham --- It was indeed ages ago from my goldfish memory brain since I have no memory of that. Thankfully the mailing list history does! Hopefully I did remember to follow up on what I said I'd do and notify theme creators. Oh well, what's done is done now. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #13 from David Edmundson --- No, this one: https://mail.kde.org/pipermail/plasma-devel/2021-August/120564.html >Too late now though; I can send an email to the general community notifying >people that Plasma theme authors need to update their lockscreen code. It's been ages since it changed (5.25?) so it seems rather pointless. > Do we have any documentation regarding the differences between the V1 and V2 > APIs that I can point them to? We don't have any documentation on any of the LNF paths. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #12 from Nate Graham --- Assuming you're talking about https://mail.kde.org/pipermail/plasma-devel/2022-August/122758.html, that's a case where intentionally braking compatibility was a calculated risk to un-break KRunner completely in certain cases (there was no fallback if the custom KRunner styling broke, as there is with the lock screen). I'm not aware of any complaints about that change, probably because the ability to theme KRunner was a rather hidden thing and most themes did not make use of it. Whereas the ability to theme the lockscreen is much more commonly used in themes. Too late now though; I can send an email to the general community notifying people that Plasma theme authors need to update their lockscreen code. Do we have any documentation regarding the differences between the V1 and V2 APIs that I can point them to? -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #11 from David Edmundson --- Can I refer you to *your own emails* on plasma-devel Aug 10th. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #10 from Nate Graham --- Well that's a shame. It's not ideal to knowingly breaking compatibility before Plasma 6 without any external communication to theme developers or acknowledgement in the UI when a theme is incompatible; this is the kind of thing that we complain about the GNOME people doing. Let's try to do better in the future. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 David Edmundson changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |INTENTIONAL --- Comment #9 from David Edmundson --- 3rd parties can make the relevant changes and bump their lnf API to v2. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #8 from David Edmundson --- Yes. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #7 from Nate Graham --- ...So basically, we broke compatibility with all lock screen themes? -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #6 from David Redondo --- The API was changed to support the finger unlocking IIRC, see https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/29 and https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/59 -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #5 from Nate Graham --- So basically, we broke compatibility with all lock screen themes? -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #4 from Nate Graham --- $ QT_LOGGING_RULES="kscreenlocker_greet=true" /home/nate/kde/ usr/lib64/libexec/kscreenlocker_greet kscreenlocker_greet: Greeter is starting up. kscreenlocker_greet: Lockscreen QML outdated, falling back to default kscreenlocker_greet: [PAM] Starting... file:///home/nate/kde/usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/main.qml:66: TypeError: Property 'setAction' of object ScreenLocker::WallpaperIntegration(0x5660a0) is not a function kf.kirigami: Failed to find a Kirigami platform plugin kscreenlocker_greet: Start auth Locked at 1669926401 kscreenlocker_greet: "Place your right index finger on the fingerprint reader" kscreenlocker_greet: Auth done RC 0 > kscreenlocker_greet: Lockscreen QML outdated, falling back to default Seems suspicious. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #3 from David Redondo --- Run it with QT_LOGGING_RULES="kscreenlocker_greet=true" to get debug output if not visible by default. -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 --- Comment #2 from David Redondo --- It's most likey this https://invent.kde.org/plasma/kscreenlocker/-/blob/master/greeter/greeterapp.cpp#L195 the qml api changed so this was intrdouced -- You are receiving this mail because: You are watching all bug changes.
[kscreenlocker] [Bug 462331] Kscreenlocker only uses screen locker theme from non-default Global Themes when run in testing mode
https://bugs.kde.org/show_bug.cgi?id=462331 Nate Graham changed: What|Removed |Added Keywords||regression Ever confirmed|0 |1 Priority|NOR |HI CC||k...@david-redondo.de, ||k...@davidedmundson.co.uk, ||n...@kde.org, ||niccolo.venera...@gmail.com Status|REPORTED|CONFIRMED Severity|normal |major Summary|Kscreenlocker only uses |Kscreenlocker only uses |Global Themes when run in |screen locker theme from |testing mode|non-default Global Themes ||when run in testing mode --- Comment #1 from Nate Graham --- I can confirm this. -- You are receiving this mail because: You are watching all bug changes.
