[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 --- Comment #11 from Kai Uwe Broulik --- Git commit f899ccdc0fa3e28dd614c06f297d1d5fccceeb67 by Kai Uwe Broulik. Committed on 16/03/2019 at 11:27. Pushed by broulik into branch 'master'. [KSplashQML] Update stages comment and make code clearer There's an kcminit stage that wasn't documented. Also change m_stage and then check it so the number here matches the number of stages in the comment. Differential Revision: https://phabricator.kde.org/D19801 M +4-4ksplash/ksplashqml/splashapp.cpp https://commits.kde.org/plasma-workspace/f899ccdc0fa3e28dd614c06f297d1d5fccceeb67 -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 --- Comment #10 from Kai Uwe Broulik --- > Still adding that stage "kcminit" to the comment in splashapp.cpp might be an > improvement. Agreed: https://phabricator.kde.org/D19801 -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 Kai Uwe Broulik changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Kai Uwe Broulik --- *** This bug has been marked as a duplicate of bug 405444 *** -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 Bernhard Übelacker changed: What|Removed |Added Attachment #118782|0 |1 is obsolete|| --- Comment #8 from Bernhard Übelacker --- Comment on attachment 118782 --> https://bugs.kde.org/attachment.cgi?id=118782 ksplashqml: Quit on first call to setStage with stage == 6. Moving the assignment is not correct as there are really 7 stages. -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 --- Comment #7 from Bernhard Übelacker --- Hello Kai Uwe Broulik, with the patch from #405444 I now receive that missing "kcminit" stage. Maybe that stage "kcminit" arrives even before the "kinit" and got lost because of the not yet up dbus interface. So this issue might be just closed. Still adding that stage "kcminit" to the comment in splashapp.cpp might be an improvement. Kind regards, Bernhard -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 Bernhard Übelacker changed: What|Removed |Added Attachment #118783|0 |1 is obsolete|| --- Comment #6 from Bernhard Übelacker --- Comment on attachment 118783 --> https://bugs.kde.org/attachment.cgi?id=118783 ksplashqml: Add some logging to get details when stages were reached. Better version added to #405444. -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 --- Comment #5 from Bernhard Übelacker --- Hello Kai Uwe Broulik, thats strange because I could get with my patches applied just the 6 stages mentioned in the comment in [1]. Also the comment of the lastest git version just mentions these 6. So the comment might be incomplete and I have to investigate why I don't get the "kcminit" stage? At a first sight I don't see a failure of kcminit_startup - I will have a look and report back. [1] https://sources.debian.org/src/plasma-workspace/4:5.14.5.1-1/ksplash/ksplashqml/splashapp.cpp/#L40 [2] https://cgit.kde.org/plasma-workspace.git/tree/ksplash/ksplashqml/splashapp.cpp#n40 -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 --- Comment #4 from Kai Uwe Broulik --- I'm having the following stages here: 1: initial - set by ksplash initially 2: kcminit - sent by kcminit_startup 3: kinit - run by startkde script via qdbus 4: ksmserver - sent by ksmserver when it starts 5: wm - sent by KWin 6: ready - sent my ksmserver when it finishes session restore and what not 7: desktop - sent my plasmashell ← at this point m_stage is 6 (is checked before incrementing and ksplash quits) -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446
--- Comment #3 from Bernhard Übelacker ---
(In reply to Kai Uwe Broulik from comment #2)
> Is this still an issue or just a symptom of Bug 405444?
I think both are two distinct issues:
- in 405444 we are just collecting 5 different elements in m_stages and
therefore the most we reach is a call setStage(5)
and never enter the exit path.
- in 405446 we reach setStage(6), but need any other call setStage(int)
following to enter the exit path.
But there might be a reason for that ordering in
setStage(int) that I may have overlooked.
E.g. two dbus calls setStage("desktop") are expected to be received?
Therefore I am less sure about 405446.
--
You are receiving this mail because:
You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #2 from Kai Uwe Broulik --- Is this still an issue or just a symptom of Bug 405444? -- You are receiving this mail because: You are watching all bug changes.
[ksplash] [Bug 405446] ksplashqml hits its hard timeout of 30 seconds because setStage(6) is needed twice
https://bugs.kde.org/show_bug.cgi?id=405446 --- Comment #1 from Bernhard Übelacker --- Created attachment 118783 --> https://bugs.kde.org/attachment.cgi?id=118783=edit ksplashqml: Add some logging to get details when stages were reached. -- You are receiving this mail because: You are watching all bug changes.
