[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-21 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

Jasem Mutlaq  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #1 from Jasem Mutlaq  ---
You can try to turn off "Remember Job Progress" in Options.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #2 from Jasem Mutlaq  ---
Well, never mind, it's a bug alright. The scheduler gets stuck on 2/7 and Eric
just confirmed it as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Wolfgang Reissenberger
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #3 from Wolfgang Reissenberger  ---
I took a closer look into the Capture class. There is an approach counting
existing images across all sequences. But there is no counterpart determining
the target counts of images spanning the contained sequence jobs.

Interestingly, this is fully calculated by the Scheduler - which might be the
wrong place...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #4 from Jasem Mutlaq  ---
Yes I am working on a solution right now for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Wolfgang Reissenberger
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #5 from Wolfgang Reissenberger  ---
Great! If you need bandwidth, I could take over the fix as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #6 from Jasem Mutlaq  ---
That would be great Wolfgang! It's a bit complicated as now it has to works
with also repeated jobs. So even if this works with this sequence, imagine the
scheduler commanding a number of them as well.

This is greatly appreciated as I can get time to implement some other features
of the next release like driver aliases.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Wolfgang Reissenberger
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #7 from Wolfgang Reissenberger  ---
OK, I'll take over. I should place the patch through Phabricator, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #8 from Jasem Mutlaq  ---
That's right, just like the previous patch. However, please use arc to upload
the patch so that your information is reserved once I apply it. In the previous
commit here:
https://cgit.kde.org/kstars.git/commit/?id=7804e618ed41f059475a9a25125e7ea30312cf27

It didn't pull your information. So just make sure to setup Arc and use it
submit the patches in the future. Thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Wolfgang Reissenberger
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #9 from Wolfgang Reissenberger  ---
OK, thanks for the hint. I've installed arc and will try to use it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-22 Thread Wolfgang Reissenberger
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #10 from Wolfgang Reissenberger  ---
Bug fix submitted as https://phabricator.kde.org/D14280

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-24 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #11 from Jasem Mutlaq  ---
Thanks, are you getting updates/discussion we're having on Phabricator?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-24 Thread Wolfgang Reissenberger
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #12 from Wolfgang Reissenberger  ---
Yes, Eric made several very good comments. I made all changes he suggested and
submitted a new version: https://phabricator.kde.org/D14309

For rebasing: please advise, I do not exactly know what to do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-24 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

--- Comment #13 from Jasem Mutlaq  ---
Can we continue the discussion in Phabricator? Rebasing simply means you need
to sync your fork with master changes up to date and then create the diff
again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kstars] [Bug 396742] EKOS | Capture | multiple occurrence of the same sequence job ignored

2018-07-25 Thread Jasem Mutlaq
https://bugs.kde.org/show_bug.cgi?id=396742

Jasem Mutlaq  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kst
   ||ars/fadd47d9bcda1682e1950cb
   ||8422bbf50cbf3c8ab
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #14 from Jasem Mutlaq  ---
Git commit fadd47d9bcda1682e1950cb8422bbf50cbf3c8ab by Jasem Mutlaq, on behalf
of Wolfgang Reissenberger.
Committed on 25/07/2018 at 12:33.
Pushed by mutlaqja into branch 'master'.

Handling multiple occurrence of the same sequence job corrected

Summary:

Capture may handle now multiple occurences of the same sequence
job correctly - e.g. RGBLRGB.

-- Update from Wolfgang: review comments of Eric incorporated.
-- Update from Eric: this is a squash of D14280 and D14309.

Reviewers: wreissenberger, mutlaqja

Reviewed By: mutlaqja

Subscribers: mutlaqja, kde-edu, TallFurryMan

Tags: #kde_edu

Differential Revision: https://phabricator.kde.org/D14357

M  +35   -11   kstars/ekos/capture/capture.cpp
M  +11   -1kstars/ekos/capture/capture.h
M  +1-0kstars/ekos/capture/sequencejob.h

https://commits.kde.org/kstars/fadd47d9bcda1682e1950cb8422bbf50cbf3c8ab

-- 
You are receiving this mail because:
You are watching all bug changes.