[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Albert Astals Cid changed: What|Removed |Added CC||thierry.rouil...@laposte.ne ||t --- Comment #11 from Albert Astals Cid --- *** Bug 407714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 --- Comment #10 from Duncan <1i5t5.dun...@cox.net> --- (In reply to Jeremy Whiting from comment #6) > Git commit 40e80d73866634c954dce212f2da43cd0fdce8d6 by Jeremy Whiting. > > Don't use KIO copy and QTemporaryFile to load xml definition files. Confirmed: With this on master now, all games seem to work again. Thanks. =:^) -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Jeremy Whiting changed: What|Removed |Added Latest Commit|https://commits.kde.org/ksu |https://commits.kde.org/ksu |doku/40e80d73866634c954dce2 |doku/3ecebabf44eb1ace3859ea |12f2da43cd0fdce8d6 |fafe93534ab0d3f986 Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #9 from Jeremy Whiting --- Git commit 3ecebabf44eb1ace3859eafafe93534ab0d3f986 by Jeremy Whiting. Committed on 20/03/2019 at 16:04. Pushed by whiting into branch 'Applications/19.04'. Don't use KIO copy and QTemporaryFile to load xml definition files. Since files are usually (maybe always?) local anyway, there's not much reason to copy the file to a temporary file. This also fixes QDomDocument::setContent failing on an empty file when the QTemporaryFile is somehow empty after the copy has finished. Reviewed by: Ian Wadham (cherry picked from commit 40e80d73866634c954dce212f2da43cd0fdce8d6) M +7-12 src/gui/serializer.cpp https://commits.kde.org/ksudoku/3ecebabf44eb1ace3859eafafe93534ab0d3f986 -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Christoph Feck changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REPORTED --- Comment #8 from Christoph Feck --- Not fixed unless someone merges the branch to any branch that ends up in releases. -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 --- Comment #7 from Duncan <1i5t5.dun...@cox.net> --- Just a couple notes for the moment, pending testing of the fix, since the bug has been traced to qt5's tmpfile handling: When I first noticed the bug and when reported, I was on qt 5.12.1. Since then I upgraded to 5.12.2. Unfortunately that didn't solve the problem. On my system, both system and user tmp are tmpfs, so the copy from installed to a tmpfile is cross-filesystem. It's possible that may be the complicating factor that explains why I have the bug while others on qt 5.12.x may not. (Apparently one tester had a single filesystem containing both the installation and tmp, so it wasn't a cross-filesystem copy for him.) It's now my weekend and I should be doing routine system and git-build updates later today or tomorrow. If the potential fix isn't on master before that I plan on switching branches and verifying the fix one way or the other, so we should have confirmation then. -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Jeremy Whiting changed: What|Removed |Added Latest Commit||https://commits.kde.org/ksu ||doku/40e80d73866634c954dce2 ||12f2da43cd0fdce8d6 Resolution|WORKSFORME |FIXED --- Comment #6 from Jeremy Whiting --- Git commit 40e80d73866634c954dce212f2da43cd0fdce8d6 by Jeremy Whiting. Committed on 20/03/2019 at 02:25. Pushed by whiting into branch '405422'. Don't use KIO copy and QTemporaryFile to load xml definition files. Since files are usually (maybe always?) local anyway, there's not much reason to copy the file to a temporary file. This also fixes QDomDocument::setContent failing on an empty file when the QTemporaryFile is somehow empty after the copy has finished. Reviewed by: Ian Wadham M +7-12 src/gui/serializer.cpp https://commits.kde.org/ksudoku/40e80d73866634c954dce212f2da43cd0fdce8d6 -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Ian Wadham changed: What|Removed |Added Resolution|--- |WORKSFORME Severity|major |normal Status|REPORTED|RESOLVED Priority|VHI |NOR --- Comment #5 from Ian Wadham --- Thanks very much, Albert, for taking the time to check up on this. It looks as if the ball is back in your court, Duncan. Maybe something has gone wrong with your build and compile of KDE software. Looks like you have the same version of Qt5 as current KDE development, but do you have the right KF5? Albert is an authority on all this. He is a leading member of the kde-games-devel mailing list and also a KDE Release Team member and there is a release of KDE Applications 19.04 (including KSudoku) coming up on 18th April. The branch that is due for release is here: https://cgit.kde.org/ksudoku.git/tree//?h=Applications%2F19.04 Instructions for cloning the repository are at https://kde.org/applications/games/ksudoku/development. If anything at all is wrong and there is no problem in your environment, we would want to know. Please feel free to re-open this bug report if necessary. -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #4 from Albert Astals Cid --- I can generate any game just fine using the current git version of ksudoku + Qt 5.12.1 + KF5 5.56 -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 Ian Wadham changed: What|Removed |Added Priority|NOR |VHI Severity|normal |major --- Comment #3 from Ian Wadham --- Thank you very much for helping narrow this down, Duncan. The problem is that the KSudoku code is not able to create the data-structures used by ANY of the "Custom" puzzles (those that are not vanilla Sudoku squares or Roxdoku cubes). Consequently it is unable to go on and fill the structures with data for a puzzle to be solved and then display the puzzle. So it remains in the Welcome screen code (src/gui/welcomescreen.*), where the user can choose another type of puzzle. The failure is detected in Game CustomGame::createGame(...) and bool CustomGame::createSKGraphObject() (both in src/gui/gamevariants.cpp). I strongly suspect that the error occurs somewhere in the serializer code (src/gui/serializer.*), as called by the line: m_graph = ksudoku::Serializer::loadCustomShape(m_url, 0, errorMsg); in CustomGame::createSKGraphObject(). In other words, any puzzle type that is constructed by one of the XML files in src/shapes fails to be created. These puzzle types are a majority of those available in KSudoku, so the problem is catastrophic. The relevant KSudoku code has not changed recently, so it looks as though some recent change (in the last month or two) in XML handling, in Qt5 or in the KF5 environment has brought on this problem. -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 --- Comment #2 from Duncan <1i5t5.dun...@cox.net> --- (In reply to Ian Wadham from comment #1) > I used to be maintainer/developer for KSudoku, but am out of touch with it > now. However I will try to help narrow this problem down. Thanks. > The message you are getting seems to be from the "welcome" screen (where you > choose a puzzle type). It was added to the code in April 2017, see > https://phabricator.kde.org/D5671. I did grep the error in the source, trying to see if I as a non-coder but reasonably experienced gentoo user/admin who routinely runs live-git of selected packages, reading git logs and sometimes generating patches on my own (I had some basic and pascal classes back in the day and back before I left MS behind did intermediate visual basic, but only really know bash on Linux), could figure out what was triggering it, but no real luck beyond finding out it was in the welcome-screen code, as you mention. I'm not familiar with the (from memory) color-coding generation as mentioned in the comments, so saw the numbers lists associated with some of the games but don't understand the generation mechanism and was too tired to reason it further, so left it at that. > Do you stay on the welcome screen after you see the message? Please confirm. Yes. I stay on the welcome (aka game chooser) screen. The message is a popup asking me to choose another game, so staying on the chooser screen is to be expected. > Please can you give me a precise list of the names of the puzzle types for > which you get the message. For example, which "6x6" are you using, the one > with rectangular blocks or the Mathdoku - Settable Size with size set to > 6x6? Or maybe both? > > You say that games smaller than 9x9 seem to fail, but what about variant > (non-Classic) games of size 9x9, such as Killer Sudoku, Aztec, Jigsaw or > even Samurai? Looks like it's not just size; almost everything fails. These are the only ones that don't generate the error: Standard-9x9, Roxdoku-9-3x3x3, Sudoku-16x16, Sudoku-25x25, Roxdoku-16-4x4x4, Roxdoku-25-5x5x5. I don't believe I had tried Mathdoku-settable-size so didn't know how the size was set, but it appears to be an option in the ksudoku config. Neither the existing size of 6, nor the maximum 9 nor minimum 3, would give me a game, only the now familiar error. > Your comments about compiler and Qt changes may also be a clue. There is > some very old code in KSudoku (2007-08 vintage) that I have never dared > touch. Perhaps some of that has been rendered invalid or works differently > now. Before investigation I suspected it might be something like an xml-parser update breaking parsing of whatever generator rules files were used, but the files don't seem to be XML-based so that's out. But whatever it was that changed, is obviously now treating perfectly valid "rules files" (for lack of a better term at this point) as invalid. I checked for file corruption, etc, too, and came up empty. > I regret that I cannot actually build and test the latest KSudoku code, > because I now work on an Apple Macbook and am unable to build KF5 and Qt5. > > BTW, it does not surprise me that the clock wraps around, but I think you > might find Samurai (five 9x9 grids) more fun than a 25x25... :-) The 25x25 was an accidental click (touchpad...), that I decided to actually try once it was generated and displayed. Fine to do once to say I did it but I doubt I'll do it again, especially now that it's getting the negative association of this bug, tho it most likely had nothing to do with it and that's only chance. But it's a negative association, none-the-less, and those don't have to be logical to be powerful... Anyway, For that sort of longer puzzle I'd prefer a larger size Palapeli/jigsaw, and have done ~900 pieces on it before, as my family used to do jigsaws and it takes me back. My main 65-inch 4K TV-as-monitor is about the size of the boards we'd put the puzzles on, too. =:^) I do I believe it's ksudoku windmill (unfortunately can't confirm ATM...) occasionally tho and like it. Samurai looks to be similar. I'll check it (and Sohei) out when I get things working again. Thanks. =:^) -- You are receiving this mail because: You are watching all bug changes.
[ksudoku] [Bug 405422] ksudoku live-git (commit 09814312d) small-game generation fails with "Unable to generate a puzzle of the chosen variant"
https://bugs.kde.org/show_bug.cgi?id=405422 --- Comment #1 from Ian Wadham --- I used to be maintainer/developer for KSudoku, but am out of touch with it now. However I will try to help narrow this problem down. The message you are getting seems to be from the "welcome" screen (where you choose a puzzle type). It was added to the code in April 2017, see https://phabricator.kde.org/D5671. Do you stay on the welcome screen after you see the message? Please confirm. Please can you give me a precise list of the names of the puzzle types for which you get the message. For example, which "6x6" are you using, the one with rectangular blocks or the Mathdoku - Settable Size with size set to 6x6? Or maybe both? You say that games smaller than 9x9 seem to fail, but what about variant (non-Classic) games of size 9x9, such as Killer Sudoku, Aztec, Jigsaw or even Samurai? Your comments about compiler and Qt changes may also be a clue. There is some very old code in KSudoku (2007-08 vintage) that I have never dared touch. Perhaps some of that has been rendered invalid or works differently now. I regret that I cannot actually build and test the latest KSudoku code, because I now work on an Apple Macbook and am unable to build KF5 and Qt5. BTW, it does not surprise me that the clock wraps around, but I think you might find Samurai (five 9x9 grids) more fun than a 25x25... :-) -- You are receiving this mail because: You are watching all bug changes.
