[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 Nate Graham changed: What|Removed |Added Version Fixed In||5.23 CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 David Edmundson changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/ksystemstats/commit/207b ||8960a6fcd531584283f9475081d ||2dcf0f4aa Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #8 from David Edmundson --- Git commit 207b8960a6fcd531584283f9475081d2dcf0f4aa by David Edmundson. Committed on 06/09/2021 at 12:16. Pushed by davidedmundson into branch 'master'. [plugins/gpu] Initialise properties Properties are created in the relevant subclass via makeSensors. If an implementation fails to create an object we don't want dangling pointers. M +7-7plugins/gpu/GpuDevice.h https://invent.kde.org/plasma/ksystemstats/commit/207b8960a6fcd531584283f9475081d2dcf0f4aa -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #7 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/ksystemstats/-/merge_requests/18 -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 --- Comment #6 from David Edmundson --- It's a bit weird that we have a member in the superclass that's created in the subclass overriding the superclass creation of it. But for the design we have, the patch looks sane. -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 --- Comment #5 from Luca Beltrame --- This at least prevents ksystemstats from crashing. There's another issue now which I'll report a separate bug for later. -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 --- Comment #4 from Fabian Vogt --- FWICT, the issue is that m_temperatureProperty and the other members are never initialized, so the check for nullptr in LinuxAmdGpu::makeSensors also fails. Does it work with the following change? diff --git a/plugins/gpu/GpuDevice.h b/plugins/gpu/GpuDevice.h index 18ddedc..1450d9f 100644 --- a/plugins/gpu/GpuDevice.h +++ b/plugins/gpu/GpuDevice.h @@ -28,7 +28,7 @@ protected: KSysGuard::SensorProperty *m_usageProperty; KSysGuard::SensorProperty *m_totalVramProperty; KSysGuard::SensorProperty *m_usedVramProperty; -KSysGuard::SensorProperty *m_temperatureProperty; +KSysGuard::SensorProperty *m_temperatureProperty = nullptr; KSysGuard::SensorProperty *m_coreFrequencyProperty; KSysGuard::SensorProperty *m_memoryFrequencyProperty; }; -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 Fabian Vogt changed: What|Removed |Added CC||fab...@ritter-vogt.de -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 --- Comment #3 from Luca Beltrame --- By sensor property I mean m_temperatureProperty in plugins/gpu/GpuDevice.cpp. -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 --- Comment #2 from Luca Beltrame --- It looks like the sensor property is constructed improperly (garbage when trying to check it from gdb), but I'm not sure how to debug this further. -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #1 from David Edmundson --- Pasting inline for search #0 0x779dffc9 in operator==(QString const&, QString const&) () from /lib64/libQt5Core.so.5 #1 0x77ed5c39 in KSysGuard::SensorProperty::setName (this=0x77640a60 , name=...) at /usr/src/debug/libksysguard5-5.22.80git.20210904T011806~8247320-ku.38.1.x86_64/systemstats/SensorProperty.cpp:71 #2 0x7340a53b in GpuDevice::initialize (this=0x556de740) at /usr/src/debug/ksystemstats5-5.22.80git.20210903T113040~ede1aab-ku.22.3.x86_64/plugins/gpu/GpuDevice.cpp:49 #3 0x7340b164 in LinuxAmdGpu::initialize (this=0x556de740) at /usr/src/debug/ksystemstats5-5.22.80git.20210903T113040~ede1aab-ku.22.3.x86_64/plugins/gpu/LinuxAmdGpu.cpp:56 #4 0x7340c71f in LinuxBackend::start (this=0x556cc9e0) at /usr/src/debug/ksystemstats5-5.22.80git.20210903T113040~ede1aab-ku.22.3.x86_64/plugins/gpu/LinuxBackend.cpp:64 #5 0x73409770 in GpuPlugin::GpuPlugin (args=..., parent=0x7fffd338, this=0x556cba90) at /usr/src/debug/ksystemstats5-5.22.80git.20210903T113040~ede1aab-ku.22.3.x86_64/plugins/gpu/GpuPlugin.cpp:44 #6 KPluginFactory::createInstance (parentWidget=, parent=, args=...) at /usr/include/KF5/KCoreAddons/kpluginfactory.h:806 -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 Luca Beltrame changed: What|Removed |Added CC||k...@david-redondo.de -- You are receiving this mail because: You are watching all bug changes.
[ksysguard] [Bug 442023] ksystemstats crashes on startup
https://bugs.kde.org/show_bug.cgi?id=442023 Luca Beltrame changed: What|Removed |Added Severity|normal |crash -- You are receiving this mail because: You are watching all bug changes.
