https://bugs.kde.org/show_bug.cgi?id=474558
Albert Astals Cid changed:
What|Removed |Added
Latest Commit||https://invent.kde.org/netw
||ork/libktorrent/-/commit/cd
||8350982d4b4d65eb48780149749
||9bc5d4796ac
Resolution|--- |FIXED
Status|ASSIGNED|RESOLVED
--- Comment #2 from Albert Astals Cid ---
Git commit cd8350982d4b4d65eb487801497499bc5d4796ac by Albert Astals Cid, on
behalf of Jack Hill.
Committed on 28/12/2023 at 11:47.
Pushed by aacid into branch 'master'.
Fix HTTP webseeds
The slot hostResolved is being used in a SLOT macro, and so it must be declared
in the Q_SLOTS section.
Previously Qt failed to connect to hostResolved, and so even if the host was
resolved ktorrent would not attempt to connect to the webseed.
Test plan:
- Start downloading a torrent with a webseed using KTorrent
- (all torrents from archive.org have webseeds)
Previously:
- The following message is shown in the command line:
Warning: QObject::connect: No such slot
bt::HttpConnection::hostResolved(net::AddressResolver *)
- KTorrent never attempts to connect to the webseed
- Webseed tab status is stuck on "Resolving hostname "
Now:
- there is no message in the CLI
- KTorrent attempts to connect to the webseed
- Webseed tab status should eventually change to something different.
M +3-1src/download/httpconnection.h
https://invent.kde.org/network/libktorrent/-/commit/cd8350982d4b4d65eb487801497499bc5d4796ac
--
You are receiving this mail because:
You are watching all bug changes.
