[kwin] [Bug 185710] wrong direction in "slide" plugin

[Roey Katz]

https://bugs.kde.org/show_bug.cgi?id=185710

--- Comment #27 from Roey Katz  ---
I'm on Plasma 5.27.  This bug is still there.  I thought this has gotten
resolved?  I've never seen it working correctly, for what it's worth; the slide
direction is the opposite of what is expected, when transitioning between one
side to the other of a virtual desktop matrix of 2 rows of 3 columns.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185710

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=454231

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185710

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.25

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185710

Nate Graham  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/commit/5d9e0be9593f |ma/kwin/commit/26a4f7594423
   |42e58c13ed436ca4f9867aa4914 |2166a1de7c977549d52a403fb88
   |8   |5

--- Comment #26 from Nate Graham  ---
Git commit 26a4f75944232166a1de7c977549d52a403fb885 by Nate Graham, on behalf
of Eric Edlund.
Committed on 15/04/2022 at 00:09.
Pushed by ngraham into branch 'master'.

Implement desktopSwitching() interface for realtime animations

Added this interface to the VirtualDesktopManager. Realtime touchpad gestures
update the interface to allow for mac os style desktop switching.
Also makes gestured switching use natural direction.

M  +7-0autotests/test_virtual_desktops.cpp
M  +15   -6src/effects.cpp
M  +11   -0src/libkwineffects/kwineffects.h
M  +79   -8src/virtualdesktops.cpp
M  +23   -0src/virtualdesktops.h
M  +13   -0src/workspace.cpp
M  +4-0src/workspace.h

https://invent.kde.org/plasma/kwin/commit/26a4f75944232166a1de7c977549d52a403fb885

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Eric Edlund]

https://bugs.kde.org/show_bug.cgi?id=185710

Eric Edlund  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/5d9e0be9593f
   ||42e58c13ed436ca4f9867aa4914
   ||8

--- Comment #25 from Eric Edlund  ---
Git commit 5d9e0be9593f42e58c13ed436ca4f9867aa49148 by Eric Edlund.
Committed on 19/03/2022 at 13:19.
Pushed by ericedlund into branch 'master'.

make gestured desktop switching use natural directions

M  +6-6src/virtualdesktops.cpp

https://invent.kde.org/plasma/kwin/commit/5d9e0be9593f42e58c13ed436ca4f9867aa49148

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Roey Katz]

https://bugs.kde.org/show_bug.cgi?id=185710

--- Comment #24 from Roey Katz  ---
Wonderful!! Big pet peeve of mine now for many years, this bug!

On Wed, Mar 16, 2022 at 5:14 PM Nate Graham 
wrote:

> https://bugs.kde.org/show_bug.cgi?id=185710
>
> Nate Graham  changed:
>
>What|Removed |Added
>
> 
>  CC||n...@kde.org
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=185710

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=185710

Vlad Zagorodniy  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=185710

--- Comment #23 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #22)
> KWin core (VirtualDesktopManager) has the information. Maybe we need to add
> signals like desktopAboutToSwitchToLeft.

I've been thinking about something similar:

Emit currentDesktopAboutToBeChanged(const DesktopChangedData ),
struct DesktopChangedData {
uint old;
uint new;
bool wrapped;
EffectWindow *movingWindow;
};

or just emit desktopChanged(const DesktopChangedData ), so
Slide effect would use a different wrap function, which is more
"aggressive" with respect to wrapping, if data.wrapped is true.
Same with cube slide effect.

Yet, I'm not sure if it's possible to implement such "behavior".

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=185710

--- Comment #22 from Martin Flöser  ---
KWin core (VirtualDesktopManager) has the information. Maybe we need to add
signals like desktopAboutToSwitchToLeft.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=185710

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #21 from Vlad Zagorodniy  ---
For technical reasons, that's a little bit challenging for effects like Slide
or Desktop Cube Animation
to figure out whether they should "roll desktops" when the number of rows or
columns in the virtual
desktop grid is equal to 2.

Why is it challenging? Let's imagine a setup with 2 virtual desktops. Now,
let's consider two cases:

(a) Current virtual desktop is "Desktop 1" and user switches one desktop to
right(i.e. to "Desktop 2").
In this case, desktopChanged(int old, int current) signal will be emitted,
where old=1, and current=2.

(b) Current virtual desktop is "Desktop 1" and user switches one desktop to
left(i.e. to "Desktop 2").
In this case, desktopChanged(int old, int current) signal will be emitted,
where old=1, and current=2.

As you see, in both cases, old=1, and current=2. That's too ambiguous.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

[Shi Sherebrin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=185710

Shi Sherebrin  changed:

   What|Removed |Added

 CC||bugs@share-a-brain.com

--- Comment #20 from Shi Sherebrin  ---
> plasma-desktop -v
Qt: 4.8.6
KDE Development Platform: 4.14.2
Plasma Desktop Shell: 4.11.13

I can reproduce this problem in both directions, when the desktop switching
animation is set to either "Slide" or "Desktop Cube Animation", and "Desktop
navigation wraps around" is selected.

As long as the number of rows or columns is 3 or greater, switching desktops in
any direction, repeated any number of times, produces the expected continuous
motion/rotation in the same direction.  If the number of rows is 1 (with 3 or
more desktops/columns), switching desktops up or down does nothing and going
left/right behaves as above (both as expected).  Same for 1 column and 3 or
more desktops/rows.

However, for 2 columns, when I get to the right-most desktop and expect to be
able to continue "rightwards" to reach Desktop 1, the desktop slides instead
"leftwards" to Desktop 1.  Same problem when sitting on Desktop 1 and trying to
go "leftwards" to Desktop 2.  Same issue for 2 rows in the up/down direction.

-- 
You are receiving this mail because:
You are watching all bug changes.