[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #25 from Vlad Zahorodnii  ---
yes, please

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Jos Wijdeven]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #24 from Jos Wijdeven  ---
I made a feature request for the wishlist item. Do I need to file separate bug
reports for the other issues?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #23 from Vlad Zahorodnii  ---
Can you file a separate feature request?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Jos Wijdeven]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #22 from Jos Wijdeven  ---
I did some testing.

- It works really well with LibreOffice writer.
- When you update or install software, the root password dialog receives focus
(fantastic, so you don’t have to search for it)
- Pressing the super key moves the focus to the search box of the menu (great).
Only thing here is that the zoomed area doesn’t move all the way to the edge of
the desktop so the first part of the search box is outside of the zoomed area.
- It works well with Kate. Except when you move the caret to the end of a line
or end of the file some weird jumping of the zoomed area occurs. If you’re
typing a line eventually the caret disappears past the right edge of the zoomed
area. Moving back one character (left arrow key) makes the area jump back so
the caret is inside again but moving the caret forward makes it go outside
again. As long as there is at least one character after the caret it works
fine.
- Konsole/terminal:  every time you type a character the zoom area jumps to the
center of the desktop instead of following the caret.

I don’t know if these are Qt Accessibility things or have to be fixed in the
applications themselves?

A little nuisance: when the zoomed area moves to focus the caret it remembers
the position of the mouse pointer where the zoomed area was before the focus
shift. So when you use/touch the mouse (by accident or on purpose) the zoomed
area jumps back to where the mouse pointer was before. You then have to find
you spot back again. Maybe there is a way to keep the mouse pointer within the
zoomed area (even if it is just on the edge of it, but not on top of the
caret)?

Wish list item: right now the zoomed area moves along with every letter typed. 
Maybe an extra option is possible that the zoomed area only moves when the
caret reaches the edge of the zoomed area, for example with a 10% (or
adjustable) margin. That might also prevent the unexpected jumping like in Kate
or Konsole?

But so far this is a big help, thank you again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Jos Wijdeven]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #21 from Jos Wijdeven  ---
Hah, that's better. Looks great so far. Few weird things but that might be the
VM. I'll try it on bare metal later this week. Thanks!!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #20 from Vlad Zahorodnii  ---
Are you running kate with QT_LINUX_ACCESSIBILITY_ALWAYS_ON=1?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Jos Wijdeven]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #19 from Jos Wijdeven  ---
I just updated the kde neon test version to kde plasma 5.20. I enabled the text
caret tracking in the zoom effect. But it doesn't seem to work? I tried it in
the Kate editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

Vlad Zahorodnii  changed:

   What|Removed |Added

   Version Fixed In||5.20.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/076b8bc14ce5
   ||83659ad21898525ec2fbad90a1b
   ||5
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #18 from Vlad Zahorodnii  ---
Git commit 076b8bc14ce583659ad21898525ec2fbad90a1b5 by Vlad Zahorodnii.
Committed on 01/06/2020 at 07:43.
Pushed by vladz into branch 'master'.

[effects/zoom] Implement text caret tracking

The text caret tracking feature allows to keep the text caret inside the
zoomed area. It can be especially useful when the zoomed area is smaller
than the text editor.

M  +19   -0effects/zoom/accessibilityintegration.cpp
M  +4-0effects/zoom/accessibilityintegration.h
M  +12   -1effects/zoom/zoom.cpp
M  +2-0effects/zoom/zoom.h
M  +2-0effects/zoom/zoom.kcfg
M  +1-0effects/zoom/zoom_config.cpp
M  +11   -0effects/zoom/zoom_config.ui

https://invent.kde.org/plasma/kwin/commit/076b8bc14ce583659ad21898525ec2fbad90a1b5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #17 from Vlad Zahorodnii  ---
I submitted a patch for code review that implements the text caret tracking
feature in the zoom effect. Not sure whether it's actually worth it, but I
would like to hear some feedback.

https://invent.kde.org/plasma/kwin/-/merge_requests/1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=362189

Vlad Zahorodnii  changed:

   What|Removed |Added

 CC||josser90...@gmail.com

--- Comment #16 from Vlad Zahorodnii  ---
*** Bug 421234 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #15 from Vlad Zagorodniy  ---
Created attachment 118907
  --> https://bugs.kde.org/attachment.cgi?id=118907=edit
the patch

For what it's worth, I made a patch a while ago to port the zoom effect to
libqaccessibilityclient.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #14 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #11)
> To cut a long story short: I think the time is better invested improving the
> infrastructure for a11y than to invest into doing weird things in zoom.

Focus tracking in the Zoom effect is currently not working. It would be great
either drop it or rebase on libqaccessibilityclient.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Frederik Gladhorn]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #13 from Frederik Gladhorn  ---
And yes, in general people prefer the kwin style of magnification, so combing
these features would be very sensible, I think kmag should maybe become a
glorified frontend for the kwin effects ideally.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Frederik Gladhorn]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #12 from Frederik Gladhorn  ---
It works for me - for some definition of working. We have one issue - that is
when to enable the whole accessibility framework and we don't want to do that
without reason since it means sending quite some dbus stuff around.

I just realized that kmag depends on the focus notifications (obviously) but
probably doesn't trigger them to be sent.

If you want to test: Run an app with
QT_LINUX_ACCESSIBILITY_ALWAYS_ON=1 in the environment and it starts working. I
tested for example with dolphin - env QT_LINUX_ACCESSIBILITY_ALWAYS_ON=1
dolphin

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #11 from Martin Flöser  ---
I'm not a huge fan of using the zoom effect for a11y features. I think it is
unsuited as it just does pixel upscaling. Ideal would be the application
toolkit themselves providing the functionality by e.g. providing the zoom
functionality directly in the application or by rendering to a scaled window
which gets downscaled by the compositor but allows to provide high quality
zoom.

To cut a long story short: I think the time is better invested improving the
infrastructure for a11y than to invest into doing weird things in zoom.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #10 from Vlad Zagorodniy  ---
I created simple demo to test QAccessibleClient:
* https://paste.kde.org/pxmdxtggc
* https://paste.kde.org/p12udv0du

For some reason, it works only with GTK apps. Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #9 from Vlad Zagorodniy  ---
Anyway, I'll take a look at libqaccessibilityclient, seems like a good place to
start.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #8 from Vlad Zagorodniy  ---
It looks like zoom effect supported this feature previously.
https://phabricator.kde.org/source/kwin/browse/master/effects/zoom/zoom.cpp$220-237

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #7 from Vlad Zagorodniy  ---
(In reply to Christoph Feck from comment #5)
> Are you sure KMag is compiled with QtAccessibilityClient dependency?

I'm using KMag from Arch Linux repos. According to the PKGBUILD [1], it looks
like KMag is indeed compiled with QtAccessibilityClient.

[1]
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/kmag#n13

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362189

Christoph Feck  changed:

   What|Removed |Added

 CC||gladh...@kde.org

--- Comment #6 from Christoph Feck  ---
I have to admit that I enabled building the Qt5 port of KMag with accessibility
support without being able to test if it works. I had hoped someone from the
accessibility list commit could confirm.

See
https://cgit.kde.org/kmag.git/commit/?id=1f8e4208d72c7f9ce6fa739f477151aab1fadccf

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #5 from Christoph Feck  ---
Are you sure KMag is compiled with QtAccessibilityClient dependency?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #4 from Vlad Zagorodniy  ---
Created attachment 116195
  --> https://bugs.kde.org/attachment.cgi?id=116195=edit
KMag

I'm not sure whether "Focus" is the correct mode, but the magnified area
doesn't follow caret.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #3 from Christoph Feck  ---
See
https://cgit.kde.org/kmag.git/commit/?id=2c55d1e56c26582bc29e99f17028291aa0d1aa3b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #2 from Christoph Feck  ---
This used to work in KMag, at least the last time I tried it in Qt4 times. I am
not sure about the status of accessibility integration in Qt5, but I guess the
infrastructure is all there. I suggest to ask in kde-accessibility list.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=362189

--- Comment #1 from Vlad Zagorodniy  ---
@Martin
Is this implementable? I guess we need some sort of protocol for such thing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 362189] a11y: Keyboard (caret) tracking for the Zoom feature

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362189

Martin Gräßlin  changed:

   What|Removed |Added

  Component|general |effects-various

-- 
You are receiving this mail because:
You are watching all bug changes.