[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/kwin
   ||/d910217bb97402b9fd3bf29ff5
   ||753fc3579cd38b

--- Comment #14 from Martin Gräßlin  ---
Git commit d910217bb97402b9fd3bf29ff5753fc3579cd38b by Martin Gräßlin.
Committed on 14/09/2016 at 08:44.
Pushed by graesslin into branch 'master'.

[effects] Repaint expandedGeometry in HighlightWindowsEffect

Summary:
The highlight windows effect tried to trigger repaints with the shadow
included by having an hardcoded pixel offset. This of course breaks if
the shadow is larger than the hardcoded value.

The reason presented on why it was done like that is no longer true and
in the effects the actual visible area including decorations and shadows
is available through the expandedGeometry.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D2748

M  +2-2effects/highlightwindow/highlightwindow.cpp

http://commits.kde.org/kwin/d910217bb97402b9fd3bf29ff5753fc3579cd38b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Alexandre Pereira via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #13 from Alexandre Pereira  ---
Thanks !

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D2748

--- Comment #12 from Martin Gräßlin  ---
Fix at: https://phabricator.kde.org/D2748

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #11 from Martin Gräßlin  ---
(In reply to Alexandre Pereira from comment #9)
> its shadow size of 64px, sorry

Thanks, with these settings I'm able to reproduce

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Alexandre Pereira via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #10 from Alexandre Pereira  ---
See video: https://youtu.be/moSbI5KsVM0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Alexandre Pereira via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #9 from Alexandre Pereira  ---
its shadow size of 64px, sorry. uploading video to show

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Alexandre Pereira via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #8 from Alexandre Pereira  ---
Tested with normal taskmanager: it also breaks on master, if on panel. If its a
single plasmoid on the desktop, it doesn't break.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Alexandre Pereira via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #7 from Alexandre Pereira  ---
Its breeze decoration but with shadow size of 65px and strength 75%.

I am able to use nowdock in master when i comment that line in main.qml:

--- a/contents/ui/main.qml
+++ b/contents/ui/main.qml
@@ -168,7 +168,7 @@ Item {
 id: tasksModel

 virtualDesktop: virtualDesktopInfo.currentDesktop
-screen: plasmoid.screen
+// screen: plasmoid.screen
 activity: activityInfo.currentActivity

 filterByVirtualDesktop: plasmoid.configuration.showOnlyCurrentDesktop

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #6 from Martin Gräßlin  ---
So far I didn't find any window decoration which breaks. Could you please tell
me which decoration you used in that screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

Martin Gräßlin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Martin Gräßlin  ---
urgh I found the problem:
effects->addRepaint(w->geometry().adjusted(-16,-16,16,32)); // add some
padding. w->addRepaintFull() is wrong for at least isInitiallyHidden ...

With a large shadow that's just going to break, changing decoration to
reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #4 from Martin Gräßlin  ---
and NowDock I cannot test because it fails with Plasma 5.8 (no screen property)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #3 from Martin Gräßlin  ---
Interesting with "normal" task bar I am not able to reproduce the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

Martin Gräßlin  changed:

   What|Removed |Added

  Component|general |effects-various

--- Comment #2 from Martin Gräßlin  ---
Looks like an incorrect repaint in highlight windows. Should be fairly simple
to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 368495] Window highlight of minimized windows creates clipping with windows's shadow

[Alexandre Pereira via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=368495

--- Comment #1 from Alexandre Pereira  ---
Sorry, in the description, the image URL is : http://imgur.com/a/CX6wM

https://github.com/psifidotos/nowdock-plasmoid/issues/28 is the url where I
reported it to nowdock

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.