[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-09 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Martin Gräßlin  ---
I never noticed, good spot!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-29 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||Wayland+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-30 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=370345

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
It seems it doesn't take into account the window decoration.

Even when I start resizing a window just horizontally, as soon as the resize
operation starts, the window's height reduces roughly by the height of the
window decoration.

I can reproduce this with Qt applications running as Wayland clients but not
when running the very same application with XCB platform. (This is not implying
that this is a Qt-only problem, I just can't think of a non-Qt application I
could run on Wayland to test his).

Also doesn't matter whether I'm using the window borders to resize or
Alt+right-click.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-30 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=370345

--- Comment #3 from Kai Uwe Broulik  ---
Indeed, if I manually disable decorations (window menu → More Actions → No
Borders) resizing works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-11-18 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D3414

--- Comment #4 from Martin Gräßlin  ---
Fix at: https://phabricator.kde.org/D3414

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-11-18 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kwin
   ||/16c7650d760f2d0b9e2d0d826b
   ||820963dc3d018c
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.8.4

--- Comment #5 from Martin Gräßlin  ---
Git commit 16c7650d760f2d0b9e2d0d826b820963dc3d018c by Martin Gräßlin.
Committed on 18/11/2016 at 11:36.
Pushed by graesslin into branch 'Plasma/5.8'.

Fix AbstractClient::sizeForClientSize

Summary:
The method is supposed to return the AbstractClient's size for a given
client size. That is the size including the window decoration.

The default implementation returned the passed in client size without
adjusting for the decoration. This resulted in ShellClient getting a
wrong size especially when AbstractClient::adjustedClientSize (which
calls sizeForClientSize) was called.

The result of the incorrect size was for example a shrinking of the
window when starting to resize a window.
FIXED-IN: 5.8.4

Reviewers: #kwin, #plasma_on_wayland, broulik, subdiff

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D3414

M  +1-1abstract_client.cpp
M  +1-0autotests/integration/shell_client_test.cpp

http://commits.kde.org/kwin/16c7650d760f2d0b9e2d0d826b820963dc3d018c

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-09 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Martin Gräßlin  ---
I never noticed, good spot!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-29 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||Wayland+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-30 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=370345

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
It seems it doesn't take into account the window decoration.

Even when I start resizing a window just horizontally, as soon as the resize
operation starts, the window's height reduces roughly by the height of the
window decoration.

I can reproduce this with Qt applications running as Wayland clients but not
when running the very same application with XCB platform. (This is not implying
that this is a Qt-only problem, I just can't think of a non-Qt application I
could run on Wayland to test his).

Also doesn't matter whether I'm using the window borders to resize or
Alt+right-click.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-10-30 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=370345

--- Comment #3 from Kai Uwe Broulik  ---
Indeed, if I manually disable decorations (window menu → More Actions → No
Borders) resizing works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-11-18 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D3414

--- Comment #4 from Martin Gräßlin  ---
Fix at: https://phabricator.kde.org/D3414

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 370345] Resizing Qt based apps with grab to window border pushes window short distance away from cursor

2016-11-18 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=370345

Martin Gräßlin  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/kwin
   ||/16c7650d760f2d0b9e2d0d826b
   ||820963dc3d018c
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.8.4

--- Comment #5 from Martin Gräßlin  ---
Git commit 16c7650d760f2d0b9e2d0d826b820963dc3d018c by Martin Gräßlin.
Committed on 18/11/2016 at 11:36.
Pushed by graesslin into branch 'Plasma/5.8'.

Fix AbstractClient::sizeForClientSize

Summary:
The method is supposed to return the AbstractClient's size for a given
client size. That is the size including the window decoration.

The default implementation returned the passed in client size without
adjusting for the decoration. This resulted in ShellClient getting a
wrong size especially when AbstractClient::adjustedClientSize (which
calls sizeForClientSize) was called.

The result of the incorrect size was for example a shrinking of the
window when starting to resize a window.
FIXED-IN: 5.8.4

Reviewers: #kwin, #plasma_on_wayland, broulik, subdiff

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D3414

M  +1-1abstract_client.cpp
M  +1-0autotests/integration/shell_client_test.cpp

http://commits.kde.org/kwin/16c7650d760f2d0b9e2d0d826b820963dc3d018c

-- 
You are receiving this mail because:
You are watching all bug changes.