[kwin] [Bug 371573] Move resize window on empty area only works every second time

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=371573

Martin Gräßlin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/kwin
   ||/82054a406a6470c763d72c39f6
   ||c7fdf5667ee629
 Resolution|--- |FIXED
   Version Fixed In||5.8.3

--- Comment #4 from Martin Gräßlin  ---
Git commit 82054a406a6470c763d72c39f6c7fdf5667ee629 by Martin Gräßlin.
Committed on 31/10/2016 at 10:51.
Pushed by graesslin into branch 'Plasma/5.8'.

Send a pointer leave when triggering a move resize

Summary:
When triggering a move resize all following pointer events are grabbed
by KWin itself. Thus the correct behavior is to informe the client about
it and send a pointer leave.

This ensures that after the move resize ended the pointer gets a new
enter. By sending anew pointer enter the position gets updated to the
new position which so far did not happen and the client generated events
on the wrong position.
FIXED-IN: 5.8.3

Reviewers: #kwin, #plasma_on_wayland, broulik

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D3154

M  +69   -1autotests/integration/move_resize_window_test.cpp
M  +15   -0pointer_input.cpp
M  +1-0pointer_input.h

http://commits.kde.org/kwin/82054a406a6470c763d72c39f6c7fdf5667ee629

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 371573] Move resize window on empty area only works every second time

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=371573

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||Wayland+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 371573] Move resize window on empty area only works every second time

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371573

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D3154

--- Comment #3 from Martin Gräßlin  ---
Possible patch at https://phabricator.kde.org/D3154

>From my testing it works fine except for the following situation:
1. trigger move
2. don't move mouse
3. try to trigger again

weston-terminal has no problem with this situation so that might be a problem
on the client side of the stack.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 371573] Move resize window on empty area only works every second time

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371573

Martin Gräßlin  changed:

   What|Removed |Added

  Component|wayland-generic |input

--- Comment #2 from Martin Gräßlin  ---
I'm able to reproduce also with weston-terminal. The input offset position does
not get updated correctly when the window gets moved. Moving the pointer out of
the window and back in again makes every move trigger the window.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 371573] Move resize window on empty area only works every second time

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371573

Martin Gräßlin  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Martin Gräßlin  ---
I guess the release of the button is never sent to the application as KWin
grabs it.

-- 
You are receiving this mail because:
You are watching all bug changes.