[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #33 from Michael D  ---
The bug's returned for me as well, at least on wayland, plasma 5.24.1. Was
another report ever filed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #32 from Michael D  ---
Don't have this issue on Manjaro testing, plasma 5.23.5.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nicholas Serrano]

https://bugs.kde.org/show_bug.cgi?id=376104

Nicholas Serrano <2019nicho...@gmail.com> changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=449541

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376104

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #31 from Nate Graham  ---
Can you please file a new bug report and put it in the "See also" field for
this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nicholas Serrano]

https://bugs.kde.org/show_bug.cgi?id=376104

Nicholas Serrano <2019nicho...@gmail.com> changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||2019nicho...@gmail.com
 Resolution|FIXED   |---

--- Comment #30 from Nicholas Serrano <2019nicho...@gmail.com> ---
Currently using Fedora 35 and it seems this bugged behavior has returned at
some point. Using a keybind to quick tile a currently maximized window causes
the window to unmaximize but not tile as desired until a subsequent quick tile
bind is pressed. Has anyone else run into this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[jingyu9575]

https://bugs.kde.org/show_bug.cgi?id=376104

jingyu9575  changed:

   What|Removed |Added

 CC|qw2...@zoho.eu  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Brendon Higgins]

https://bugs.kde.org/show_bug.cgi?id=376104

Brendon Higgins  changed:

   What|Removed |Added

 CC||bren...@quantumfurball.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=376104

Martin Flöser  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.12.0
  Latest Commit||https://commits.kde.org/kwi
   ||n/8a2796d280dd7e891724cb6e6
   ||d873a57e2ae8c52

--- Comment #29 from Martin Flöser  ---
Git commit 8a2796d280dd7e891724cb6e6d873a57e2ae8c52 by Martin Flöser.
Committed on 04/12/2017 at 16:25.
Pushed by graesslin into branch 'master'.

Fix regression from KWin 5.9 regarding quick tiling

Summary:
The regression got introduced with 9934f5b57537feae54afd0c4366c90253638ada2.
The order when setMaximize(false, false) was called changed in regard to
when the quick tiling mode was adjusted. But just changing the ordering
back was no solution as that would cause regressions in other areas
(unit tests fail).

This change builds up on the support for geometry update blocker on
Wayland to be able to better support this situation without causing
further regressions.

Also this change rethinks the code area. There is an idea behind
temporarily setting the quick tile mode to none and that is even
documented in a comment: it should not confuse maximize. So let's do
exactly that: call the maximize in the block where the quick tile
mode is temporarily wrong. As that is only one branch the else branch
performs the same steps.
FIXED-IN: 5.12.0

Test Plan: Confirmation in bug report that patch fixes issue

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D9178

M  +0-16   autotests/integration/quick_tiling_test.cpp
M  +8-5geometry.cpp

https://commits.kde.org/kwin/8a2796d280dd7e891724cb6e6d873a57e2ae8c52

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376104

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Till Schäfer]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #28 from Till Schäfer  ---
I applied the patch here on kwin 5.11.3 running on xorg-server 1.19.5 and it
works like a charm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #27 from Martin Flöser  ---
Created attachment 109016
  --> https://bugs.kde.org/attachment.cgi?id=109016=edit
Proposed patch

Attached is a patch built up on the suggestions we had so far. The suggestions
didn't work, it broke existing test cases. This patch fixes the issue according
to the tests and does not introduce regressions in other tests.

Please give it a try.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Flupp]

https://bugs.kde.org/show_bug.cgi?id=376104

Flupp  changed:

   What|Removed |Added

 CC||bugs.kde.org@derflupp.e4war
   ||d.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Andrew]

https://bugs.kde.org/show_bug.cgi?id=376104

Andrew  changed:

   What|Removed |Added

 CC||andrewnguyen...@gmail.com

--- Comment #26 from Andrew  ---
I have a similar issue with kwin 5.10.5 on Debian Testing Linux. I have quick
tile shortcuts assigned to Meta+Up/Down/Left/Right and whenever I attempt to
quick-tile a maximized window via shortcut, it de-maximizes before I am able to
quick tile it. If I activate the shortcut a second time, the window tiles as
expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=376104

Martin Flöser  changed:

   What|Removed |Added

 CC||k...@dhardy.name

--- Comment #25 from Martin Flöser  ---
*** Bug 385904 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #24 from Martin Flöser  ---
The simple fix does not address the problem why the code changed like that in
the first place. If we revert that part we just run into issues elsewhere in
the code. We need a complete solution taking care of the required behavior on
X11 and Wayland.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #23 from Nate Graham  ---
Antoscha, it looks like that simple fix doesn't address Martin's concerns.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Michael D]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #22 from Michael D  ---
The bug I originally reported, https://bugs.kde.org/show_bug.cgi?id=376224,
marked as a duplicate of this one, isn't solved in 5.11.0 (KDE Neon). If I tile
a vertically maximized window, instead of tiling it, it brings it back to its
original (pre-maximized) dimensions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Antoscha]

https://bugs.kde.org/show_bug.cgi?id=376104

Antoscha  changed:

   What|Removed |Added

 CC||archmizu...@gmail.com

--- Comment #21 from Antoscha  ---
(In reply to Nate Graham from comment #19) 
--- kwin-5.11.0/geometry.cpp2017-10-12 15:13:48.467815000 +0300
+++ kwin-5.11.0/geometry.cpp2017-10-12 15:13:34.340537140 +0300
@@ -3355,6 +3355,8 @@
 if (maximizeMode() != MaximizeRestore) {

 TabSynchronizer syncer(this,
TabGroup::QuickTile|TabGroup::Geometry|TabGroup::Maximized);
+
+setMaximize(false, false);

 if (mode != QuickTileMode(QuickTileFlag::None)) {
 m_quickTileMode = mode;

This patch fixes the issue in 5.11.0. Tested in Archlinux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376104

jingyu9...@hotmail.com changed:

   What|Removed |Added

 CC||jingyu9...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #20 from Martin Flöser  ---
(In reply to Nate Graham from comment #19)
> Martin, since we do have test cases for X11 now, is this something we can
> get submitted to Phabricator as a patch?

No as it does not address the reasons on why the code was moved in first place.
Just reverting a commit does not fix things, it causes issues in other places.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=376104

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376104

--- Comment #19 from Nate Graham  ---
Migrating info from duped bugs:

This seems to have been caused by
https://cgit.kde.org/kwin.git/commit/?id=9934f5b57537feae54afd0c4366c90253638ada2


The following quick-and-dirty patch seems to resolve it for some people:

--- a/geometry.cpp  2017-03-21 21:54:36.0 +0800
+++ b/geometry.cpp  2017-03-23 19:11:02.872123167 +0800
@@ -3326,6 +3326,8 @@

 TabSynchronizer syncer(this,
TabGroup::QuickTile|TabGroup::Geometry|TabGroup::Maximized);

+setMaximize(false, false);
+
 if (mode != QuickTileNone) {
 m_quickTileMode = mode;
 // decorations may turn off some borders when tiled
@@ -3336,8 +3338,6 @@
 // Store the mode change
 m_quickTileMode = mode;

-setMaximize(false, false);
-
 emit quickTileModeChanged();

 return;


Martin, since we do have test cases for X11 now, is this something we can get
submitted to Phabricator as a patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376104] Quick tile window to any screen edge or corner de-maximizes the window without tiling as a first action since plasma 5.9.0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376104

Nate Graham  changed:

   What|Removed |Added

Summary|"Quick tile window to the   |Quick tile window to any
   |left/right" de-maximizes|screen edge or corner
   |the window without tiling   |de-maximizes the window
   |as a first action since |without tiling as a first
   |plasma 5.9.0|action since plasma 5.9.0

-- 
You are receiving this mail because:
You are watching all bug changes.