[kwin] [Bug 380391] Titlebar height is not set properly after it is changed from empty string

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=380391

--- Comment #5 from Hugo Pereira Da Costa  ---
Git commit 4f0940b79001ae8b400d01a8abf63d03b8dbd9fc by Hugo Pereira Da Costa.
Committed on 06/06/2017 at 16:06.
Pushed by hpereiradacosta into branch 'Plasma/5.10'.

use fontMetrics.height() rather than boundingRect(...).height()
the height of the title bar should not depend on the caption content.

M  +1-1kdecoration/breezedecoration.cpp

https://commits.kde.org/breeze/4f0940b79001ae8b400d01a8abf63d03b8dbd9fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 380391] Titlebar height is not set properly after it is changed from empty string

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=380391

--- Comment #4 from Hugo Pereira Da Costa  ---
Was able to test with the provided java code (thanks !)
Now fixed.
Will backport and also fix oxygen.
Thanks for reporting the issue

Hugo

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 380391] Titlebar height is not set properly after it is changed from empty string

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=380391

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 380391] Titlebar height is not set properly after it is changed from empty string

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=380391

--- Comment #3 from Hugo Pereira Da Costa  ---
Git commit 2cc0f8ba2da50ca3efa500ebdcc3655c8d0e47f8 by Hugo Pereira Da Costa.
Committed on 06/06/2017 at 15:47.
Pushed by hpereiradacosta into branch 'master'.

use fontMetrics.height() rather than boundingRect(...).height()
the height of the title bar should not depend on the caption content.

M  +1-1kdecoration/breezedecoration.cpp

https://commits.kde.org/breeze/2cc0f8ba2da50ca3efa500ebdcc3655c8d0e47f8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 380391] Titlebar height is not set properly after it is changed from empty string

[Hugo Pereira Da Costa]

https://bugs.kde.org/show_bug.cgi?id=380391

--- Comment #2 from Hugo Pereira Da Costa  ---
Hi Christoph

Probably a breeze bug.
When we calculate the decoration borders we use: 
fm.boundingRect(c->caption()) (fm being fontMetrics)
So when caption is empty, this gives 0.
It is then not updated on caption change.
I guess I shoud just use fm.height()
(after all you do not want the size of the decoration to change depending on
the caracters that appear in the caption !)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 380391] Titlebar height is not set properly after it is changed from empty string

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=380391

Christoph Feck  changed:

   What|Removed |Added

 CC||hugo.pereira.da.costa@gmail
   ||.com

--- Comment #1 from Christoph Feck  ---
Hugo, could you check if this is a KWin or breeze decoration issue?

-- 
You are receiving this mail because:
You are watching all bug changes.