[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #29 from Vlad Zahorodnii --- Git commit bebe812094737a357ad825c6b850ce9302bf by Vlad Zahorodnii, on behalf of Vlad Zagorodniy. Committed on 23/09/2019 at 14:28. Pushed by vladz into branch 'master'. Port QPA away from Wayland Summary: So far wayland was used by internal clients to submit raster buffers and position themselves on the screen. While we didn't have issues with submitting raster buffers, there were some problems with positioning task switchers. Mostly, because we had effectively two paths that may alter geometry. A better approach to deal with internal clients is to let our QPA use kwin core api directly. This way we can eliminate unnecessary roundtrips as well make geometry handling much easier and comprehensible. The last missing piece is shadows. Both Plasma::Dialog and Breeze widget style use platform-specific APIs to set and unset shadows. We need to add shadows API to KWindowSystem. Even though some internal clients lack drop-shadows at the moment, I don't consider it to be a blocker. We can add shadows back later on. Reviewers: #kwin, davidedmundson, romangg Reviewed By: #kwin, romangg Subscribers: romangg, kwin Tags: #kwin Maniphest Tasks: T9600 Differential Revision: https://phabricator.kde.org/D22810 M +6-0abstract_client.cpp M +9-0abstract_client.h M +9-7autotests/integration/debug_console_test.cpp M +8-6autotests/integration/decoration_input_test.cpp M +5-3 autotests/integration/effects/popup_open_close_animation_test.cpp M +6-4autotests/integration/globalshortcuts_test.cpp M +44 -54 autotests/integration/internal_window.cpp M +18 -18 composite.cpp M +32 -46 debug_console.cpp M +3-2debug_console.h M +7-1deleted.cpp M +2-0deleted.h M +14 -9effects.cpp M +1-4geometry.cpp M +4-0idle_inhibition.cpp M +6-5input.cpp M +469 -120 internal_client.cpp M +62 -15 internal_client.h M +6-6layers.cpp M +113 -5platformsupport/scenes/opengl/abstract_egl_backend.cpp M +2-0platformsupport/scenes/opengl/abstract_egl_backend.h M +0-2plugins/qpa/CMakeLists.txt M +45 -70 plugins/qpa/backingstore.cpp M +3-15 plugins/qpa/backingstore.h M +3-61 plugins/qpa/integration.cpp M +2-18 plugins/qpa/integration.h D +0-106 plugins/qpa/nativeinterface.cpp D +0-47 plugins/qpa/nativeinterface.h M +7-5plugins/qpa/sharingplatformcontext.cpp M +40 -49 plugins/qpa/window.cpp M +10 -34 plugins/qpa/window.h M +22 -2plugins/scenes/opengl/scene_opengl.cpp M +10 -0plugins/scenes/qpainter/scene_qpainter.cpp M +9-10 pointer_input.cpp M +7-11 scene.cpp M +8-0scene.h M +7-42 shell_client.cpp M +5-20 shell_client.h M +1-1tabbox/tabbox.cpp M +5-9toplevel.cpp M +18 -5toplevel.h M +2-35 wayland_server.cpp M +0-5wayland_server.h M +47 -25 workspace.cpp M +40 -5workspace.h https://commits.kde.org/kwin/bebe812094737a357ad825c6b850ce9302bf -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Roman Gilg changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED Latest Commit|https://commits.kde.org/kwi |https://commits.kde.org/kwi |n/1fb2eace3fbfc6645e024aa0f |n/7c7fb758ad66033c63354c0d7 |5003306ac60a417 |1780eb47dc218ce --- Comment #28 from Roman Gilg --- Git commit 7c7fb758ad66033c63354c0d71780eb47dc218ce by Roman Gilg. Committed on 05/06/2019 at 14:40. Pushed by romangilg into branch 'Plasma/5.16'. Avoid again invalid geometry of internal clients Summary: This adds again the workaround from 1fb2eace3fbf, which got temporarily removed by 9b922f88332f. Test Plan: Manually Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21601 M +6-1shell_client.cpp https://commits.kde.org/kwin/7c7fb758ad66033c63354c0d71780eb47dc218ce -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #27 from Vlad Zagorodniy --- (In reply to Roman Gilg from comment #26) > This hasn't been fixed for 5.16, right? The workaround should then be added > back again, which got removed in 9b922f88332fc470dcb50e9b55c7d69ab7da4d4c. ack, do you want to submit the patch? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #26 from Roman Gilg --- This hasn't been fixed for 5.16, right? The workaround should then be added back again, which got removed in 9b922f88332fc470dcb50e9b55c7d69ab7da4d4c. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Patrick Silva changed: What|Removed |Added Version|5.13.0 |5.15.90 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #25 from Roman Gilg --- Since there is now again enough time on the next release, maybe a proper fix can land before that. If we don't find one in time, the if-conditional can be added back shortly before release. Should still work as a workaround. Of course not so convenient for people on Dev Unstable until then, but it's not a fatal bug. Thanks for reporting back and reopening Patrick. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #24 from Martin Flöser --- Also blocked on me having less time currently. Hopefully next week... -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #23 from David Edmundson --- I think there's a solution coming. Once we kill the wl_surface from the internal windows all the races go away and it will "just work". AFAIK that's blocked mostly on shadows that I started. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #22 from Vlad Zagorodniy --- > We need to fix that then As any other bug ;-) There were definitely some problems with 1fb2eac (if you read the review comments), so we have to find a better solution. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #21 from Nate Graham --- We need to fix that then, because these task switchers are supposed to be centered. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #20 from Vlad Zagorodniy --- I'd say that was intentional, see 9b922f88332fc470dcb50e9b55c7d69ab7da4d4c -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Patrick Silva changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #19 from Patrick Silva --- This bug is back on neon dev unstable. The following task switchers are not centered on screen: compact thumbnails grid large icons small icons text only informative breeze dark -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Roman Gilg changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kwi ||n/1fb2eace3fbfc6645e024aa0f ||5003306ac60a417 Resolution|--- |FIXED --- Comment #18 from Roman Gilg --- Git commit 1fb2eace3fbfc6645e024aa0f5003306ac60a417 by Roman Gilg. Committed on 03/09/2018 at 09:25. Pushed by romangilg into branch 'master'. Avoid invalid geometry of internal clients through plasma surface interface Summary: Internal KWin windows might be not in sync with their PlasmaShellSurface. This could be a problem in general, but for now atleast guard against invalid setPosition requests. Test Plan: Manually Reviewers: #kwin, davidedmundson Subscribers: davidedmundson, ngraham, graesslin, kwin Tags: #kwin Maniphest Tasks: T8771 Differential Revision: https://phabricator.kde.org/D13084 M +6-1shell_client.cpp https://commits.kde.org/kwin/1fb2eace3fbfc6645e024aa0f5003306ac60a417 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #17 from Nate Graham --- *** Bug 397586 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 David Edmundson changed: What|Removed |Added CC||jfeb...@gmail.com --- Comment #16 from David Edmundson --- *** Bug 397032 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Dr. Chapatin changed: What|Removed |Added Version|5.12.90 |5.13.0 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #15 from Roman Gilg --- Potential fix: https://phabricator.kde.org/D13084 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #14 from Roman Gilg --- I have created a Phab task for in-depth technical discussion of the problem(s): https://phabricator.kde.org/T8771 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Dr. Chapatin changed: What|Removed |Added Version|unspecified |5.12.90 Platform|openSUSE RPMs |Archlinux Packages -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #13 from Nate Graham --- If you fix this, I'll be really close to being able to make the switch to Wayland full time! :) -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Roman Gilg changed: What|Removed |Added CC||subd...@gmail.com --- Comment #12 from Roman Gilg --- I investigated this problem a bit further. At this late position https://phabricator.kde.org/source/kwin/browse/master/tabbox/tabboxhandler.cpp;184b490c78a3a3e5ae25105c08b19fc375e8c64c$395 the correct d->window()->x() value is still set (in my case to 498). Some time later it gets reset to 0 for some reason. For example in the delayed call to initHighlightWindows it is already 0. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Dr. Chapatin changed: What|Removed |Added CC||i...@xuzhao.net --- Comment #11 from Dr. Chapatin --- *** Bug 394153 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Alexander Mentyu changed: What|Removed |Added CC||notux...@gmail.com --- Comment #10 from Alexander Mentyu --- Sometimes after changing of visualization in Task Switcher - it appears in the center (looks like more likely after changing into 'Grid' visualization - using it - and changing back into 'Breeze Dark' for example) - and also after some time of changing of various visualizations - they all starting to show up in the center Plasma: 5.12.4 Apps: 17.12.4 Frameworks: 5.44.0 Qt: 5.10.1 Kernel: 4.14.32-1-MANJARO OS: Netrunner Rolling Video: Intel 4400 Driver: xf86-video-intel 1:2.99.917+823+gd9bf46e4-1 Screen: 1600x900 wayland-protocols 1.13-1 wayland 1.14.0-1 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 adikur...@gmail.com changed: What|Removed |Added CC||adikur...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #9 from Dr. Chapatin --- (In reply to Michael D from comment #8) > It centers for me on the first invocation sometimes, but then the entries > are not highlighted. On the next invocation, it appears at the top left. Same on my system. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Michael D changed: What|Removed |Added CC||nortex...@gmail.com --- Comment #8 from Michael D --- It centers for me on the first invocation sometimes, but then the entries are not highlighted. On the next invocation, it appears at the top left. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #7 from pbs3...@googlemail.com --- Also: sometimes the task switcher or just its background blur momentarily appears in the screen centre. Observed on plasma 5.12. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #6 from Dr. Chapatin --- plasma 5.12 beta is affected. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Nate Graham changed: What|Removed |Added Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Dr. Chapatin changed: What|Removed |Added CC||pointedst...@zoho.com --- Comment #5 from Dr. Chapatin --- *** Bug 387456 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #4 from Martin Flöser --- So tried some more. When using multi screen it works sometimes. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Martin Flöser changed: What|Removed |Added Ever confirmed|0 |1 Keywords||reproducible Status|UNCONFIRMED |CONFIRMED --- Comment #3 from Martin Flöser --- Just tried and can reproduce. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 Martin Flöser changed: What|Removed |Added Flags||Wayland+, X11- -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #2 from Dr. Chapatin --- version 5.11.90git.20171028T043813~145bfd168-93.1 "large icons" switcher is affected too. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 386304] [Wayland] Several task switchers are not centered on screen
https://bugs.kde.org/show_bug.cgi?id=386304 --- Comment #1 from Martin Flöser --- Which exact version are you using? -- You are receiving this mail because: You are watching all bug changes.
