[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

Martin Flöser  changed:

   What|Removed |Added

   Version Fixed In||5.12.3
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||n/e1afef3d4563803249dc25487
   ||bc086f753c4e0ea
 Status|UNCONFIRMED |RESOLVED

--- Comment #19 from Martin Flöser  ---
Git commit e1afef3d4563803249dc25487bc086f753c4e0ea by Martin Flöser.
Committed on 05/03/2018 at 18:31.
Pushed by graesslin into branch 'Plasma/5.12'.

Sanity check WindowQuad before trying to create a grid out of it

Summary:
When one uses:
 * breeze as of 5.12
 * wobbly windows
 * shaded window
 * a distribution building with assert enabled

and starts to move a shaded window, KWin asserts. The root cause for
this is that WindowQuad::makeSubQuad has an assert for y1 being smaller
than y2. With the combination listed above this is not guaranteed. For
the left shadow quad the y1 and y2 are identical and thus trying to
split it, results in the assert condition.

The problem of the shadow quad having an invalid size might be addressed
as well with D10811. Due to that the generation of the quads is not
touched. Instead a sanity check is introduced to not try to split
already invalid sized quads.
FIXED-IN: 5.12.3

Test Plan: Added unit test hit the assert, now doesn't hit it any more

Reviewers: #kwin, #plasma

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D11015

M  +1-0autotests/integration/effects/CMakeLists.txt
A  +197  -0autotests/integration/effects/wobbly_shade_test.cpp
[License: GPL (v2)]
M  +12   -0libkwineffects/kwineffects.cpp

https://commits.kde.org/kwin/e1afef3d4563803249dc25487bc086f753c4e0ea

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #18 from luca  ---
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

Martin Flöser  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D11015
  Flags||Wayland+, X11+,
   ||ReviewRequest+

--- Comment #17 from Martin Flöser  ---
Patch at: https://phabricator.kde.org/D11015

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #16 from Martin Flöser  ---
I was able to reproduce the issue and investigate it. The problem is caused by
an invalid sized WindowQuad of the decoration shadow. So the change in shadow
size in 5.12 might have triggered it. To make it clear: this is not a bug in
breeze! Breeze is just the one who triggers the bug in KWin.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

Martin Flöser  changed:

   What|Removed |Added

 CC||mickth...@hotmail.com

--- Comment #15 from Martin Flöser  ---
*** Bug 391371 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #14 from luca  ---
(In reply to Martin Flöser from comment #13)

>  * the decoration is irrelevant for this crash

Yes, but shaded woobly windows with breeze decoration triggers it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #13 from Martin Flöser  ---
We can be pretty sure that:
 * the OpenGL driver is irrelevant for this crash
 * the decoration is irrelevant for this crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #12 from luca  ---
(In reply to Hugo Pereira Da Costa from comment #11)

> 
> For the record: I use breeze decoration + wobbly window + opengl backgend 2,
> and cannot reproduce. (not that it proves anything).

with nvidia driver?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

luca  changed:

   What|Removed |Added

Product|Breeze  |kwin
   Assignee|hugo.pereira.da.costa@gmail |kwin-bugs-n...@kde.org
   |.com|
  Component|window decoration   |compositing

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #10 from luca  ---
decaration=decorations

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #9 from luca  ---
I noticed this behaviour with breeze windows decaration, but not with plastik
or dark-translucent. It seems breeze related.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #8 from Martin Flöser  ---
(In reply to luca from comment #7)
> I hope it helps.
> I noticed this regression after 5.10.2 -> 5.12.0 plasma update

Actually I doubt that this is a regression. More likely is a change in how it
gets compiled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #7 from luca  ---
I hope it helps.
I noticed this regression after 5.10.2 -> 5.12.0 plasma update

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #6 from Martin Flöser  ---
(In reply to luca from comment #5)
> the culprit is "woobly windows" effect.
> it works fine with every windows, but not if shaded

thanks, that's a really important information. We have a few similar crash
reports which I was never able to reproduce. I hope that this combination makes
it possible to reproduce now. Given the crashers we have I can imagine that
this combination triggers it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

Martin Flöser  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #5 from luca  ---
the culprit is "woobly windows" effect.
it works fine with every windows, but not if shaded

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #4 from luca  ---
Created attachment 110943
  --> https://bugs.kde.org/attachment.cgi?id=110943=edit
with libkwineffects11-dbgsym

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #3 from Martin Flöser  ---
could you try to install also dbgsym for libkwineffects?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #2 from Martin Flöser  ---
Application: KWin (kwin_x11), signal: Aborted
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f429d996f40 (LWP 27189))]

Thread 5 (Thread 0x7f425b98c700 (LWP 27203)):
#0  0x7f42963e47fd in pthread_cond_wait@@GLIBC_2.3.2 () from
/lib/x86_64-linux-gnu/libpthread.so.0
#1  0x7f42996965f4 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Script.so.5
#2  0x7f4299696639 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Script.so.5
#3  0x7f42963de51a in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#4  0x7f429d3183ef in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 4 (Thread 0x7f427739f700 (LWP 27200)):
#0  0x7f429d30df66 in ppoll () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x7f429a786dc1 in qt_safe_poll(pollfd*, unsigned long, timespec const*)
() from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x7f429a7884de in
QEventDispatcherUNIX::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f429a7302aa in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f429a54f35a in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f4294ecf0a5 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#6  0x7f429a55422d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f42963de51a in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#8  0x7f429d3183ef in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 3 (Thread 0x7f427dede700 (LWP 27195)):
#0  0x7ffdb5959ad5 in clock_gettime ()
#1  0x7f429d325bd6 in clock_gettime () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x7f429a78aa21 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#3  0x7f429a789259 in QTimerInfoList::updateCurrentTime() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#4  0x7f429a789835 in QTimerInfoList::timerWait(timespec&) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f429a7887e4 in
QEventDispatcherUNIX::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f429a7302aa in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f429a54f35a in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8  0x7f4293da4e45 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#9  0x7f429a55422d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x7f42963de51a in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#11 0x7f429d3183ef in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 2 (Thread 0x7f4280531700 (LWP 27192)):
#0  0x7f429d30de6b in poll () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x7f429c230150 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#2  0x7f429c231ee9 in xcb_wait_for_event () from
/usr/lib/x86_64-linux-gnu/libxcb.so.1
#3  0x7f428120e029 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#4  0x7f429a55422d in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f42963de51a in start_thread () from
/lib/x86_64-linux-gnu/libpthread.so.0
#6  0x7f429d3183ef in clone () from /lib/x86_64-linux-gnu/libc.so.6

Thread 1 (Thread 0x7f429d996f40 (LWP 27189)):
[KCrash Handler]
#6  0x7f429d2576a0 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#7  0x7f429d258cf7 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#8  0x7f429d24ffca in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#9  0x7f429d250042 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
#10 0x7f4299f03914 in KWin::WindowQuad::makeSubQuad(double, double, double,
double) const () from /usr/lib/x86_64-linux-gnu/libkwineffects.so.11
#11 0x7f4299f06883 in KWin::WindowQuadList::makeRegularGrid(int, int) const
() from /usr/lib/x86_64-linux-gnu/libkwineffects.so.11
#12 0x7f4299c6ce83 in ?? () from
/usr/lib/x86_64-linux-gnu/libkwin4_effect_builtins.so.1
#13 0x7f429cea4671 in KWin::EffectsHandlerImpl::prePaintWindow
(this=0x55865e603380, w=, data=..., time=) at
./effects.cpp:410
#14 0x7f429cea4671 in KWin::EffectsHandlerImpl::prePaintWindow
(this=this@entry=0x55865e603380, w=, data=...,
time=time@entry=16) at ./effects.cpp:410
#15 0x7f429ce952c4 in KWin::Scene::paintSimpleScreen
(this=this@entry=0x55865e06f010, orig_mask=orig_mask@entry=8, region=...) at
./scene.cpp:302
#16 0x7f4275d89112 in KWin::SceneOpenGL2::paintSimpleScreen
(this=this@entry=0x55865e06f010, mask=mask@entry=8, region=...) at
./plugins/scenes/opengl/scene_opengl.cpp:1052
#17 0x7f429ce96157 in KWin::Scene::finalPaintScreen
(this=this@entry=0x55865e06f010, mask=mask@entry=8, region=..., data=...) at
./scene.cpp:201
#18 0x7f429cea44c5 in KWin::EffectsHandlerImpl::paintScreen
(this=, mask=8, region=..., data=...) at ./effects.cpp:379
#19 0x7f4299effe81 in 

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

--- Comment #1 from luca  ---
Created attachment 110941
  --> https://bugs.kde.org/attachment.cgi?id=110941=edit
kcrash after install kwin-common-dbgsym

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390953] kwin crashes moving shaded windows

[luca]

https://bugs.kde.org/show_bug.cgi?id=390953

luca  changed:

   What|Removed |Added

Summary|kwin crashed moving shaded  |kwin crashes moving shaded
   |windows |windows

-- 
You are receiving this mail because:
You are watching all bug changes.