[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-15 Thread Mahendra Tallur
https://bugs.kde.org/show_bug.cgi?id=400980

--- Comment #4 from Mahendra Tallur  ---
Thank you so much for the quick fix, Vlad !

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=400980

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/80da18a143f1b57751e77f957
   ||4212ff60ff14950
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.15.0

--- Comment #3 from Vlad Zagorodniy  ---
Git commit 80da18a143f1b57751e77f9574212ff60ff14950 by Vlad Zagorodniy.
Committed on 15/11/2018 at 20:08.
Pushed by vladz into branch 'master'.

[decorations] Emit DecorationSettings::fontChanged signal

Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.

Currently, there are two places where we can emit that signal:
- in KDecoration library itself;
- and in KWin.

Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.

Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.
FIXED-IN: 5.15.0

Test Plan:
* Increased the size of the window title font, titlebars got bigger;
* Decreased the font size, titlebars got smaller.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16908

M  +7-0decorations/settings.cpp
M  +4-0decorations/settings.h

https://commits.kde.org/kwin/80da18a143f1b57751e77f9574212ff60ff14950

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-13 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=400980

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|kwin-bugs-n...@kde.org  |vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=400980

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-12 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=400980

--- Comment #2 from Vlad Zagorodniy  ---
Nah, it looks like that's indeed a bug in KDecoration. No one emits
fontChanged.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-12 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=400980

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |kwin-bugs-n...@kde.org
  Component|window decoration   |decorations
Product|Breeze  |kwin

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400980] Decorations get huge after reboot with specific font size

2018-11-12 Thread Mahendra Tallur
https://bugs.kde.org/show_bug.cgi?id=400980

--- Comment #1 from Mahendra Tallur  ---
Oops, I mixed sizes up. The SUMMARY should obviously be : 

"When using the Roboto 11 font as window title font, and rebooting, decorations
become and remain huge (as long as one doesn't change the font size then
reboot)"

-- 
You are receiving this mail because:
You are watching all bug changes.