[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=404837

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/67b2746ecdfd4c343db9d3fca
   ||088ae86d80a57f0
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Vlad Zagorodniy  ---
Git commit 67b2746ecdfd4c343db9d3fca088ae86d80a57f0 by Vlad Zagorodniy.
Committed on 15/05/2019 at 08:07.
Pushed by vladz into branch 'master'.

Compute correct boundaries in checkWorkspacePosition

Summary:
When a client sets a strut, checkWorkspacePosition will be called to
bump clients that touch corresponding screen edge.

In order to do that, checkWorkspacePosition needs to calculate client
boundaries before and after the restricted move area was changed. As it
turns out, if the client reserves space "between" screens, calculated
boundaries can be incorrect, which may lead to some funky results, e.g.
shrunken clients.

For example, let's say that there is a dual-monitor setup. If a client
reserves some amount of space at the right border of the left screen,
then clients on the right monitor will have rightMax which is equal to
the x coordinate of screenArea.

To fix that, this change ensures that only restricted areas belonging
to the same screen as the client are taken into account when computing
the boundaries.
Related: bug 406573

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D20987

M  +4-9geometry.cpp

https://commits.kde.org/kwin/67b2746ecdfd4c343db9d3fca088ae86d80a57f0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-08 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=404837

Vlad Zagorodniy  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D20987
  Flags||ReviewRequest+
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #10 from Vlad Zagorodniy  ---
Okay, this is a well known issue with struts. The fix is already under review.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=404837

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=404837

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|kwin-bugs-n...@kde.org  |vladz...@gmail.com

--- Comment #9 from Vlad Zagorodniy  ---
Will look into it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #8 from s...@hjkos.com ---
I made panel on lower screen "auto-hide" (it still stays always visible for
some reason) and problem seem to be gone. Panel on upper screen doesn't change
anything (but it does auto-hide properly).

I assume problem lies in "something lies beyond panel" case?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #7 from Vlad Zagorodniy  ---
Can you reproduce this bug with the panel being hidden?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #6 from Vlad Zagorodniy  ---
Is the panel always visible?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #5 from s...@hjkos.com ---
I've added support information dump as an image showcasing how "Move to
previous screen" is bugged. I've disabled krohnkite for better clarity. Note
that window position after moving varies depending on it's initial position,
feels like some offsets are horribly wrong. Sometimes window can go partially
above upper screen but I couldn't reproduce it more than one and I didn't
capture it. I've resized screenshots somewhat to save space, let me know if
it's a problem.

Also as I mentioned before, this is one of several problems related to such
layout. For instance yakuake is set to appear on same screen the cursor is, but
it doesn't show up when cursor is on upper screen at all, setting specific
screen in yakuake makes it always appear on lower screen, no matter which
screen is selected.

Krohnkite also sometimes crashes kwin_x11 when external display is
disconnected, probably related to wrong screen data, too.

All problems are gone if I use side-by-side monitor setup. During this time I
changed external monitor for a bigger one but problems persist.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #4 from s...@hjkos.com ---
Created attachment 119882
  --> https://bugs.kde.org/attachment.cgi?id=119882=edit
Behavior of "Move to previous screen" in over/under layout

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #3 from s...@hjkos.com ---
Created attachment 119881
  --> https://bugs.kde.org/attachment.cgi?id=119881=edit
Support Information

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-05-07 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=404837

--- Comment #2 from Vlad Zagorodniy  ---
Can you post output of `qdbus org.kde.KWin /KWin supportInformation` as well
screenshots if possible?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 404837] Having monitors arranged vertically breaks "Move to next/prev screen" shortcut as well as yakuake

2019-04-25 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=404837

Christoph Feck  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |kwin-bugs-n...@kde.org
  Component|general |general
Version|unspecified |5.14.5
Product|kde |kwin

-- 
You are receiving this mail because:
You are watching all bug changes.