[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-04-08 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405379

Vlad Zagorodniy  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kwi
   ||n/f10760d8a9bee194dd2d02008
   ||c6bb02f49ff2da3
 Resolution|--- |FIXED

--- Comment #7 from Vlad Zagorodniy  ---
Git commit f10760d8a9bee194dd2d02008c6bb02f49ff2da3 by Vlad Zagorodniy.
Committed on 09/04/2019 at 05:47.
Pushed by vladz into branch 'master'.

[wayland] Finish active move-resize op when client is destroyed or unmapped

Summary:
It might happen that the moving client gets closed or crashes. In that
case, we have to manually reset Workspace::movingClient, otherwise KWin
will most likely crash later on.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D19708

M  +170  -0autotests/integration/move_resize_window_test.cpp
M  +6-0shell_client.cpp

https://commits.kde.org/kwin/f10760d8a9bee194dd2d02008c6bb02f49ff2da3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-04-06 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=405379

David Edmundson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||k...@davidedmundson.co.uk

--- Comment #6 from David Edmundson  ---
Client calls

if (isMoveResize())
leaveMoveResize();

in Client::release


ShellClient does not have an equivalent

(will fix unless vlad beats me to it)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-04-06 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405379

Patrick Silva  changed:

   What|Removed |Added

Version|5.15.2  |5.15.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=405379

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405379

Vlad Zagorodniy  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D19708
  Flags||ReviewRequest+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405379

--- Comment #5 from Vlad Zagorodniy  ---
That makes sense. Thanks. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405379

--- Comment #4 from Patrick Silva  ---
I'm talking about installing a local pkg.tar.xz package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405379

--- Comment #3 from Patrick Silva  ---
in fact I was dragging the window of pamac that shows the progress of a package
installation. It auto-closes when the installation is complete.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405379

--- Comment #2 from Vlad Zagorodniy  ---
s/AbstractClient::isWaitingForMoveResizeSync()/ShellClient::isWaitingForMoveResizeSync()/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405379] Session crashed while I dragged pamac

2019-03-12 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405379

Vlad Zagorodniy  changed:

   What|Removed |Added

  Flags||Wayland+, X11-
Summary|Wayland session crashed |Session crashed while I
   |while I dragged a CSD gtk   |dragged pamac
   |window  |

--- Comment #1 from Vlad Zagorodniy  ---
Argh, backtraces with lambdas is not fun. :(

This one is a bit interesting...

#0  0xd556d12dcc06 in ?? ()
#1  0x7fe978d0bd6b in KWin::AbstractClient::handleMoveResize
(this=this@entry=0x55a9bfbb64c0, 
x=1475, y=947, x_root=614, y_root=464) at
/usr/src/debug/kwin-5.15.2/geometry.cpp:2918

it basically invokes AbstractClient::isWaitingForMoveResizeSync(), but ends up
somewhere nowhere...

Did you close pamac by any chance while moving it?

-- 
You are receiving this mail because:
You are watching all bug changes.