[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #11 from Vlad Zagorodniy  ---
No, it works "as intended."

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-15 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #10 from Patrick Silva  ---
Hummm, the effect is triggered when you minimize a window to systray by
clicking its icon in systray but it is not when the same window is minimized by
clicking the button of the window decoration... This is an inconsistent
behavior.
Should I open a report about this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #9 from Vlad Zagorodniy  ---
(In reply to Patrick Silva from comment #8)
> Why the effect is not triggered when a window (of qBittorrent, for example)
> is minimized to systray via click on minimize button of its window
> decoration?

Because it actually gets minimized (i.e. it's in the Iconic state). As far as I
know, there isn't such a thing as "minimize to systray".

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-15 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #8 from Patrick Silva  ---
(In reply to Vlad Zagorodniy from comment #6)
> (In reply to Patrick Silva from comment #4)
> > On X11 the effect is also triggered when I minimize an app by clicking its
> > icon in systray.
> 
> As expected.

Why the effect is not triggered when a window (of qBittorrent, for example) is
minimized to systray via click on minimize button of its window decoration?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405971

Vlad Zagorodniy  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||n/0a8c436f7f055ff27cda99d75
   ||7cbd135cc3a6494

--- Comment #7 from Vlad Zagorodniy  ---
Git commit 0a8c436f7f055ff27cda99d757cbd135cc3a6494 by Vlad Zagorodniy.
Committed on 15/04/2019 at 08:20.
Pushed by vladz into branch 'Plasma/5.15'.

[effects/fallapart] Don't animate popups

Summary: BUG: 405971

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D20568

M  +6-0effects/fallapart/fallapart.cpp

https://commits.kde.org/kwin/0a8c436f7f055ff27cda99d757cbd135cc3a6494

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #6 from Vlad Zagorodniy  ---
(In reply to Patrick Silva from comment #4)
> On X11 the effect is also triggered when I minimize an app by clicking its
> icon in systray.

As expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-14 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=405971

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #5 from David Edmundson  ---
>On Wayland we don't have window types yet

It's not something anyone has requested on xdgshell. If we do want this, one of
us needs to actually request it on wayland-devel.

>I think isPopupWindow() could be used to filter out popups though not 
>dialogs... 

Seems sensible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-04-14 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #4 from Patrick Silva  ---
On X11 the effect is also triggered when I minimize an app by clicking its icon
in systray.
For example, install SMPlayer and open it, click "Options" menu, check "Show
icon in system tray". Now minimize SMPlayer by clicking its systray icon: "Fall
apart" effect was triggered.

Operating System: Arch Linux 
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.57.0
Qt Version: 5.12.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-03-29 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #3 from Patrick Silva  ---
Created attachment 119148
  --> https://bugs.kde.org/attachment.cgi?id=119148&action=edit
screen recording on X11

The effect is triggered by some dropdows on X11 too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-03-28 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #2 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #1)
> On Wayland we don't have window types yet, so it's tricky to get this done.

I think isPopupWindow() could be used to filter out popups though not
dialogs... :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-03-28 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=405971

Martin Flöser  changed:

   What|Removed |Added

  Flags||Wayland+, X11-

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405971] [Wayland] "Fall apart" effect only should be triggered when a window is closed

2019-03-28 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=405971

--- Comment #1 from Martin Flöser  ---
On Wayland we don't have window types yet, so it's tricky to get this done.

-- 
You are receiving this mail because:
You are watching all bug changes.