[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Nate Graham changed: What|Removed |Added Version Fixed In|5.17.0 |5.16.3 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Vlad Zagorodniy changed: What|Removed |Added Latest Commit|https://commits.kde.org/kwi |https://commits.kde.org/kwi |n/2cff5cb70a9e680f7c14fbd60 |n/499eccb1c8d75f596bc736cef |b00e31143373399 |5ce53aa0eb16e16 --- Comment #12 from Vlad Zagorodniy --- Git commit 499eccb1c8d75f596bc736cef5ce53aa0eb16e16 by Vlad Zagorodniy. Committed on 30/06/2019 at 12:46. Pushed by vladz into branch 'Plasma/5.16'. [tabbox] Properly determine depressed modifiers on X11 Summary: A keysym can be assigned to several keycodes, so more proper way to determine whether given modifier is depressed is to iterate over all returned keycodes and see if any is pressed. If we check only the first keycode, then alternative mappings may not work, e.g. alt key mapped to win, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21302 M +23 -29 tabbox/tabbox.cpp https://commits.kde.org/kwin/499eccb1c8d75f596bc736cef5ce53aa0eb16e16 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #11 from Vlad Zagorodniy --- Heh, yeah, that's right. I forgot to backport the patch to 5.16 branch. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #10 from Vlad Zagorodniy --- Can you post your .config/kxkbrc? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 zuxio0iezici7...@sent.as changed: What|Removed |Added CC||zuxio0iezici7...@sent.as --- Comment #9 from zuxio0iezici7...@sent.as --- This is not fixed in my experience. I'm running with Plasma/KWin 5.16.2, Frameworks 5.59.0 and Qt 5.12.4 and I'm still observing this behaviour. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #8 from ariasuni --- Thanks a lot!! -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Nate Graham changed: What|Removed |Added Version Fixed In||5.17.0 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Vlad Zagorodniy changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kwi ||n/2cff5cb70a9e680f7c14fbd60 ||b00e31143373399 Status|CONFIRMED |RESOLVED --- Comment #7 from Vlad Zagorodniy --- Git commit 2cff5cb70a9e680f7c14fbd60b00e31143373399 by Vlad Zagorodniy. Committed on 21/05/2019 at 12:43. Pushed by vladz into branch 'master'. [tabbox] Properly determine depressed modifiers on X11 Summary: A keysym can be assigned to several keycodes, so more proper way to determine whether given modifier is depressed is to iterate over all returned keycodes and see if any is pressed. If we check only the first keycode, then alternative mappings may not work, e.g. alt key mapped to win, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21302 M +23 -29 tabbox/tabbox.cpp https://commits.kde.org/kwin/2cff5cb70a9e680f7c14fbd60b00e31143373399 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #6 from Vlad Zagorodniy --- No, not really. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #5 from ariasuni --- You’re right, it seems related to bug 404115. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Vlad Zagorodniy changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Vlad Zagorodniy changed: What|Removed |Added URL||https://phabricator.kde.org ||/D21302 Flags||ReviewRequest+ -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #4 from Vlad Zagorodniy --- Aha! areKeySymXsDepressed makes some false assumptions about xcb_key_symbols_get_keycode. A keysym can be mapped to several keycodes, so we need to iterate over returned values and check if any modifier is depressed, though I would prefer to share areModKeysDepressedWayland on both Wayland session and X11 session. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Vlad Zagorodniy changed: What|Removed |Added Flags||Wayland-, X11+ -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #3 from Vlad Zagorodniy --- I wonder why we need areKeySymXsDepressed. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 --- Comment #2 from Vlad Zagorodniy --- Given that kwin switches one window forward, it seems like the shortcut works correctly. Most likely kwin thinks that modifiers are not depressed. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 407720] Task switcher doesn’t show if win key is mapped to alt
https://bugs.kde.org/show_bug.cgi?id=407720 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #1 from Patrick Silva --- it seems related to bug 404115 -- You are receiving this mail because: You are watching all bug changes.
