[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-28 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=413403

--- Comment #1 from David Redondo  ---
I bisected 1db84a2ba71657a26d2a7971eb0c35e2716742c3  to be the commit which
introduced the flickering.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-28 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=413403

--- Comment #2 from David Redondo  ---
Created attachment 123540
  --> https://bugs.kde.org/attachment.cgi?id=123540&action=edit
Video of flickering

I see a black screen but the camera apparently was to slow/adjusted to less
light so you see afterglow or brown/grey

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-28 Thread Roman Gilg
https://bugs.kde.org/show_bug.cgi?id=413403

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #3 from Roman Gilg  ---
(In reply to David Redondo from comment #1)
> I bisected 1db84a2ba71657a26d2a7971eb0c35e2716742c3  to be the commit which
> introduced the flickering.

Could be that the flickering is because of different compositing teardown and
startup what is done for several KWin configuration changes. Would need to be
inspected more thoroughly.

The crash is likely fixed with https://phabricator.kde.org/D24954

Would be good if you can test this patch, so it can land in 5.17.2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-29 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=413403

--- Comment #4 from Vlad Zahorodnii  ---
> while the flickering also happens on X11.
File another bug report for that please.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-29 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=413403

--- Comment #5 from David Redondo  ---
We could use this bug for the flickering. I think there is also another bug for
that dmabus crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-29 Thread Roman Gilg
https://bugs.kde.org/show_bug.cgi?id=413403

--- Comment #6 from Roman Gilg  ---
Git commit 7459aabcac2471862a35a7c045de7176b5435f1c by Roman Gilg.
Committed on 29/10/2019 at 11:10.
Pushed by romangilg into branch 'Plasma/5.17'.

Dmabuf recovery on EGL reset

Summary:
The EGL platform might go away at any time through reconfiguration or because
of a graphic error. KWin then resets the graphics. The dmabuf implementation
must respect that and recover from a graphics reset by recreating all EGL
images for existing buffer.

This assumes that we won't change our graphics API mid-session and that
supported plane and modifier configuration stays constant.

In practise we remember all current dmabufs in a single map and only remove
them if the client did destroy the resource.
Related: bug 411980
FIXED-IN: 5.17.2

Test Plan: Applied screenedge configuration without crash.

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: fvogt, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24954

M  +1-0CMakeLists.txt
A  +88   -0linux_dmabuf.cpp [License: GPL (v2)]
C  +12   -49   linux_dmabuf.h [from:
platformsupport/scenes/opengl/linux_dmabuf.h - 053% similarity]
M  +1-1platformsupport/scenes/opengl/CMakeLists.txt
M  +4-4platformsupport/scenes/opengl/abstract_egl_backend.cpp
R  +52   -63   platformsupport/scenes/opengl/egl_dmabuf.cpp [from:
platformsupport/scenes/opengl/linux_dmabuf.cpp - 084% similarity]
R  +23   -30   platformsupport/scenes/opengl/egl_dmabuf.h [from:
platformsupport/scenes/opengl/linux_dmabuf.h - 068% similarity]
M  +10   -0wayland_server.cpp
M  +15   -0wayland_server.h

https://commits.kde.org/kwin/7459aabcac2471862a35a7c045de7176b5435f1c

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 413403] Closing of Rules Dialog causes crash/flickering

2019-10-29 Thread Roman Gilg
https://bugs.kde.org/show_bug.cgi?id=413403

--- Comment #7 from Roman Gilg  ---
(In reply to David Redondo from comment #5)
> We could use this bug for the flickering. I think there is also another bug
> for that dmabus crash.

Yea, let's do it this way. Can you rename the bug?

-- 
You are receiving this mail because:
You are watching all bug changes.