[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks|421892 | Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421892 [Bug 421892] [kcm/kwinrules X11] KWinRules KCM: Redesign Fallout: Position rule caps to 4098 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks||421892 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421892 [Bug 421892] [kcm/kwinrules X11] KWinRules KCM: Redesign Fallout: Position rule caps to 4098 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Ismael Asensio changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kwi ||n/db7fb26eedcac7effd908e345 ||79cf2fa422ac22b Status|ASSIGNED|RESOLVED Version Fixed In||5.19.0 --- Comment #5 from Ismael Asensio --- Git commit db7fb26eedcac7effd908e34579cf2fa422ac22b by Ismael Asensio. Committed on 15/05/2020 at 17:45. Pushed by iasensio into branch 'Plasma/5.19'. [kcm/kwinrules] Fix size properties not being stored Summary: Use `QSize`/`QPoint` to handle and store coordinate values (size and position) Previously, the rules model stored the "coordinate" type properties as a `QString` with format `x, y`. This fails when setting the properties to the config schema, as it requires a proper `QPoint` or `QSize` value, specially the latter which can't be convert from such a string. FIXED-IN: 5.19.0 Test Plan: - Add a new rule and set its position and size properties - Hitting apply stores the right values in `~\.config\kwinrulesrc` - Close the kcm and reopen, the values are loaded - Property detection still works for size and position Please note that there is a pre-existing bug of some position/sizes not being applied to the windows in some cases, when using `Apply Initially`. Better try using the `Force` policy. Reviewers: ngraham, #kwin, #plasma, zzag Reviewed By: #kwin, #plasma, zzag Subscribers: zzag, ltoscano, yurchor, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D29764 M +4-3kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml M +7-6kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml M +4-5kcmkwin/kwinrules/ruleitem.cpp M +2-1kcmkwin/kwinrules/ruleitem.h M +6-8kcmkwin/kwinrules/rulesmodel.cpp https://commits.kde.org/kwin/db7fb26eedcac7effd908e34579cf2fa422ac22b -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks|421540 | Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421540 [Bug 421540] [kcm/kwinrules X11] KWinRules KCM Redesign: Fallout: Slow loading -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks|421542 | Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421542 [Bug 421542] [kcm/kwinrules X11] KWinRules KCM Redesign: Fallout: Whole Window Class, Window Role -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks||421542 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421542 [Bug 421542] [kcm/kwinrules X11] KWinRules KCM Redesign: Fallout: Whole Window Class, Window Role -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added Blocks||421540 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=421540 [Bug 421540] [kcm/kwinrules X11] KWinRules KCM Redesign: Fallout: Slow loading -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 --- Comment #4 from Duncan <1i5t5.dun...@cox.net> --- (In reply to Ismael Asensio from comment #3) > Proposed patch: https://phabricator.kde.org/D29764 Confirming, that patch works for me. =:^) Tried loading an existing rule and the size parameters loaded. Changing something and saving, they saved, and reloading, they loaded again. Additionally, setup a new rule and it saved and worked. So looks like that fixes it. =:^) (Testing this I've become aware of 2-3 other bugs and/or "unwanted behavior changes" that might otherwise be considered "new features", but I'll file those separately as they're not /this/ bug (and FWIW don't seem quite as breaking).) -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Nate Graham changed: What|Removed |Added Status|CONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 --- Comment #3 from Ismael Asensio --- Proposed patch: https://phabricator.kde.org/D29764 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Ismael Asensio changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 Assignee|kwin-bugs-n...@kde.org |isma...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 --- Comment #2 from Ismael Asensio --- I can reproduce it. Two changes went on since the last release (the QML frontend, and the KConfigXT backend), and I think this is something in the interface in-between. I'm on it. Thanks for the report! -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 421055] [kcm/kwinrules X11] Window sizing rules broken since a04b40dad: KWinRules KCM Redesign
https://bugs.kde.org/show_bug.cgi?id=421055 Nate Graham changed: What|Removed |Added CC||isma...@gmail.com, ||n...@kde.org --- Comment #1 from Nate Graham --- Ismael, can you take a look? -- You are receiving this mail because: You are watching all bug changes.
