[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=427688

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #21 from David Edmundson  ---
ksmserver quits
ksmserver is tied to X
and our session is tied to the lifespan of ksmserver


This is valid and needs some refactoring of our boot process (which is an
overall topic I've been working on generally.

I've been trying to make ksmserver completely optional on wayland and have a
different way of monitoring for exit. It'd be a relatively small patch to
start_plasma_  to change what processes we watch for exit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

Vlad Zahorodnii  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #20 from Vlad Zahorodnii  ---
I've attached a debugger to kwin and it doesn't look like it crashes

(lldb) c
Process 2573 resuming
Process 2573 stopped and restarted: thread 1 received signal: SIGCHLD
Process 2573 stopped and restarted: thread 1 received signal: SIGCHLD
Process 2573 stopped and restarted: thread 1 received signal: SIGCHLD
Process 2573 exited with status = 0 (0x) 

The session process definitely quits. Can you file a bug report against
plasmashell?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #19 from smit  ---
(In reply to Vlad Zahorodnii from comment #17)
> > Also I have found that this crash only happens with gdm and 
> > startplasma-wayland. 
> Did you start plasma from gdm? does plasma session crash if you use sddm?

I tested sddm also. 

starting plasma with gdm, sddm and startplasma-wayland command and killing
Xwayland crashes/terminates the whole session

but when I used 

XDG_SESSION_TYPE=wayland dbus-run-session /bin/kwin_wayland --drm --xwayland
--libinput startplasma-wayland

and killed Xwayland, it does not crash. xwayland restarts as expect and
everything works fine

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #18 from Vlad Zahorodnii  ---
> No. after 4 kills. Xwayland does not restarts
kwin won't restart Xwayland if it has crashed more than 3 times over the past
10 minutes

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #17 from Vlad Zahorodnii  ---
> Also I have found that this crash only happens with gdm and 
> startplasma-wayland. 
Did you start plasma from gdm? does plasma session crash if you use sddm?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #16 from smit  ---
(In reply to Vlad Zahorodnii from comment #15)
> but plasma dies, right?

No. after 4 kills. Xwayland does not restarts. but everything else is usable.
whole session does not crashes/dies

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #15 from Vlad Zahorodnii  ---
but plasma dies, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #14 from smit  ---
(In reply to Vlad Zahorodnii from comment #13)
> can you run the same command, but only with startplasma-wayland instead of
> plasmashell

It does not crash.  Xwayland restarts as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #13 from Vlad Zahorodnii  ---
(In reply to smit from comment #10)
> hi,
> I am still able to crash kde by killing Xwayland with startplasma-wayland
> and gdm. I don't have second machine so I can't do ssh stuff so I used
> script command on tty. I have attached the output of that script command
> above
> 
> Also I have found that this crash only happens with gdm and
> startplasma-wayland. 
> 
> I wasn't able to crash kde when I started kwin using following command:-
> 
> XDG_SESSION_TYPE=wayland XDG_CURRENT_DESKTOP=kde QT_PLUGIN_PATH=`pwd`
> dbus-run-session /bin/kwin_wayland --drm --xwayland --libinput plasmashell

can you run the same command, but only with startplasma-wayland instead of
plasmashell

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-22 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #12 from smit  ---
(In reply to Vlad Zahorodnii from comment #11)
> Did you kill the startplasma-wayland process?

No. I killed only Xwayland process

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-21 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #11 from Vlad Zahorodnii  ---
Did you kill the startplasma-wayland process?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-21 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

smit  changed:

   What|Removed |Added

Version|unspecified |5.20.1
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #10 from smit  ---
hi,
I am still able to crash kde by killing Xwayland with startplasma-wayland and
gdm. I don't have second machine so I can't do ssh stuff so I used script
command on tty. I have attached the output of that script command above

Also I have found that this crash only happens with gdm and
startplasma-wayland. 

I wasn't able to crash kde when I started kwin using following command:-

XDG_SESSION_TYPE=wayland XDG_CURRENT_DESKTOP=kde QT_PLUGIN_PATH=`pwd`
dbus-run-session /bin/kwin_wayland --drm --xwayland --libinput plasmashell


SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 
KDE Plasma Version: 5.20.1
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1

ADDITIONAL INFORMATION

GPU: Intel UHD Graphics 620
Kernel: 5.9.1-zen2-1-zen

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-21 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #9 from smit  ---
Created attachment 132617
  --> https://bugs.kde.org/attachment.cgi?id=132617&action=edit
output of script command

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/commit/2093820aba4b |ma/kwin/commit/0109bdbba9bf
   |bb26130b2b6d788b73584a5a6eb |ef93134e4d2b8e4d4ead2dde84b
   |d   |4

--- Comment #8 from Vlad Zahorodnii  ---
Git commit 0109bdbba9bfef93134e4d2b8e4d4ead2dde84b4 by Vlad Zahorodnii.
Committed on 14/10/2020 at 16:18.
Pushed by vladz into branch 'Plasma/5.20'.

xwayland: Avoid creating a tree query on crash

If Xwayland has crashed, the Workspace will block stacking order updates
and start destroying all X11 clients.

Once stacking order updates are unblocked, the Workspace will mark the X
stacking order as dirty and create a new Xcb::Tree object.

We don't want to create that Xcb::Tree object because accessing it
after the XCB connection has been shut down will lead to a crash.
FIXED-IN: 5.20.1


(cherry picked from commit 2093820aba4bbb26130b2b6d788b73584a5a6ebd)

M  +7-0autotests/integration/xwaylandserver_crash_test.cpp
M  +7-0autotests/integration/xwaylandserver_restart_test.cpp
M  +11   -0main.h
M  +1-1workspace.cpp
M  +4-0xwl/xwayland.cpp

https://invent.kde.org/plasma/kwin/commit/0109bdbba9bfef93134e4d2b8e4d4ead2dde84b4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/2093820aba4b
   ||bb26130b2b6d788b73584a5a6eb
   ||d
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.20.1

--- Comment #7 from Vlad Zahorodnii  ---
Git commit 2093820aba4bbb26130b2b6d788b73584a5a6ebd by Vlad Zahorodnii.
Committed on 14/10/2020 at 16:17.
Pushed by vladz into branch 'master'.

xwayland: Avoid creating a tree query on crash

If Xwayland has crashed, the Workspace will block stacking order updates
and start destroying all X11 clients.

Once stacking order updates are unblocked, the Workspace will mark the X
stacking order as dirty and create a new Xcb::Tree object.

We don't want to create that Xcb::Tree object because accessing it
after the XCB connection has been shut down will lead to a crash.
FIXED-IN: 5.20.1

M  +7-0autotests/integration/xwaylandserver_crash_test.cpp
M  +7-0autotests/integration/xwaylandserver_restart_test.cpp
M  +11   -0main.h
M  +1-1workspace.cpp
M  +4-0xwl/xwayland.cpp

https://invent.kde.org/plasma/kwin/commit/2093820aba4bbb26130b2b6d788b73584a5a6ebd

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #6 from Vlad Zahorodnii  ---
(In reply to smit from comment #4)
> (In reply to Vlad Zahorodnii from comment #3)
> > Okay, I'm able to reproduce this crash.
> 
> I guess I don't need to provide any logs then, or do I ?

No, you don't

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=427688

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=427688

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/348

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #4 from smit  ---
(In reply to Vlad Zahorodnii from comment #3)
> Okay, I'm able to reproduce this crash.

I guess I don't need to provide any logs then, or do I ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

Vlad Zahorodnii  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #3 from Vlad Zahorodnii  ---
Okay, I'm able to reproduce this crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #2 from Vlad Zahorodnii  ---
Also, it would be very helpful if you could provide a backtrace of the crash.
(you would need to ssh from another computer to get it)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=427688

--- Comment #1 from Vlad Zahorodnii  ---
On my machine, kwin restarts Xwayland if it crashes. Can I have the log output
of kwin_wayland?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 427688] killing Xwayland crashes entire desktop

2020-10-14 Thread smit
https://bugs.kde.org/show_bug.cgi?id=427688

smit  changed:

   What|Removed |Added

 CC||smit1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.