[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 Vlad Zahorodnii changed: What|Removed |Added Status|ASSIGNED|RESOLVED See Also||https://bugs.kde.org/show_b ||ug.cgi?id=431643 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #31 from David Rubio --- (In reply to Vlad Zahorodnii from comment #30) > (In reply to David Rubio from comment #27) > > It fixes it for me. Also the maximize animation is way smoother for some > > weird reason. > > > > But yeah, that fixed the issue for what I could test (by spamming the > > maximize button like 30 times) > > Thanks, that's great. I'll create a generic bug report to track performance > issues in Aurorae and close this one. Thanks you very much. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #30 from Vlad Zahorodnii --- (In reply to David Rubio from comment #27) > It fixes it for me. Also the maximize animation is way smoother for some > weird reason. > > But yeah, that fixed the issue for what I could test (by spamming the > maximize button like 30 times) Thanks, that's great. I'll create a generic bug report to track performance issues in Aurorae and close this one. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #29 from David Edmundson --- Best answer is to copy plasma-framework/ dialogs/background.svg It has But ultimately we're just looking for any element matching the ID. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #28 from David Rubio --- (In reply to David Edmundson from comment #24) > Turns out the center is still visible slightly in the top. We can't just > disable it. > > It's fixable with a oneline in the theme, adding an element with the ID > hint-tile-center. I can't think of any super easy fix plasma side. Would that element have to be empty or does it need to contain something? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #27 from David Rubio --- (In reply to Vlad Zahorodnii from comment #26) > @David Rubio Can you please check whether 2d1994e0669 made things better? It fixes it for me. Also the maximize animation is way smoother for some weird reason. But yeah, that fixed the issue for what I could test (by spamming the maximize button like 30 times) -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #26 from Vlad Zahorodnii --- @David Rubio Can you please check whether 2d1994e0669 made things better? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #25 from Vlad Zahorodnii --- Git commit 2d1994e06691e79c4754d60634fb5c8b3e9f4e02 by Vlad Zahorodnii. Committed on 15/01/2021 at 13:26. Pushed by vladz into branch 'master'. aurorae: Make direct connection to maximizedChanged signal If the maximizedChanged connection is queued, several configure events will be sent. If the client acks the first configure event and later on acks the second one, the maximize animation will be cancelled due to "unexpected" geometry change. Based on the code, there is no clear reason why the connection is queued in the first place. M +1-1plugins/kdecorations/aurorae/src/aurorae.cpp https://invent.kde.org/plasma/kwin/commit/2d1994e06691e79c4754d60634fb5c8b3e9f4e02 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #24 from David Edmundson --- Turns out the center is still visible slightly in the top. We can't just disable it. It's fixable with a oneline in the theme, adding an element with the ID hint-tile-center. I can't think of any super easy fix plasma side. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #23 from David Edmundson --- This is interesting: 11:27:17.632 Plasma::FrameItemNode::updateTexture QSize(1392, 1011) "decoration-center" 1 It's rendering the middle of the frame (the part that no-one can see) at absolutely massive resolutions, with the slowest of all 3 FrameSVGItemNode paths. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 Vlad Zahorodnii changed: What|Removed |Added Flags||Wayland+, X11- -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #22 from Vlad Zahorodnii --- Created attachment 134881 --> https://bugs.kde.org/attachment.cgi?id=134881&action=edit ftrace The first 100-150ms of the maximize animation are very crucial, but it looks like kwin spends most of that time updating the contents of the aurorae decoration. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #21 from Vlad Zahorodnii --- I use the following https://store.kde.org/p/1191690/ aurorae theme. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #20 from Vlad Zahorodnii --- Created attachment 134879 --> https://bugs.kde.org/attachment.cgi?id=134879&action=edit hotspot When I maximize/restore a window, kwin spends a reasonable amount of time decoding png images. This is odd... -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #19 from Vlad Zahorodnii --- I don't see anything suspicious in your kwinrc file. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #18 from David Rubio --- Created attachment 134863 --> https://bugs.kde.org/attachment.cgi?id=134863&action=edit kwinrc (In reply to Vlad Zahorodnii from comment #17) > > setting it to the slowest animation speed notch still plays > Make sure that you don't have AnimationDurationFactor in your kwinrc file. I don't. I'm attaching my kwinrc. Anything odd in here? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #17 from Vlad Zahorodnii --- > setting it to the slowest animation speed notch still plays Make sure that you don't have AnimationDurationFactor in your kwinrc file. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #16 from David Rubio --- (In reply to Vlad Zahorodnii from comment #15) > On my machine, the maximize animation is choppy no matter where I click. The animation is definitely choppy even when double-clicking. When I click the maximize button the animation outright doesn't play at all for some cursed reason (setting it to the slowest animation speed notch still plays it instantly instead of it taking forever). I'd blame the theme but it works before 507. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #15 from Vlad Zahorodnii --- On my machine, the maximize animation is choppy no matter where I click. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #14 from David Rubio --- I find it really weird that the animation works only if I double click the titlebar, but clicking the maximize button does absolutely nothing. I tried reverting the cubic animation curve and that didn't do it either. Video: https://youtu.be/9prO3kiB6-w -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #13 from Vlad Zahorodnii --- Okay, I closed the merge request. I wonder if switching to the cubic easing curve has something to do with this "bug." (kwin drops a lot of frames because aurorae is inefficient). In Plasma <= 5.20.x, the maximize effect uses the linear easing curve, while in 5.21.x, it is going to use the cubic easing curve. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #12 from David Rubio --- (In reply to David Rubio from comment #11) > (In reply to Vlad Zahorodnii from comment #9) > > The problem is that aurorae decoration engine is inefficient. KWin gets the > > data from a texture where Aurorae composites the decoration and uploads it > > to another decoration texture atlas. Performance-wise, that's not good. By > > delaying compositing, we just made it more easier to miss the next vblank. > > Perhaps, we should increase the latency policy to "extremely high" to work > > around this bug until the performance hog is properly fixed. > > I did set it to extremely high (well, as high as it went), and the problem > is still there, just less so. It's just really annoying, but I don't think > that much people use Aurorae, thankfully? :P > > I just can't live without the theme I've used for so many years, but that's > me. Weirdly enough, double-clicking the titlebar plays the animation just fine 90% of the times, but clicking the "maximize" button barely plays it at all. Dunno what sort of difference that'd even make. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #11 from David Rubio --- (In reply to Vlad Zahorodnii from comment #9) > The problem is that aurorae decoration engine is inefficient. KWin gets the > data from a texture where Aurorae composites the decoration and uploads it > to another decoration texture atlas. Performance-wise, that's not good. By > delaying compositing, we just made it more easier to miss the next vblank. > Perhaps, we should increase the latency policy to "extremely high" to work > around this bug until the performance hog is properly fixed. I did set it to extremely high (well, as high as it went), and the problem is still there, just less so. It's just really annoying, but I don't think that much people use Aurorae, thankfully? :P I just can't live without the theme I've used for so many years, but that's me. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #10 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/589 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 Vlad Zahorodnii changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #9 from Vlad Zahorodnii --- The problem is that aurorae decoration engine is inefficient. KWin gets the data from a texture where Aurorae composites the decoration and uploads it to another decoration texture atlas. Performance-wise, that's not good. By delaying compositing, we just made it more easier to miss the next vblank. Perhaps, we should increase the latency policy to "extremely high" to work around this bug until the performance hog is properly fixed. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #8 from David Rubio --- Reverting: kwayland-server: f67daa0711584058a8fefda76e898fe58d53ace7 kwin: 26b249061ee49dacc29320f93984de3d35012e1f to those commit hashes makes this issue dissapear. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #7 from David Rubio --- (In reply to David Rubio from comment #5) > (In reply to Vlad Zahorodnii from comment #4) > > Cannot reproduce. > > > > I wonder if kwin has a huge frame drop. Can you reduce the animation speed > > in the system settings? > > I tried the minimum speed and the minimize animation still only played > around 1/4th of the times I tried. > I put the animation at the slowest notch. Besides systemsettings5 crashing inmediatly after that (report coming...) the animation definitely wasn't playing. Sometimes it would, and it would be unsufferably slow (as you would expect from it being set at the slowest speed), but when it didn't play Maximize was instant. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #6 from David Rubio --- Also for CSD windows it also plays 100% of the times. It's only when the window is decorated by Aurorae. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #5 from David Rubio --- (In reply to Vlad Zahorodnii from comment #4) > Cannot reproduce. > > I wonder if kwin has a huge frame drop. Can you reduce the animation speed > in the system settings? I tried the minimum speed and the minimize animation still only played around 1/4th of the times I tried. There's a lot of frame drops on KWin Wayland master, but this doesn't seem to be a frame drop here, as even with the minimum animation speed the minimize animation is instant. Thing is, like one in 10 times it would *actually* play, so I know it's *active*. This does NOT happen with Breeze, so for me it looks to be Aurorae-specific, but I could repro it with basically any aurorae theme, all the time. I tried on 5.20.5 and the maximize animation plays fine 100% of the times. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #4 from Vlad Zahorodnii --- Cannot reproduce. I wonder if kwin has a huge frame drop. Can you reduce the animation speed in the system settings? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 David Rubio changed: What|Removed |Added CC||david.alejandro.rubio@gmail ||.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #3 from David Rubio --- If you try to replicate this issue, this *might* work sometimes, then out of nowhere the effect will stop playing completely, then start again. Try using your computer for 10 minutes or so with an Aurorae theme on Wayland, and you ought to hit it. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #2 from David Rubio --- Video of the issue: https://www.youtube.com/watch?v=HS4vYuRlL1I -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 431415] Maximize animation does not work on Wayland
https://bugs.kde.org/show_bug.cgi?id=431415 --- Comment #1 from David Rubio --- Created attachment 134725 --> https://bugs.kde.org/attachment.cgi?id=134725&action=edit qdbus org.kde.KWin /KWin supportInformation -- You are receiving this mail because: You are watching all bug changes.
