[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED Version Fixed In|5.23| Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Nate Graham changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REPORTED Ever confirmed|1 |0 --- Comment #14 from Nate Graham --- Yeah you're right, there are still unresolved cases. Dragging a file form Dolphin (Wayland) to Discord (XWayland), for example. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 --- Comment #13 from David Edmundson --- I said it fixes what was mentioned in the comment above, not the whole bug. I think there are still some issues left. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Nate Graham changed: What|Removed |Added Status|REOPENED|RESOLVED Version Fixed In||5.23 Resolution|--- |FIXED --- Comment #12 from Nate Graham --- Then it needs to be marked as RESOLVED :) -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 --- Comment #11 from David Edmundson --- The above issue should now be fixed. This is currently only in master/5.23. I will backport sometime -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Nate Graham changed: What|Removed |Added Priority|VHI |HI -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 --- Comment #10 from David Edmundson --- Second bug is, we stop XVisit when wayland says the drag ends, which in theory is after the drop event gets sent to the client. #0 KWin::Xwl::Xvisit::doFinish() (this=0x5625f6e0) at /home/david/projects/kde5/src/kde/workspace/kwin/src/xwl/drag_wl.cpp:444 #1 0x5559197e in KWin::Xwl::Xvisit::leave() (this=0x5625f6e0) at /home/david/projects/kde5/src/kde/workspace/kwin/src/xwl/drag_wl.cpp:265 #2 0x55591b9e in KWin::Xwl::WlToXDrag::end() (this=0x560d53a0) at /home/david/projects/kde5/src/kde/workspace/kwin/src/xwl/drag_wl.cpp:91 #3 0x5558e53a in KWin::Xwl::Dnd::endDrag() (this=0x55f28760) at /home/david/projects/kde5/src/kde/workspace/kwin/src/xwl/dnd.cpp:203 #4 0x5558fd01 in QtPrivate::FunctorCall, QtPrivate::List<>, void, void (KWin::Xwl::Dnd::*)()>::call(void (KWin::Xwl::Dnd::*)(), KWin::Xwl::Dnd*, void**) (f=(void (KWin::Xwl::Dnd::*)(KWin::Xwl::Dnd * const)) 0x5558e4e0 , o=0x55f28760, arg=0x7fffc0c0) at /opt/qt5/include/QtCore/qobjectdefs_impl.h:152 #5 0x5558fc68 in QtPrivate::FunctionPointer::call, void>(void (KWin::Xwl::Dnd::*)(), KWin::Xwl::Dnd*, void**) (f=(void (KWin::Xwl::Dnd::*)(KWin::Xwl::Dnd * const)) 0x5558e4e0 , o=0x55f28760, arg=0x7fffc0c0) at /opt/qt5/include/QtCore/qobjectdefs_impl.h:185 #6 0x5558fb95 in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x55f251d0, r=0x55f28760, a=0x7fffc0c0, ret=0x0) at /opt/qt5/include/QtCore/qobjectdefs_impl.h:418 #7 0x743e696d in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7fffc0c0, r=0x55f28760, this=0x55f251d0) at ../../include/QtCore/../../../../../src/Qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:398 #8 doActivate(QObject*, int, void**) (sender=0x556bb810, signal_index=13, argv=0x7fffc0c0) at /home/david/projects/kde5/src/Qt5/qtbase/src/corelib/kernel/qobject.cpp:3886 #9 0x743ddd6b in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=, m=, local_signal_index=, argv=) at /home/david/projects/kde5/src/Qt5/qtbase/src/corelib/kernel/qobject.cpp:3946 #10 0x74f514d8 in KWaylandServer::SeatInterface::dragEnded() (this=0x556bb810) at src/server/KWaylandServer_autogen/EWIEGA46WW/moc_seat_interface.cpp:420 #11 0x74fbf1ae in KWaylandServer::SeatInterfacePrivate::endDrag(unsigned int) (this= 0x55709520, serial=27) #12 0x74fc21b3 in KWaylandServer::SeatInterface::notifyPointerButton(unsigned int, KWaylandServer::PointerButtonState) (this=0x556bb810, button=272, state=KWaylandServer::PointerButtonState::Released) at /home/david/projects/kde5/src/kde/workspace/kwayland-server/src/server/seat_interface.cpp:756 #13 0x77890362 in KWin::DragAndDropInputFilter::pointerEvent(QMouseEvent*, unsigned int) (this=0x55a0e460, event=0x7fffc938, nativeButton=272) at /home/david/projects/kde5/src/kde/workspace/kwin/src/input.cpp:1956 But because the drop event goes through KWayland::Client it is obviously async, but delivery of the end isnt. We either need to send both things through kwayland::client or none. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 David Edmundson changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #9 from David Edmundson --- There's a bit more left to fix, reopening -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 David Edmundson changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/commit/8a699ef1877e |ma/kwin/commit/297d88b10b53 |28927fc7227742d254deed69d9e |59796a0ee260e9484876bd42faa |9 |3 --- Comment #8 from David Edmundson --- Git commit 297d88b10b5359796a0ee260e9484876bd42faa3 by David Edmundson. Committed on 24/05/2021 at 14:08. Pushed by davidedmundson into branch 'Plasma/5.22'. [xwl] Notify wayland that our data offer is accepted kwayland-server was updated to follow the result of whether the data offer was accepted before calling drop. Our bridge was not updated. We don't have enough data to know which mimeType the XWayland client actually has accepted, as that doesn't exist at an X11 level, but it doesn't have a big actual impact. Despite which mime type gets accepted any mimetype can be retrieved in the drop event. Tested against "dropsite" from QtBase widget examples forced into xcb mode using dolphin as a source. (cherry picked from commit 8a699ef1877e28927fc7227742d254deed69d9e9) M +4-0src/xwl/drag_wl.cpp https://invent.kde.org/plasma/kwin/commit/297d88b10b5359796a0ee260e9484876bd42faa3 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 David Edmundson changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/kwin/commit/8a699ef1877e ||28927fc7227742d254deed69d9e ||9 --- Comment #7 from David Edmundson --- Git commit 8a699ef1877e28927fc7227742d254deed69d9e9 by David Edmundson. Committed on 24/05/2021 at 14:06. Pushed by davidedmundson into branch 'master'. [xwl] Notify wayland that our data offer is accepted kwayland-server was updated to follow the result of whether the data offer was accepted before calling drop. Our bridge was not updated. We don't have enough data to know which mimeType the XWayland client actually has accepted, as that doesn't exist at an X11 level, but it doesn't have a big actual impact. Despite which mime type gets accepted any mimetype can be retrieved in the drop event. Tested against "dropsite" from QtBase widget examples forced into xcb mode using dolphin as a source. M +4-0src/xwl/drag_wl.cpp https://invent.kde.org/plasma/kwin/commit/8a699ef1877e28927fc7227742d254deed69d9e9 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Alex changed: What|Removed |Added CC||alex...@protonmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Andrey changed: What|Removed |Added Attachment #138655|kwin under valgrind |kwin crash under valgrind description|| -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 --- Comment #6 from Andrey --- Created attachment 138655 --> https://bugs.kde.org/attachment.cgi?id=138655=edit kwin under valgrind Could reproduce the crash with following command for Valgrind: dbus-run-session valgrind --log-file=kwinxwayland.log kwin_wayland --exit-with-session=konsole --xwayland Then, run thunderbird and nautilus from opened konsole in nested session, then try d a .pdf file -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1020 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 --- Comment #4 from Andrey --- Created attachment 138638 --> https://bugs.kde.org/attachment.cgi?id=138638=edit kwin master crash on D onto Thunderbird attachment Dragged .pdf document from Files to XWayland Thunderbird, kwin commit 22f2e3e43c47433ac4eb185a2cd864625d5116d9 (HEAD -> master, origin/master, origin/HEAD) -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Andrey changed: What|Removed |Added CC||butir...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 --- Comment #3 from David Edmundson --- And that's because kwin never considers the drag as accepted -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk Keywords||regression --- Comment #2 from David Edmundson --- Spend some time investigating XVisit::drop never happens -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 Nate Graham changed: What|Removed |Added CC||n...@kde.org Priority|NOR |VHI Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from Nate Graham --- Can reproduce. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 437406] drag-and-drop between Wayland and Xwayland apps fails
https://bugs.kde.org/show_bug.cgi?id=437406 deadite66 changed: What|Removed |Added CC||lee295...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
