[kwin] [Bug 446978] Wayland clients receiving frame redraw notifications before any buffers have been released

2024-06-06 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=446978

Zamundaaa  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED
 CC||xaver.h...@gmail.com

--- Comment #7 from Zamundaaa  ---
Clients can't assume only two buffers are enough, and the compositor may send
frame callbacks for any arbitrary reason at any time. If the client makes
assumptions about either of these things, that's a client bug that needs to be
fixed in the client

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 446978] Wayland clients receiving frame redraw notifications before any buffers have been released

2023-04-09 Thread dave2
https://bugs.kde.org/show_bug.cgi?id=446978

dave2  changed:

   What|Removed |Added

 CC||largo...@proton.me

--- Comment #6 from dave2  ---
Sry for late response, I used a throwaway for this forum, I will respond fast
on github.
havoc prints warning messages if the compositor tells it to redraw without
releasing a buffer first. If KDE still does that it's not ideal but the user
won't notice if the window is off-screen at least. The situation hasn't changed
since the initial post AFAIK unless there has been a change in the compositor,
steps to test are in the OP.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 446978] Wayland clients receiving frame redraw notifications before any buffers have been released

2022-07-28 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=446978

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #5 from Aleix Pol  ---
It seems like havoc is working now, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 446978] Wayland clients receiving frame redraw notifications before any buffers have been released

2021-12-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=446978

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #3 from David Edmundson  ---
>Yes, but in this scenario the wayland spec says the compositor should not send 
>a frame callback

Right, we both have an invisible otherwise harmless bug and that together is
forming a visible harmful bug.
Both need fixing.

>if you want to keep this behaviour.

We don't /want/ to keep the behaviour, it was important for us to not implement
it due to a Qt bug at the time and they make up most our clients.  I think we
might be able to revisit this now though.

I'll leave this open to remind me us to do so. You should also reopen yours.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 446978] Wayland clients receiving frame redraw notifications before any buffers have been released

2021-12-15 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=446978

--- Comment #1 from Vlad Zahorodnii  ---
```
if (!term.buf[0].busy)
buf = [0];
else if (!term.buf[1].busy)
buf = [1];
else
abort();
```

there are cases when kwin can hold all two buffers and send a frame callback
after finishing a compositing cycle. you must not make assumptions when the
compositor decides to release buffers.

if the surface gets offscreen (e.g. window got minimized), kwin will not
release the attached buffer because the buffer may be needed to draw the
thumbnail of the window in the task manager

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 446978] Wayland clients receiving frame redraw notifications before any buffers have been released

2021-12-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=446978

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.