[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-15 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=449988

Vlad Zahorodnii  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #22 from Vlad Zahorodnii  ---
(In reply to hugh from comment #21)
> Still not working properly.
> 
> The window size with no border is still smaller than the original window. 
> It should be the same size, at least that was the old behavior, which I
> believe is correct.
> 
> See the old behavior vs new behavior video attachments.
> 
> Borderless window contents should expand into the old window size with
> borders.

Not sure why window size is kept constant in < 5.24, code doesn't try to do
that, it actually tries to do the opposite. Regardless of that, the original
issue (constantly shrinking window size has been fixed), please file a new bug
report as it can be confusing to track multiple issues in one bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-15 Thread hugh
https://bugs.kde.org/show_bug.cgi?id=449988

hugh  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #21 from hugh  ---
Still not working properly.

The window size with no border is still smaller than the original window.  It
should be the same size, at least that was the old behavior, which I believe is
correct.

See the old behavior vs new behavior video attachments.

Borderless window contents should expand into the old window size with borders.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-15 Thread hugh
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #20 from hugh  ---
Created attachment 146797
  --> https://bugs.kde.org/attachment.cgi?id=146797&action=edit
New behavior with 5.24

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-15 Thread hugh
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #19 from hugh  ---
Created attachment 146796
  --> https://bugs.kde.org/attachment.cgi?id=146796&action=edit
No border old behavior, prior to 5.24

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread hugh
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #18 from hugh  ---
Yeah, my bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #17 from Nate Graham  ---
That's what the "Version fixed in" field says, no? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread hugh
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #16 from hugh  ---
Thanks for the fix.

Will be in 5.24.1?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449988

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.24.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=449988

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/commit/8e05732670b0 |ma/kwin/commit/d4068754c91f
   |7b82986f1d3e5ff59ad11bc1a4e |17f01e430f60bfed8975c717097
   |c   |7

--- Comment #15 from Vlad Zahorodnii  ---
Git commit d4068754c91f17f01e430f60bfed8975c7170977 by Vlad Zahorodnii.
Committed on 14/02/2022 at 14:30.
Pushed by vladz into branch 'Plasma/5.24'.

x11: Fix shrinking window size after toggling no border multiple times

The first move() in X11Client::createDecoration() will alter the client
size, which will result in the subsequent resize() incorrectly resizing
to a smaller window size.

In order to fix that issue, this change makes X11Client adjust the
frame geometry atomically after creating or destroying window decoration.


(cherry picked from commit 8e05732670b07b82986f1d3e5ff59ad11bc1a4ec)

M  +2-4src/x11client.cpp

https://invent.kde.org/plasma/kwin/commit/d4068754c91f17f01e430f60bfed8975c7170977

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=449988

Vlad Zahorodnii  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/8e05732670b0
   ||7b82986f1d3e5ff59ad11bc1a4e
   ||c

--- Comment #14 from Vlad Zahorodnii  ---
Git commit 8e05732670b07b82986f1d3e5ff59ad11bc1a4ec by Vlad Zahorodnii.
Committed on 14/02/2022 at 14:00.
Pushed by vladz into branch 'master'.

x11: Fix shrinking window size after toggling no border multiple times

The first move() in X11Client::createDecoration() will alter the client
size, which will result in the subsequent resize() incorrectly resizing
to a smaller window size.

In order to fix that issue, this change makes X11Client adjust the
frame geometry atomically after creating or destroying window decoration.

M  +2-4src/x11client.cpp

https://invent.kde.org/plasma/kwin/commit/8e05732670b07b82986f1d3e5ff59ad11bc1a4ec

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=449988

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #13 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/2009

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-14 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=449988

Vlad Zahorodnii  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #12 from Vlad Zahorodnii  ---
It looks like we fixed wayland, but broke x11 along the way..

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-13 Thread Alireza Ahmadi
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #11 from Alireza Ahmadi  ---
Created attachment 146681
  --> https://bugs.kde.org/attachment.cgi?id=146681&action=edit
New crash information added by DrKonqi

systemsettings5 (5.18.5) using Qt 5.12.7

- What I was doing when the application crashed:
Changed application style to bb10bright and system settings crashed. and now it
crashes every time  selecting any appearaance related settings.

-- Backtrace (Reduced):
#4  QScopedPointer
>::operator-> (this=) at
../../include/QtCore/../../src/corelib/tools/qscopedpointer.h:118
[...]
#7  QObject::property (this=this@entry=0x0, name=name@entry=0x7f9549c63973
"_pixmapstyle_combobox_pressed") at kernel/qobject.cpp:3970
#8  0x7f954998d1e4 in QPixmapStyle::drawComboBox (this=0x557ed7c92de0,
option=0x557ed84e5a50, painter=0x7ffc9dc05e40, widget=0x0) at
styles/qpixmapstyle.cpp:960
#9  0x7f95199ffbb5 in KQuickStyleItem::paint(QPainter*) () from
/usr/lib64/qt5/qml/org/kde/qqc2desktopstyle/private/libqqc2desktopstyleplugin.so
#10 0x7f95199fffdc in KQuickStyleItem::updatePolish() () from
/usr/lib64/qt5/qml/org/kde/qqc2desktopstyle/private/libqqc2desktopstyleplugin.so

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-13 Thread Alireza Ahmadi
https://bugs.kde.org/show_bug.cgi?id=449988

Alireza Ahmadi  changed:

   What|Removed |Added

 CC||alireza77ahm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-13 Thread hugh
https://bugs.kde.org/show_bug.cgi?id=449988

--- Comment #10 from hugh  ---
I have more than 10 arch systems over multiple machines, both virtual and non
virtual.

This is happening on all of them.

If you cannot replicate this then it is relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 449988] [X11] No Border Window Action Toggle Continually Shrinks the Window Size

2022-02-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=449988

Nate Graham  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
  Flags||Wayland-, X11+
Summary|No Border Window Action |[X11] No Border Window
   |Toggle Continually Shrinks  |Action Toggle Continually
   |the Window Size |Shrinks the Window Size
 Status|NEEDSINFO   |REPORTED

--- Comment #9 from Nate Graham  ---
I don't use Arch, no. But that shouldn't be relevant here.

-- 
You are receiving this mail because:
You are watching all bug changes.