[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2024-03-14 Thread postix
https://bugs.kde.org/show_bug.cgi?id=459226

postix  changed:

   What|Removed |Added

Version|git master  |6.0.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-17 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459226

ratijas  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

--- Comment #8 from ratijas  ---
> Short feedback: I have tested the current state of MR2965, but unfortunately 
> it hasn't fixed the issue for me yet. Please see the screen recording.

I must have linked the wrong BUG number. That MR fixes the rearrangement after
searching and not clearing the search text. It should've been BUG 459202.
Thanks, I'll correct the commit description now.

The rearrangement I see here is likely because desktops get recreated, and the
new window heap instance re-layouts its content. It really sucks that it is not
deterministic as it should be.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-17 Thread postix
https://bugs.kde.org/show_bug.cgi?id=459226

--- Comment #7 from postix  ---
Created attachment 152149
  --> https://bugs.kde.org/attachment.cgi?id=152149=edit
Screenrecording: Without MR2965

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-17 Thread postix
https://bugs.kde.org/show_bug.cgi?id=459226

--- Comment #6 from postix  ---
Created attachment 152148
  --> https://bugs.kde.org/attachment.cgi?id=152148=edit
Screenrecording: With MR2965

Short feedback: I have tested the current state of MR2965, but unfortunately it
hasn't fixed the issue for me yet. Please see the screen recording.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=459226

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/2965

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=459226

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/2965

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-16 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459226

ratijas  changed:

   What|Removed |Added

   Assignee|kwin-bugs-n...@kde.org  |m...@ratijas.tk

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-16 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459226

--- Comment #3 from ratijas  ---
...not to mention that the `searchText` property exists only in
WindowViewEffect class, but not in OverviewEffect :-\

how did it even…

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-16 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459226

--- Comment #2 from ratijas  ---
I believe this is due to an incorrect usage of a TextField API in QML/QtQuick:

> onTextChanged: {
> effect.searchText = text;
> heap.resetSelected();
> heap.selectNextItem(WindowHeap.Direction.Down);
> }
> Binding {
> target: searchField
> property: "text"
> value: effect.searchText
> }

My gut feeling tells my this Binding should've never existed. and onTextEdited
should've been used in the first place.

There's also the Window View effect, which is like Overview but should be
merged with it. And there's a similar SearchField, but with a comment:

> // Binding loops will be avoided from the fact that setting the 
> text to the same won't emit textChanged

which supports my theory that developers simply didn't know the trick.

Also, the root cause here is this function:

>function start() {
>animationEnabled = true;
>organized = true;
>searchField.text = "";
>}

Clearly, it resets search text too late.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 459226] Window re-arranging animation played when dragging whole VD to another empty VD

2022-09-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=459226

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
   Severity|normal  |minor
 CC||m...@ratijas.tk, n...@kde.org

--- Comment #1 from Nate Graham  ---
Can confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.