[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=472340

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |wishlist
  Component|general |general
   Assignee|unassigned-b...@kde.org |kwin-bugs-n...@kde.org
Product|kde |kwin
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

Zamundaaa  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED
 CC||xaver.h...@gmail.com

--- Comment #4 from Zamundaaa  ---
KWin doesn't deal with font or icon rendering. Please redirect this feature
request to FreeType and Firefox respectively

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

Álvaro M.  changed:

   What|Removed |Added

 Resolution|UPSTREAM|---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #5 from Álvaro M.  ---
(In reply to Zamundaaa from comment #4)
> KWin doesn't deal with font or icon rendering. Please redirect this feature
> request to FreeType and Firefox respectively

Regarding fonts: I agree, will talk with freetype and fontconfig.

Regarding colors: I disagree, since this not only happens in firefox, but the
whole desktop's colors. I've uploaded the same issue in the KDE settings
window, to give you an example.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #6 from Álvaro M.  ---
Created attachment 160803
  --> https://bugs.kde.org/attachment.cgi?id=160803&action=edit
This is an option from the KDE Settings window in an LED screen, no issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #7 from Álvaro M.  ---
Created attachment 160804
  --> https://bugs.kde.org/attachment.cgi?id=160804&action=edit
This is an option from the KDE Settings window in an OLED screen, notice the
extra pixel rendering to the left side

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #8 from Álvaro M.  ---
Created attachment 160805
  --> https://bugs.kde.org/attachment.cgi?id=160805&action=edit
This is a button from the KDE Settings window in an LED screen, no issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #9 from Álvaro M.  ---
Created attachment 160806
  --> https://bugs.kde.org/attachment.cgi?id=160806&action=edit
This is a button from the KDE Settings window in an OLED screen, notice the
extra pixels to the left

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

Álvaro M.  changed:

   What|Removed |Added

   See Also||https://gitlab.freedesktop.
   ||org/freetype/freetype/-/iss
   ||ues/1182

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

Álvaro M.  changed:

   What|Removed |Added

   See Also||https://gitlab.freedesktop.
   ||org/fontconfig/fontconfig/-
   ||/issues/328

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #10 from Zamundaaa  ---
KWin still doesn't render icons... It doesn't render anything in the windows
you see.

There are some necessary changes to allow apps to handle this properly though.
Here's a list of what needs to happen for this to be potentially supported:
- the kernel needs some way of identifying displays with these special subpixel
layouts, and it needs to pass that information to userspace
- libdrm should be updated to add a value to the currently broken subpixel enum
(https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/317)
- Wayland needs to be updated to add a value to its subpixel enum
- KWin needs to be updated to pass the subpixel enum from the kernel along to
clients

That's all the things that are relevant for KWin. If you want icons to be
rendered with the subpixel layout in mind (idk if that's even a thing right
now), then you also need to get Qt, GTK, Firefox, Chromium and whatever
toolkit/application you're using to handle that. And for fonts ofc, FreeType as
well as the projects using it need to be adjusted to support the subpixel
layout.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/4303

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

Álvaro M.  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |MOVED

--- Comment #12 from Álvaro M.  ---
(In reply to Zamundaaa from comment #10)
> KWin still doesn't render icons... It doesn't render anything in the windows
> you see.
> 
> There are some necessary changes to allow apps to handle this properly
> though. Here's a list of what needs to happen for this to be potentially
> supported:
> - the kernel needs some way of identifying displays with these special
> subpixel layouts, and it needs to pass that information to userspace
> - libdrm should be updated to add a value to the currently broken subpixel
> enum (https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/317)
> - Wayland needs to be updated to add a value to its subpixel enum
> - KWin needs to be updated to pass the subpixel enum from the kernel along
> to clients
> 
> That's all the things that are relevant for KWin. If you want icons to be
> rendered with the subpixel layout in mind (idk if that's even a thing right
> now), then you also need to get Qt, GTK, Firefox, Chromium and whatever
> toolkit/application you're using to handle that. And for fonts ofc, FreeType
> as well as the projects using it need to be adjusted to support the subpixel
> layout.

Thanks for such a detailed answer! I'll close the ticket, then.(In reply to
Zamundaaa from comment #10)
> KWin still doesn't render icons... It doesn't render anything in the windows
> you see.
> 
> There are some necessary changes to allow apps to handle this properly
> though. Here's a list of what needs to happen for this to be potentially
> supported:
> - the kernel needs some way of identifying displays with these special
> subpixel layouts, and it needs to pass that information to userspace
> - libdrm should be updated to add a value to the currently broken subpixel
> enum (https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/317)
> - Wayland needs to be updated to add a value to its subpixel enum
> - KWin needs to be updated to pass the subpixel enum from the kernel along
> to clients
> 
> That's all the things that are relevant for KWin. If you want icons to be
> rendered with the subpixel layout in mind (idk if that's even a thing right
> now), then you also need to get Qt, GTK, Firefox, Chromium and whatever
> toolkit/application you're using to handle that. And for fonts ofc, FreeType
> as well as the projects using it need to be adjusted to support the subpixel
> layout.

Thank you for such a detailed answer. It's really overwhelming how many factors
are involved for rendering into a monitor!

I'll close the ticket, then. Or should I move/open it somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #13 from Nate Graham  ---
(In reply to Álvaro M. from comment #12)
> Thank you for such a detailed answer. It's really overwhelming how many
> factors are involved for rendering into a monitor!
You said it. Frankly I find it amazing that anything ever works at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-08 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #14 from Zamundaaa  ---
Git commit 2541e3fbe07e74d7bae1b614f13579e9735b58f1 by Xaver Hugl.
Committed on 08/08/2023 at 11:12.
Pushed by zamundaaa into branch 'master'.

backends/drm: don't assume we never get new subpixel types

M  +3-3src/backends/drm/drm_connector.cpp

https://invent.kde.org/plasma/kwin/-/commit/2541e3fbe07e74d7bae1b614f13579e9735b58f1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-08 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #15 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/4305

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-08 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #16 from Zamundaaa  ---
Git commit e4b2811f78691c2b727cdb61d533a29ddd802028 by Xaver Hugl.
Committed on 08/08/2023 at 12:23.
Pushed by zamundaaa into branch 'Plasma/5.27'.

backends/drm: don't assume we never get new subpixel types


(cherry picked from commit 2541e3fbe07e74d7bae1b614f13579e9735b58f1)

M  +3-3src/backends/drm/drm_connector.cpp

https://invent.kde.org/plasma/kwin/-/commit/e4b2811f78691c2b727cdb61d533a29ddd802028

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-08 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

Zamundaaa  changed:

   What|Removed |Added

 Resolution|MOVED   |---
 Ever confirmed|1   |0
 Status|RESOLVED|REPORTED

--- Comment #17 from Zamundaaa  ---
> I'll close the ticket, then. Or should I move/open it somewhere else?

I think it would be reasonable to keep this open until the part that needs
changing in KWin is done.

Could you please attach the edid of your monitor here? You should be able to
fetch it with something like
cat /sys/class/drm/card0/card0-DP-1/edid > edid.bin
(card number and connector name may need adjusting)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-08 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #18 from Álvaro M.  ---
Created attachment 160830
  --> https://bugs.kde.org/attachment.cgi?id=160830&action=edit
OLED EDID

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-09 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #19 from Zamundaaa  ---
Looks like your monitor doesn't actually say anything about the subpixel
layout, which slightly complicates the issue

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-09 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #20 from Álvaro M.  ---
Created attachment 160870
  --> https://bugs.kde.org/attachment.cgi?id=160870&action=edit
OLED EDID (from Windows, using CRU)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-09 Thread Álvaro M .
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #21 from Álvaro M.  ---
(In reply to Zamundaaa from comment #19)
> Looks like your monitor doesn't actually say anything about the subpixel
> layout, which slightly complicates the issue

I got into windows and dumped the EDID (uploaded to the ticket), which seems to
be parseable using https://people.freedesktop.org/~imirkin/edid-decode/

I think this also doesn't say it's RWBG (WOLED)?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-09 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

--- Comment #22 from Zamundaaa  ---
Indeed. I know that Windows drivers already have data bases for other missing
information in EDIDs, so presumably they "fix" the problem for subpixel layouts
with that too... I guess we have one more reason to make such a data base
ourselves as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-08-11 Thread Angus K
https://bugs.kde.org/show_bug.cgi?id=472340

Angus K  changed:

   What|Removed |Added

 CC||angu...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-09-26 Thread Zamundaaa
https://bugs.kde.org/show_bug.cgi?id=472340

Zamundaaa  changed:

   What|Removed |Added

 CC||hadrian.decurt...@gmail.com

--- Comment #23 from Zamundaaa  ---
*** Bug 474890 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2023-10-13 Thread Vojtěch Erben
https://bugs.kde.org/show_bug.cgi?id=472340

Vojtěch Erben  changed:

   What|Removed |Added

 CC||erbe...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 472340] OLED subpixel rendering support

2024-04-07 Thread Dmitrii Chermnykh
https://bugs.kde.org/show_bug.cgi?id=472340

Dmitrii Chermnykh  changed:

   What|Removed |Added

 CC||chermnykh2...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.