[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-15 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=479424

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/-/commit/af39179446 |ma/kwin/-/commit/b813b9879a
   |b0c9a969b02829e1a5816c74527 |d629fa7a91c445721efc30dcb31
   |233 |a86

--- Comment #6 from Vlad Zahorodnii  ---
Git commit b813b9879ad629fa7a91c445721efc30dcb31a86 by Vlad Zahorodnii.
Committed on 15/01/2024 at 18:57.
Pushed by vladz into branch 'Plasma/6.0'.

Break show desktop mode if a new window is added
(cherry picked from commit af39179446b0c9a969b02829e1a5816c74527233)

M  +48   -0autotests/integration/showing_desktop_test.cpp
M  +16   -4src/workspace.cpp
M  +2-0src/workspace.h

https://invent.kde.org/plasma/kwin/-/commit/b813b9879ad629fa7a91c445721efc30dcb31a86

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-15 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=479424

Vlad Zahorodnii  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/af39179446
   ||b0c9a969b02829e1a5816c74527
   ||233

--- Comment #5 from Vlad Zahorodnii  ---
Git commit af39179446b0c9a969b02829e1a5816c74527233 by Vlad Zahorodnii.
Committed on 15/01/2024 at 16:41.
Pushed by vladz into branch 'master'.

Break show desktop mode if a new window is added

M  +48   -0autotests/integration/showing_desktop_test.cpp
M  +16   -4src/workspace.cpp
M  +2-0src/workspace.h

https://invent.kde.org/plasma/kwin/-/commit/af39179446b0c9a969b02829e1a5816c74527233

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-15 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479424

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/4924

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479424

Nate Graham  changed:

   What|Removed |Added

 CC||nicc...@venerandi.com,
   ||vlad.zahorod...@kde.org,
   ||xaver.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479424

--- Comment #3 from Nate Graham  ---
Yeah, with those steps I can see that it's a bug now, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-11 Thread Oded Arbel
https://bugs.kde.org/show_bug.cgi?id=479424

--- Comment #2 from Oded Arbel  ---
Regarding shortcuts, in the shortcuts KCM there are several different settings
for this functionality:

- KWin -> Show Desktop: The default says CTRL+F12, but for me it was disabled
and when I tried to enable it I got a message that it conflicts with
plasmashell Show Desktop. When I tried to set it to a custom shortcut, it did
not seem to work.
- KWin -> Peek at desktop: The default is Meta+D and activates the Peek at
Desktop widget.
- plasmashell -> Show Desktop: The default is indeed CTRL+F12, so we have two
different shortcuts with the same default. One of them should probably be
removed. This seems to do the same thing as the Peek at Desktop widget - it
even highlights the widget.
- plasmashell -> Activate Peek at Desktop Widget (that is the real label): No
default, and when I set a custom shortcut - it does not seem to work, and it
won't activate the Peek at Desktop widget.

Also, you can right click the actual Peek at Desktop widget, select
"Configure..." and set a shortcut to activate the widget - this works as
expected. So 5 different ways to set a keyboard shortcuts,  with 2 different
default binding and some do not even work

Regarding what behavior is buggy: the Plasma 6 behavior is definitely the buggy
one - you can start several windows with Peek at Desktop active and you can see
that KWin gets really confused about which window should be active when some
windows are visible and other windows are not visible but not minimized...

Here's a repro:
1. Make sure you have a wallpaper background (image or slideshow or something
that has an "Open wallpaper image" action in the desktop RMB menu).
2. Have some windows open.
3. activate Peek at Desktop (doesn't matter if its the widget or a shortcut)
4. Right click the desktop and choose "Open wallpaper image", which will open
Gwenview and we can see it is active.
5. Click the "Edit" menu, then "Edit Tags" - the tag editor dialog pops up.
6. Click "Close" on the dialog - notice that Gwenview is no longer active, but
the task manager still shows it as active.
7. Use the task manager to select another window - all the windows come up, but
notice that the task manager still shows Gwenview as active, as well as the new
window you selected.

All that didn't happen with the Plasma 5 behavior because as soon as you had a
new window covering the desktop, all the windows were put back and you were
back to standard window management.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 479424] When activating "Peek at desktop" ("Show desktop"), opening a new window does not disable "Peek at desktop"

2024-01-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=479424

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
Product|plasmashell |kwin
 Status|REPORTED|CONFIRMED
   Assignee|plasma-b...@kde.org |kwin-bugs-n...@kde.org
 Ever confirmed|0   |1
  Component|general |effects-various
   Target Milestone|1.0 |---
   Severity|normal  |minor

--- Comment #1 from Nate Graham  ---
I can see that's it's different in 6 vs 5, but I'm not sure which one is
intended and which one is buggy! I can see pros and cons for both.

Can also reproduce when triggering the KWin effect via Meta+D, so it looks like
the change came from the effect itself, rather than the applet to trigger it in
Plasma.

-- 
You are receiving this mail because:
You are watching all bug changes.