[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #14 from Michail Vourlakos --- (In reply to scum.filter+kde from comment #13) > (In reply to Michail Vourlakos from comment #12) > > Dont worry I merged it for 0.8.6 so you could test when it is released > > Figured things out and got 0.8.75 installed - everything is working well so > far. > > Thanks much for all your help and work! nice! Thank you! -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #13 from scum.filter+...@gmail.com --- (In reply to Michail Vourlakos from comment #12) > Dont worry I merged it for 0.8.6 so you could test when it is released Figured things out and got 0.8.75 installed - everything is working well so far. Thanks much for all your help and work! -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #12 from Michail Vourlakos --- Dont worry I merged it for 0.8.6 so you could test when it is released -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #11 from scum.filter+...@gmail.com --- (In reply to scum.filter+kde from comment #10) > Unfortunately I'm not having success installing from git. I'm getting ‘class > Latte::GlobalShortcuts’ has no member named ‘hideDockTimerSlot’; did you > mean ‘hideDocksTimerSlot’? Okay, I located the lines to change in moc_globalshortcuts.cpp to address that error but am now getting error: initializer-string for array of chars is too long [-fpermissive] in .tmp/latte-dock/build/app/moc_globalshortcuts.cpp:41:1: A bit out of my depth at this point... -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #10 from scum.filter+...@gmail.com --- (In reply to Michail Vourlakos from comment #8) > Please if you can try out the git version to confirm the fix it would help > me a lot because in that way I could apply this patch also for next Latte > stable version 0.8.6 Unfortunately I'm not having success installing from git. I'm getting ‘class Latte::GlobalShortcuts’ has no member named ‘hideDockTimerSlot’; did you mean ‘hideDocksTimerSlot’? -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 Michail Vourlakos changed: What|Removed |Added Latest Commit|https://commits.kde.org/lat |https://commits.kde.org/lat |te-dock/46dd59b65a58f7f985c |te-dock/d0f1a7ffe6fb89a0da4 |905e951bf08e82270e6bf |7825d7208bf5c46dc67db --- Comment #9 from Michail Vourlakos --- Git commit d0f1a7ffe6fb89a0da47825d7208bf5c46dc67db by Michail Vourlakos. Committed on 27/01/2019 at 17:57. Pushed by mvourlakos into branch 'v0.8'. cleanup applet shortcuts on startup --when Latte crashes the global shortcuts from applets remain untouched in kglobalshortcutsrc file. That fact based on the Latte architecture that can alter applet ids during layout loading can break the global shortcuts experience by creating multiple global shortcuts records for the same applet and by disabling some shortcuts because these shortcuts are already enabled for ghost applets of the crashed layout. This patch fixes this by removing all applet global shortcuts during startup. Applet global shortcuts are already saved in the layout file based on the current plasma architecture, that fact simplifies things a lot. M +28 -0app/universalsettings.cpp M +3-0app/universalsettings.h https://commits.kde.org/latte-dock/d0f1a7ffe6fb89a0da47825d7208bf5c46dc67db -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #8 from Michail Vourlakos --- (In reply to scum.filter+kde from comment #5) > (In reply to Michail Vourlakos from comment #4) > > I think I fixed it but you should try the git version in order to confirm that it is fixed. The previous explanation of the reason is faulty. Plasma applets are already saving their shortcuts in their configuration so the shortcuts are already present in the latte layout files. The issues arises when Latte is crashed. In such case the applets global shortcuts are not loaded properly from Plasma Global Shortcuts module. Simple fix is that during Latte startup all Latte applets shortcuts are removed and when the Latte layout is loaded then the plasma applets are doing their job properly by just adding their shortcuts which is the normal behavior. That of course means that if you try this patch it would mean that by just restaring Latte all your applets shortcuts will be fixed by their own!!! :) Please if you can try out the git version to confirm the fix it would help me a lot because in that way I could apply this patch also for next Latte stable version 0.8.6 -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 Michail Vourlakos changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/lat ||te-dock/46dd59b65a58f7f985c ||905e951bf08e82270e6bf --- Comment #7 from Michail Vourlakos --- Git commit 46dd59b65a58f7f985c905e951bf08e82270e6bf by Michail Vourlakos. Committed on 27/01/2019 at 14:06. Pushed by mvourlakos into branch 'master'. cleanup applet shortcuts on startup --when Latte crashes the global shortcuts from applets remain untouched in kglobalshortcutsrc file. That fact based on the Latte architecture that can alter applet ids during layout loading can break the global shortcuts experience by creating multiple global shortcuts records for the same applet and by disabling some shortcuts because these shortcuts are already enabled for ghost applets of the crashed layout. This patch fixes this by removing all applet global shortcuts during startup. Applet global shortcuts are already saved in the layout file based on the current plasma architecture, that fact simplifies things a lot. M +21 -0app/settings/universalsettings.cpp M +2-0app/settings/universalsettings.h https://commits.kde.org/latte-dock/46dd59b65a58f7f985c905e951bf08e82270e6bf -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 Michail Vourlakos changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #6 from Michail Vourlakos --- (In reply to scum.filter+kde from comment #5) > (In reply to Michail Vourlakos from comment #4) > Can you point me to the appropriate configuration file that contains the > multiple entries I am seeing for the shortcuts? Thanks again. file: ~/.config/kglobalshortcutsrc section: lattedock -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #5 from scum.filter+...@gmail.com --- (In reply to Michail Vourlakos from comment #4) > that makes sense... > > I really thank you for this, I would had never thought it... > > I will provide the technical details why this can happen and why it is > difficult to fix but I will have it in my mind until something nice and > elegant arise as a solution. > > 1. Each applet has a unique id > 2. Latte is using multiple layouts which are independent of each other that > can have same applet ids for some cases, this is not forbidden. > 3. When Latte is using Multiple layouts mode then it combines 2 and more > layouts together by creating a new temporary hidden layout that contains all > applets from these layouts and updates also their applet ids in order to not > conflict with each other. > > During [3] the global shortcuts assigned to applets might become > inconsistent and as such either break the global shortcut of specific applet > or create duplicate entries. > > Of course that could also happen with Single mode but it must be more rare. > > > Possible solution: > 1. Latte layout(s) must become applets global shortcut activation aware. > That would mean that layouts should be informed and store for their applets > their corresponding global shortcuts. > 2. When a latte layout is loaded either in single or multiple mode the > layout should update the shortcuts assigned for kglobalaccel accordingly. > > > 3. If [1] and [2] are supported correctly then that would mean that we could > provide the nice visual badges the Meta+` triggers in git version to show > also for applets that have assigned global shortcuts through plasma > infrastructure. Thanks for the explanation and your time Michail, greatly appreciated. I am not actively using multiple activities so I'll do some trial and error to see if I can get my configuration to a point where the issue isn't an impact on my usage until a fix can be addressed. Can you point me to the appropriate configuration file that contains the multiple entries I am seeing for the shortcuts? Thanks again. -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 Michail Vourlakos changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- --- Comment #4 from Michail Vourlakos --- that makes sense... I really thank you for this, I would had never thought it... I will provide the technical details why this can happen and why it is difficult to fix but I will have it in my mind until something nice and elegant arise as a solution. 1. Each applet has a unique id 2. Latte is using multiple layouts which are independent of each other that can have same applet ids for some cases, this is not forbidden. 3. When Latte is using Multiple layouts mode then it combines 2 and more layouts together by creating a new temporary hidden layout that contains all applets from these layouts and updates also their applet ids in order to not conflict with each other. During [3] the global shortcuts assigned to applets might become inconsistent and as such either break the global shortcut of specific applet or create duplicate entries. Of course that could also happen with Single mode but it must be more rare. Possible solution: 1. Latte layout(s) must become applets global shortcut activation aware. That would mean that layouts should be informed and store for their applets their corresponding global shortcuts. 2. When a latte layout is loaded either in single or multiple mode the layout should update the shortcuts assigned for kglobalaccel accordingly. 3. If [1] and [2] are supported correctly then that would mean that we could provide the nice visual badges the Meta+` triggers in git version to show also for applets that have assigned global shortcuts through plasma infrastructure. -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #3 from scum.filter+...@gmail.com --- (In reply to Michail Vourlakos from comment #1) > Comment on attachment 116393 [details] > Multiple gloabl keyboard shortcut entries. > > Are you using Multiple Layouts from Settings Window? Hi Michail. Yes, I do have Multiple Layouts enabled in Settings. -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 Michail Vourlakos changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from Michail Vourlakos --- waiting info -- You are receiving this mail because: You are watching all bug changes.
[latte-dock] [Bug 401184] Latte Dock - Global Keyboard Shortcuts Stop Working / Multiple Entries Created
https://bugs.kde.org/show_bug.cgi?id=401184 --- Comment #1 from Michail Vourlakos --- Comment on attachment 116393 --> https://bugs.kde.org/attachment.cgi?id=116393 Multiple gloabl keyboard shortcut entries. Are you using Multiple Layouts from Settings Window? -- You are receiving this mail because: You are watching all bug changes.
