[marble] [Bug 453332] Crash on Panning with Equirectangular Projection

2023-04-22 Thread Torsten Rahn
https://bugs.kde.org/show_bug.cgi?id=453332

Torsten Rahn  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/educ
   ||ation/marble/commit/2508968
   ||372c752daed3b120e482cb006c0
   ||e24e89
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Torsten Rahn  ---
Git commit 2508968372c752daed3b120e482cb006c0e24e89 by Torsten Rahn.
Committed on 22/04/2023 at 20:16.
Pushed by rahn into branch 'master'.

Fix Crash on Panning with Equirectangular Projection

M  +7-0src/lib/marble/ScanlineTextureMapperContext.cpp

https://invent.kde.org/education/marble/commit/2508968372c752daed3b120e482cb006c0e24e89

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 453332] Crash on Panning with Equirectangular Projection

2023-04-22 Thread Torsten Rahn
https://bugs.kde.org/show_bug.cgi?id=453332

--- Comment #2 from Torsten Rahn  ---
Hm, I haven't been able to trigger this when choosing "HighQuality" rendering
during Animations (See Settings) - this uses void
ScanlineTextureMapperContext::pixelValueApproxF instead of void
ScanlineTextureMapperContext::pixelValueApprox.
So I guess that this happens due to a rounding error which calculates the
position to be outside the "last/first" tile in a column.
Since nextTile() will still "stay" on the same tile we will reach out of
bounds.
The safe and lazy solution would be to correct the Y value to be still within
the bounds.
I wonder whether this issue could also be triggered for the x-case

-- 
You are receiving this mail because:
You are watching all bug changes.

[marble] [Bug 453332] Crash on Panning with Equirectangular Projection

2023-04-22 Thread Torsten Rahn
https://bugs.kde.org/show_bug.cgi?id=453332

Torsten Rahn  changed:

   What|Removed |Added

 CC||r...@kde.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Torsten Rahn  ---
Yes, I can reproduce this:

1 Marble::StackedTile::pixel StackedTile.cpp   
   100 0x7773532f 
2 Marble::ScanlineTextureMapperContext::pixelValueApprox
ScanlineTextureMapperContext.cpp  322 0x777207cb 
3 Marble::EquirectScanlineTextureMapper::RenderJob::run 
EquirectScanlineTextureMapper.cpp 219 0x77722e5d 
4 QThreadPoolThread::run() 
   0x751f766a 
5 QThreadPrivate::start(void *)
   0x751f3b35 
6 start_thread   pthread_create.c  
   463 0x734976db 
7 clone  clone.S   
   95  0x748cf61f 


Lokale Variablen
this@0x7fff684782f0 Marble::StackedTile
[Marble::Tile]  @0x7fff684782f0 Marble::Tile
jumpTable32 0x0 uint**
jumpTable8 
""...
(unknown length)  uchar*
m_byteCount 912600  int
m_depth 8   int
m_isGrayscale   truebool
m_isUsedtruebool
m_resultImage   (675x675)   QImage
m_tiles   
QVector >
x   15  int
y   675 int
Inspector   
Ausdrücke   
Rückgabewert
Tooltip 
m_resultImage   (675x675)   QImage

-- 
You are receiving this mail because:
You are watching all bug changes.