[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=441994

dexx...@top-email.net changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from dexx...@top-email.net ---
(In reply to Tammes Burghard from comment #6)
> I made a
> [branch](https://invent.kde.org/kuchenmampfer/minuet/-/tree/
> overhaul_exercises?ref_type=heads) already containing a chord rework that
> should fix this. However, I decided that while I am at it, I might as well
> overhaul all the definitions and exercises. So the MR will have to wait
> until that is done.

That looks very good!
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-03 Thread Tammes Burghard
https://bugs.kde.org/show_bug.cgi?id=441994

--- Comment #6 from Tammes Burghard  ---
I made a
[branch](https://invent.kde.org/kuchenmampfer/minuet/-/tree/overhaul_exercises?ref_type=heads)
already containing a chord rework that should fix this. However, I decided that
while I am at it, I might as well overhaul all the definitions and exercises.
So the MR will have to wait until that is done.

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-03 Thread Tammes Burghard
https://bugs.kde.org/show_bug.cgi?id=441994

--- Comment #5 from Tammes Burghard  ---
I looked into it a bit more and now think the chords that have a proper name
should be called by that name. I will work on it and probably make a MR in the
next days.

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-03 Thread Tammes Burghard
https://bugs.kde.org/show_bug.cgi?id=441994

Tammes Burghard  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #4 from Tammes Burghard  ---
Ah, you are talking about the bigger chords. I only checked the seventh ones.
Yes I agree that symbols would be better. I don't yet know how to render them
correctly, but will think about it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=441994

dexx...@top-email.net changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|NOT A BUG   |---

--- Comment #3 from dexx...@top-email.net ---
for example:
{
  "tags": ["chord", "root-position", "major", "9", "extended"],
  "name": "Major 9",
  "sequence": "4 7 10 14"
},

shouldn't say "Major 9" but "Dominant 9", because the seventh is a minor
seventh.
A Xmaj9 chord is a major chord with a major seventh with a major ninth added, a
X9 chord is a major chord with a minor seventh and major ninth added. In the
example the seventh has 10 semitones which makes it a dominant chord.
I think the name of the chord is in all cases misleading. All "Major" and
"Minor" names should disappear in favour of the correct chord symbol.
the chord symbol should say X^9 because then its clear you want a dominant
seventh chord with a major ninth. A X^maj9 chord would contain a major seventh
and a major ninth

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-02 Thread Tammes Burghard
https://bugs.kde.org/show_bug.cgi?id=441994

Tammes Burghard  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #2 from Tammes Burghard  ---
Hmmm. I just looked through the definitions and they look correct to me.
I will close this, if you disagree feel free to reopen and explain in further
detail.

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-02 Thread Tammes Burghard
https://bugs.kde.org/show_bug.cgi?id=441994

--- Comment #1 from Tammes Burghard  ---
Yes, that should work. If you want to do that just for yourself, you would have
to find that file. I didn't find it yet, but will try to.
However, adding definitions upstream also is an option.
I will try to fix this mistake there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[minuet] [Bug 441994] chord definitions for dominant seventh chords are mostly wrong

2023-11-02 Thread Tammes Burghard
https://bugs.kde.org/show_bug.cgi?id=441994

Tammes Burghard  changed:

   What|Removed |Added

   Assignee|sandroandr...@kde.org   |k...@kuchenmampfer.de
 CC||k...@kuchenmampfer.de

-- 
You are receiving this mail because:
You are watching all bug changes.