[okteta] [Bug 367863] add string encoding="ebcdic"

[Alex Richardson]

https://bugs.kde.org/show_bug.cgi?id=367863

Alex Richardson  changed:

   What|Removed |Added

  Latest Commit||http://commits.kde.org/okte
   ||ta/b455b93cb15fb3af078c48e7
   ||0f326aa6efe6275e
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Alex Richardson  ---
Git commit b455b93cb15fb3af078c48e70f326aa6efe6275e by Alex Richardson, on
behalf of Aaron Bishop.
Committed on 27/10/2016 at 17:15.
Pushed by arichardson into branch 'master'.

add encoding="ebcdic" to string structures

fix bug 367863 structures string encoding ebcdic

Testing Done:
builds, tested example from bug 367863 and it behaves as expected. ctest passes
100% of 54 tests. I only added one test condition to commonparsertest.

REVIEW: 128795

M  +2-0kasten/controllers/CMakeLists.txt
M  +2-0kasten/controllers/test/commonparsertest.cpp
A  +160  -0   
kasten/controllers/view/structures/datatypes/strings/ebcdicstringdata.cpp
[License: LGPL]
A  +55   -0   
kasten/controllers/view/structures/datatypes/strings/ebcdicstringdata.h
[License: LGPL]
M  +5-0   
kasten/controllers/view/structures/datatypes/strings/stringdatainformation.cpp
M  +3-2   
kasten/controllers/view/structures/datatypes/strings/stringdatainformation.h
M  +3-0kasten/controllers/view/structures/parsers/parserutils.cpp

http://commits.kde.org/okteta/b455b93cb15fb3af078c48e70f326aa6efe6275e

-- 
You are receiving this mail because:
You are watching all bug changes.

[okteta] [Bug 367863] add string encoding="ebcdic"

[Aaron Bishop via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367863

--- Comment #4 from Aaron Bishop  ---
I didn't publish, sorry. First time submitting a patch to a KDE project. I
added you as a reviewer and published.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okteta] [Bug 367863] add string encoding="ebcdic"

[Alex Richardson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367863

--- Comment #3 from Alex Richardson  ---
Thank you very much for the patch.

Unfortunately I can't see the review request, it says
"You don't have access to this review request.

This review request is private. You must be a requested reviewer, either
directly or on a requested group, and have permission to access the repository
in order to view this review request."

Possibly you didn't click publish yet?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okteta] [Bug 367863] add string encoding="ebcdic"

[Aaron Bishop via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367863

--- Comment #2 from Aaron Bishop  ---
Submitted https://git.reviewboard.kde.org/r/128795/

-- 
You are receiving this mail because:
You are watching all bug changes.

[okteta] [Bug 367863] add string encoding="ebcdic"

[Alex Richardson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=367863

Alex Richardson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #1 from Alex Richardson  ---
Added to my to do list. However, I am quite busy at the moment and probably
won't have time to work on okteta for the next 2 months.

-- 
You are receiving this mail because:
You are watching all bug changes.