[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=362038

Albert Astals Cid  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

--- Comment #15 from Albert Astals Cid  ---
*** Bug 311045 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362038

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||19.04.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=362038

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/716b234100ca260f97a3891
   ||c23e8385c94c06744
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Albert Astals Cid  ---
Git commit 716b234100ca260f97a3891c23e8385c94c06744 by Albert Astals Cid, on
behalf of Joao Netto.
Committed on 13/02/2019 at 22:59.
Pushed by aacid into branch 'master'.

Implemented find function from console

Summary:
Implemented feature request to find from console.

Reviewers: #okular, aacid

Reviewed By: #okular, aacid

Subscribers: ngraham, aacid, yurchor, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D18144

M  +47   -32   autotests/mainshelltest.cpp
M  +1-1core/document.cpp
M  +1-1generators/poppler/generator_pdf.cpp
M  +14   -1part.cpp
M  +4-0part.h
M  +2-1shell/main.cpp
M  +7-1shell/okular_main.cpp
M  +3-0shell/shell.cpp
M  +24   -13   shell/shellutils.cpp
M  +2-1shell/shellutils.h
M  +6-0ui/findbar.cpp
M  +1-0ui/findbar.h

https://commits.kde.org/okular/716b234100ca260f97a3891c23e8385c94c06744

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=362038

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=362038

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #13 from Albert Astals Cid  ---
Use reviewboard.kde.org for patches instead of  not bugzilla

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #12 from Ahmed Hussein  ---
(In reply to Ahmed Hussein from comment #11)
> Created attachment 102715 [details]
> read find argument from CLI

What Should I do next?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #11 from Ahmed Hussein  ---
Created attachment 102715
  --> https://bugs.kde.org/attachment.cgi?id=102715=edit
read find argument from CLI

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #10 from Albert Astals Cid  ---
(In reply to Ahmed Hussein from comment #9)
> Thank you, I will wait.
> I ask that question at IRC yesterday and today and no answer :D

Maybe you can show the code you have? 

I could not understand the problem you have by reading your previous question.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #9 from Ahmed Hussein  ---
Thank you, I will wait.
I ask that question at IRC yesterday and today and no answer :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Yuri Chornoivan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

Yuri Chornoivan  changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #8 from Yuri Chornoivan  ---
(In reply to Ahmed Hussein from comment #7)
> Could you recommend someone to help me?!

The replies to this bug report are in the okular-devel@ mailing list. So all
current developers are informed about this question. Just wait until somebody
of them answer it.

There are also IRC channels on freenode, #okular and #kde-devel to discuss
development questions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #7 from Ahmed Hussein  ---
Could you recommend someone to help me?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[nicholas via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #6 from nicholas  ---
sorry, all this framework stuff outside of my scope of expertise.

On 24 September 2016 at 15:00, Ahmed Hussein via KDE Bugzilla
 wrote:
> https://bugs.kde.org/show_bug.cgi?id=362038
>
> --- Comment #5 from Ahmed Hussein  ---
> Sorry, It just work Friday and Saturday. While I was working on this project I
> use Shell project as start project and parse argument to get search string.
> Then I pass QString to Shell::openDocument - I override openDocument to take
> two arguments. Now I want to pass search text to Okular::Document after 
> opening
> url. I am stuck here. Should I access Okular::part using singal same as
> "enableStartWithPrint" then use m_document or that is wrong?!
>
> --
> You are receiving this mail because:
> You reported the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #5 from Ahmed Hussein  ---
Sorry, It just work Friday and Saturday. While I was working on this project I
use Shell project as start project and parse argument to get search string.
Then I pass QString to Shell::openDocument - I override openDocument to take
two arguments. Now I want to pass search text to Okular::Document after opening
url. I am stuck here. Should I access Okular::part using singal same as
"enableStartWithPrint" then use m_document or that is wrong?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[nicholas via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #4 from nicholas  ---
Sure, here to help, good luck with your first bug!

On 17 Sep 2016 8:28 p.m., "Ahmed Hussein via KDE Bugzilla" <
bugzilla_nore...@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=362038
>
> --- Comment #3 from Ahmed Hussein  ---
> Great thank you. I will continue and if I have question I will ask here.
> Is it
> ok?!
>
> --
> You are receiving this mail because:
> You reported the bug.
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #3 from Ahmed Hussein  ---
Great thank you. I will continue and if I have question I will ask here. Is it
ok?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[nicholas via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

--- Comment #2 from nicholas  ---
so the command instructs evince to open on the specified page and
highlight/move to the first occurrence of the word

from http://manpages.ubuntu.com/manpages/wily/man1/evince.1.html

*--page-index=NUMBER*
  Open the document on the page  with  the  specified  page  index
  (this is the exact page number, not a page label).

*--find=string*
  You  can  pass  a word or phrase here. If it exists, evince will
  display the document and the first match.


the actual command "evince --page-index=%p --find=%s %f" is copied from
recoll (http://www.lesbonscomptes.com/recoll/)
in "user preferences"-> "choose editor applications" i can use okular here,
but cannot get the same functionality which is very important (i have had
to install evince for this single use case!)

since you have documentation and application (evince) to benchmark, I
assume this is clear?

Nicholas

On 17 September 2016 at 14:01, Ahmed Hussein via KDE Bugzilla <
bugzilla_nore...@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=362038
>
> Ahmed Hussein  changed:
>
>What|Removed |Added
> 
> 
>  CC||
> thelastrealde...@gmail.com
>
> --- Comment #1 from Ahmed Hussein  ---
> This is my first Bug. I want more info for this bug.
> 1. I implement find Arg and read it "--find ". What do you mean
> with
> --page-index?
> 2. I don't understand what should i do with page Arg. Should I highlight
> search
> only or force to first selected word.
>
> --
> You are receiving this mail because:
> You reported the bug.
>

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Ahmed Hussein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

Ahmed Hussein  changed:

   What|Removed |Added

 CC||thelastrealde...@gmail.com

--- Comment #1 from Ahmed Hussein  ---
This is my first Bug. I want more info for this bug. 
1. I implement find Arg and read it "--find ". What do you mean with
--page-index?
2. I don't understand what should i do with page Arg. Should I highlight search
only or force to first selected word.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 362038] feature request for "find" functionality from console startup (CLI)

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362038

Albert Astals Cid  changed:

   What|Removed |Added

   Keywords||junior-jobs
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.