[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[David de Cos]

https://bugs.kde.org/show_bug.cgi?id=383652

--- Comment #11 from David de Cos  ---
Thanks, I just reported it as Bug 430153.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=383652

--- Comment #10 from David Hurka  ---
I agree.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[David de Cos]

https://bugs.kde.org/show_bug.cgi?id=383652

--- Comment #9 from David de Cos  ---
(In reply to David Hurka from comment #8)

You're right, David. Thank you very much for your help. Two observations on
your solution:

1) I wouldn't have been able to discover that by myself in a hundred years,
because I didn't have the quick annotations icon in my menu. I did have,
however, the stamps drop-down icon, which is where it should have appeared from
the beginning, at least the way I see it. It is a stamp, after all.

2) Afterwards, when you change to some other annotation type, your custom stamp
stays in the stamps list (good). But if you close Okular and open it again,
your stamp is gone from the stamps list, and you have to go through the quick
annotations icon again (bad).

I think a bug report should be open on this issue (either reopen this one or
create a new one). If someone agrees with me, I'll open it myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=383652

--- Comment #8 from David Hurka  ---
AFAIK there is just a “custom stamp” in the stamp tool button, and this only
becomes an actual custom stamp when you select such a tool from the Quick
Annotations menu. Don’t know what happens when Quick Annotations no longer
configure the annotation toolbar.

Your custom stamp tool should be in the Quick Annotations menu now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[David de Cos]

https://bugs.kde.org/show_bug.cgi?id=383652

David de Cos  changed:

   What|Removed |Added

 CC||david.de...@ehu.eus

--- Comment #7 from David de Cos  ---
I'm in Okular 1.11.3, and I can't get this to work. I can add my custom stamp
to the annotation tools list in Settings -> Configure Okular -> Annotations ->
Add ->  Choose "Stamp" as Type and select image file. But then, when I click on
my drop-down stamp icon in the annotations toolbar, the stamp I just added is
not in the list. Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383652

Nate Graham  changed:

   What|Removed |Added

 CC||cappelloro...@riseup.net

--- Comment #6 from Nate Graham  ---
*** Bug 411666 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Simone Gaiarin]

https://bugs.kde.org/show_bug.cgi?id=383652

Simone Gaiarin  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||okular/commit/f15e8568a5330
   ||b6795b1dd5287a6a1530dc60476
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||1.9.0

--- Comment #5 from Simone Gaiarin  ---
Git commit f15e8568a5330b6795b1dd5287a6a1530dc60476 by Simone Gaiarin.
Committed on 25/07/2019 at 18:09.
Pushed by gaiarin into branch 'master'.

General improvements to stamp annotation

Summary:
Configuration:
- Add push button to select custom stamp image
- Check if loaded image is usable as stamp or throw error
- Keep image proportions in previewer
- Move previewer below the combobox to display larger preview

Annotation tool:
- Keep stamp image proportion in annotation preview (while left mouse button is
down)
- Adding the annotation with one-click (without holding the left mouse button
and dragging) adds the stamp with original proportions
Related: bug 370381, bug 383651
FIXED-IN: 1.9.0

Closes T8074

TODO:
- [ ] Check if filters in file chooser make sense / propose better alternative
- [x] Update doc ( @yurchor will do it after we merge this)

Test Plan:
>From stamp annotation configuration dialog:
- Show a warning regarding limitations of the feature's current implementation
- Click push button next to combo box opens a file selector
- Selecting a corrupted image file should throw an error
- Selecting a good image file shows the preview of the image
- Select a horizontal image shows a large clear preview
- Select a vertical image file shows a smaller preview without messing up the
visual of the config dialog
- Input a valid icon name in the combobox and the preview of the icon is shown

>From page view, select the stamp annotation with horizontal image file (not 
>squared):
- Click and hold. The preview maintains proportions
- Single click. The stamp image in the pdf maintains proportions and has the
same size of the click and hold preview.
- Add an annotation of the Okular custom stamps (internal SVG so treated
slightly differently) do not create problems

Reviewers: #okular, ngraham

Reviewed By: ngraham

Subscribers: pino, aacid, yurchor, ngraham, okular-devel

Tags: #okular

Maniphest Tasks: T8074

Differential Revision: https://phabricator.kde.org/D22064

M  +62   -9ui/annotationwidgets.cpp
M  +7-1ui/annotationwidgets.h
M  +25   -9ui/guiutils.cpp
M  +8-1ui/guiutils.h
M  +1-1ui/pagepainter.cpp
M  +4-4ui/pageviewannotator.cpp

https://invent.kde.org/kde/okular/commit/f15e8568a5330b6795b1dd5287a6a1530dc60476

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383652

Nate Graham  changed:

   What|Removed |Added

 CC||k...@mail.orbitel.bg

--- Comment #4 from Nate Graham  ---
*** Bug 397117 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=383652

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Andrew Crouthamel]

https://bugs.kde.org/show_bug.cgi?id=383652

Andrew Crouthamel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||croutham...@gmail.com

--- Comment #3 from Andrew Crouthamel  ---
Work on this is occurring at: https://phabricator.kde.org/T8074

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383652

Nate Graham  changed:

   What|Removed |Added

 CC||lopeziba...@gmail.com

--- Comment #2 from Nate Graham  ---
*** Bug 354894 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383652

Nate Graham  changed:

   What|Removed |Added

 CC||alberthilb...@gmail.com

--- Comment #1 from Nate Graham  ---
*** Bug 159007 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383652

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.