[okular] [Bug 397463] okular session management

2020-11-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 CC||kdebugs+accou...@jalsti.de

--- Comment #29 from Nate Graham  ---
*** Bug 429015 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2020-09-10 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=397463

David Hurka  changed:

   What|Removed |Added

 CC||jtam...@gmail.com

--- Comment #28 from David Hurka  ---
*** Bug 426380 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2020-09-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=397463

hala...@fmi.unibuc.ro changed:

   What|Removed |Added

 CC||hala...@fmi.unibuc.ro

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2020-08-20 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=397463

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #27 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/okular/-/merge_requests/247

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2020-05-09 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #26 from avlas  ---
I know session management is not in, but the okular session should be restored
automatically in Okular since 19.12, right? 

I forgot about it until recently thinking it was supposed to land in 20.04.
Unfortunately I can't get this to work, neither before in 19.12 nor now in
20.04.

I checked settings and didn't see anything to this respect. I wonder, are there
config files or anything that I need to edit/delete to make this work?

Any guidance is highly appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2020-02-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397463

Albert Astals Cid  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 CC||aa...@kde.org

--- Comment #25 from Albert Astals Cid  ---
Yeah this is not in, i jsut made the same mistake Nate made

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2020-02-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=397463

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||okular/commit/a5a8d82fb3a25
   ||670bc241d9b5f3f15e98ec7d475
   Version Fixed In||1.9.0
 Resolution|--- |FIXED

--- Comment #24 from Albert Astals Cid  ---
Git commit a5a8d82fb3a25670bc241d9b5f3f15e98ec7d475 by Albert Astals Cid, on
behalf of Nate Graham.
Committed on 10/02/2020 at 21:32.
Pushed by aacid into branch 'session-restoration'.

Restore previously-open documents on launch by default
FIXED-IN: 1.9.0

M  +1-0conf/dlggeneral.cpp
M  +7-0conf/dlggeneralbase.ui
M  +3-0conf/okular_core.kcfg
M  +1-1shell/CMakeLists.txt
M  +15   -6shell/main.cpp
M  +14   -0shell/shell.cpp

https://invent.kde.org/kde/okular/commit/a5a8d82fb3a25670bc241d9b5f3f15e98ec7d475

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #23 from Nate Graham  ---
Git commit 46e5b32ed9293749661eb5a5a8c32e77b1853f1e by Nate Graham.
Committed on 20/11/2019 at 14:26.
Pushed by ngraham into branch 'master'.

Also allow invoking session restoration logic when apps are manually launched

Summary:
Right now session restoration logic only ever gets invoked when apps are
started
automatically after rebooting, because of the check for
`qApp->isSessionRestored()`.
This limits the feature to only working for that use case, since
`qApp->isSessionRestored()`
is set by Qt and we can't override it in the app itself to signal that we want
the session
restoration behavior for other reasons. As a result, we can't use it to
implement the
behavior of restoring the condition of app when it's manually launched, which
has been
requested for several of our apps.

This patch removes the check for `qApp->isSessionRestored()`, which opens the
door to
implementing the requested features in our apps.
Related: bug 413564

Test Plan:
D11382 now works

Normal session restoration behavior after a reboot is unchanged

Apps with session restoration behavior but without a user-facing option to
invoke it
don't restore session at inappropriate times.

Reviewers: davidedmundson, #frameworks

Reviewed By: davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25106

M  +0-6src/kmainwindow.cpp

https://commits.kde.org/kxmlgui/46e5b32ed9293749661eb5a5a8c32e77b1853f1e

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #22 from ilk...@gmail.com ---
Thank you Nate, appreciate the good work. 
Looking forward to seeing it in Ubuntu repository.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #21 from avlas  ---
(In reply to Nate Graham from comment #20)
> Ah I see what you mean.
> 
> I guess what I implemented is a precursor to it then. :)

and very much appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #20 from Nate Graham  ---
Ah I see what you mean.

I guess what I implemented is a precursor to it then. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #19 from avlas  ---
> Please don't get me wrong, I am very happy about your fix. But IMO, the 
> session manager would really make a difference.

In other words, your fix seems to me like "solving a bug" because session
restoration should in principle be expected, whereas accounting for session
management is not really fixing any bug (as it is not necessarily expected) but
would be an extremely cool feature and a remarkable difference with respect to
all other PDF viewers, with great benefit to all users that heavily go through
PDF documents.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #18 from avlas  ---
Thank you Nathan for the great work!

This is very much wanted and needed. However, this seems to be a fix "only" for
session restoration, but not for session management (as in Kate), which is what
the issue ultimately is about, and all Okular users here are so excited about.
Am I wrong?

Please don't get me wrong, I am very happy about your fix. But IMO, the session
manager would really make a difference.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
 Ever confirmed|1   |0
 Resolution|FIXED   |---

--- Comment #17 from Nate Graham  ---
Nope not actually fixed yet, just submitted:
https://invent.kde.org/kde/okular/merge_requests/58/diffs.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|1.9.0   |
  Latest Commit|https://invent.kde.org/kde/ |
   |okular/commit/988be90c4853e |
   |db3b8b9e53aac4e3d258b2e9f95 |

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-11-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||okular/commit/988be90c4853e
   ||db3b8b9e53aac4e3d258b2e9f95
   Version Fixed In||1.9.0
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Nate Graham  ---
Git commit 988be90c4853edb3b8b9e53aac4e3d258b2e9f95 by Nate Graham.
Committed on 01/11/2019 at 21:16.
Pushed by ngraham into branch 'session-restoration'.

Restore previously-open documents on launch by default
FIXED-IN: 1.9.0

M  +1-0conf/dlggeneral.cpp
M  +7-0conf/dlggeneralbase.ui
M  +3-0conf/okular_core.kcfg
M  +1-1shell/CMakeLists.txt
M  +15   -6shell/main.cpp
M  +14   -0shell/shell.cpp

https://invent.kde.org/kde/okular/commit/988be90c4853edb3b8b9e53aac4e3d258b2e9f95

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-10-21 Thread Pankaj Bhanu
https://bugs.kde.org/show_bug.cgi?id=397463

Pankaj Bhanu  changed:

   What|Removed |Added

 CC||bhanu.pankaj7...@gmail.com

--- Comment #15 from Pankaj Bhanu  ---
I read a lot of pdfs and like to annotate the documents I read. In linux,
okular is the best app which provides these functionalities. The ability to
restore sessions in Okular itself (not as part of KDE session restore) is the
only missing feature which would make this app ideal for a lot of students and
researchers.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-09-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=397463

ilk...@gmail.com changed:

   What|Removed |Added

 CC||ilk...@gmail.com

--- Comment #14 from ilk...@gmail.com ---
Hello,
Any development about this issue? I would also love to see this solved. 

Thank you & keep up the great work on KDE.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-06-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 CC||lev...@gmx.net

--- Comment #13 from Nate Graham  ---
*** Bug 408588 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-05-21 Thread Gabriel
https://bugs.kde.org/show_bug.cgi?id=397463

Gabriel  changed:

   What|Removed |Added

 CC||gabrielper...@gmail.com

--- Comment #12 from Gabriel  ---
Researcher here. I use Okular outside of KDE so having its own session
management would be ideal.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-05-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-05-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 CC||pmli...@free.fr

--- Comment #11 from Nate Graham  ---
*** Bug 364680 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-05-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 CC||ho...@spliced.me.uk

--- Comment #9 from Nate Graham  ---
*** Bug 341734 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2019-05-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 CC||ric.richte...@gmail.com

--- Comment #10 from Nate Graham  ---
*** Bug 407548 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-11-20 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

avlas  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|RESOLVED|REPORTED
 Resolution|DUPLICATE   |---

--- Comment #8 from avlas  ---
(In reply to Nate Graham from comment #7)
> Yep, looks like it!
> 
> *** This bug has been marked as a duplicate of bug 364680 ***

I disagree. Bug 364680 is only about restoring last session. This bug has
become about session management as in Kate. See comment below:

> I would actually love to have okular sessions (regardless of Bug 387490) as 
> they are a very nice way to organize pdf 'workflows'. I am a researcher, and 
> or me okular sessions would be as important as kate sessions when I put the 
> coding 'hat' on. And I bet this may be similar for other users.

If this is closed as duplicate I will need to create a new one with the name:
"okular session management", which is exactly the same title as this current
one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-11-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Nate Graham  ---
Yep, looks like it!

*** This bug has been marked as a duplicate of bug 364680 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-11-20 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #6 from Christoph Feck  ---
Duplicate of bug 364680?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-11-02 Thread Viktor
https://bugs.kde.org/show_bug.cgi?id=397463

Viktor  changed:

   What|Removed |Added

 CC||viktor.marin...@gmail.com

--- Comment #5 from Viktor  ---
Here's another researcher chiming in for such a feature!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-08-21 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #4 from avlas  ---
(In reply to Nate Graham from comment #3)
> Thanks for the info. I see your point, and I have a researcher friend who
> also uses Okular in this way and has told me he'd like this feature. Seems
> like it could be a nice addition.

Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-08-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from Nate Graham  ---
Thanks for the info. I see your point, and I have a researcher friend who also
uses Okular in this way and has told me he'd like this feature. Seems like it
could be a nice addition.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-08-21 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #2 from avlas  ---
(In reply to Nate Graham from comment #1)

I would actually love to have okular sessions (regardless of Bug 387490) as
they are a very nice way to organize pdf 'workflows'. I am a researcher, and
for me okular sessions would be as important as kate sessions when I put the
coding 'hat' on. And I bet this may be similar for other users.

> Seems kind of like if we fix Bug 387490, you won't need Okular to have its
> own session manager, right?

Said that, fixing Bug 387490, would be a nice starting point. However, my
experience tells me (I may be wrong though) that these errors happen because
okular tries to load a pdf file from an URL before the network is connected.

See also Bug 397638 that also refers to a bug that emerges because applications
are restored to early, in this case before the appmenu kded module is set.

I think these two issues (Bug 387490 and Bug 397638) could be ideally fixed in
ksmserver, although not I'm not sure about the technicalities or how difficult
this could be.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 397463] okular session management

2018-08-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Nate Graham  ---
Seems kind of like if we fix Bug 387490, you won't need Okular to have its own
session manager, right?

-- 
You are receiving this mail because:
You are watching all bug changes.