[okular] [Bug 417118] Okular crashes on Print preview

2020-02-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=417118

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/kde/
   ||okular/commit/cb3426d024971
   ||f6de424fbeed1b94869222eb10f
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Albert Astals Cid  ---
Git commit cb3426d024971f6de424fbeed1b94869222eb10f by Albert Astals Cid.
Committed on 09/02/2020 at 23:42.
Pushed by aacid into branch 'master'.

Fix crash when not in viewer mode

M  +1-0ui/pageview.cpp

https://invent.kde.org/kde/okular/commit/cb3426d024971f6de424fbeed1b94869222eb10f

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-07 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=417118

--- Comment #8 from Yuri Chornoivan  ---
(In reply to David Hurka from comment #7)
> To fix this, just d->aMouseModeMenu needs to be nullptr-initialized in the
> PageView constructor. Apparently I forgot that when I created D21971.
> 
> How can I create a merge request? On the invent.kde.org website, I am
> apparently not allowed to do so. Via the git command line, I get an error
> that I am not allowed to do so. And via email, I get a reply that I am not
> allowed to do so...

Can you fork the repo? If so, just commit into your clone then create merge
request.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-07 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=417118

--- Comment #7 from David Hurka  ---
To fix this, just d->aMouseModeMenu needs to be nullptr-initialized in the
PageView constructor. Apparently I forgot that when I created D21971.

How can I create a merge request? On the invent.kde.org website, I am
apparently not allowed to do so. Via the git command line, I get an error that
I am not allowed to do so. And via email, I get a reply that I am not allowed
to do so...

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-05 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=417118

--- Comment #6 from David Hurka  ---
I think it is a problem because Print Preview opens a new window with another
ToggleActionMenu? I will try to investigate, maybe tomorrow.

Maybe it is a good Idea to drop ToggleActionMenu. ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-04 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=417118

--- Comment #5 from Yuri Chornoivan  ---
(In reply to Albert Astals Cid from comment #4)
> Yuri i guess this is the same thing you're seeing in Kile

Yes, both problems can be removed after reverting
0d5bd0bc43b26e94833b133afc2fbbdb66346652

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=417118

Albert Astals Cid  changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #4 from Albert Astals Cid  ---
Yuri i guess this is the same thing you're seeing in Kile

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=417118

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1
 CC||david.hu...@mailbox.org

--- Comment #3 from Albert Astals Cid  ---
Garg, i shouldn't have merged the code from David from phabricaotr without
using invent.

The unittests would have found it.

David can you please fix this mess?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-03 Thread Siddhartha Sahu
https://bugs.kde.org/show_bug.cgi?id=417118

--- Comment #2 from Siddhartha Sahu  ---
Built from the latest master (commit on Feb 1): okular-git-r8658.c6d937ab0

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 417118] Okular crashes on Print preview

2020-02-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=417118

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
How recent is your "compiled from sources"?

-- 
You are receiving this mail because:
You are watching all bug changes.