[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-08-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421780

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #8 from Nate Graham  ---
As much as I like the smooth animated scrolling in principle, I think we need
to revert those commits and focus on another approach. They just caused too
many regressions. :/

Albert, I'd be in favor of doing this for the 20.12 release. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-08-05 Thread Bernhard Rosenkränzer
https://bugs.kde.org/show_bug.cgi?id=421780

--- Comment #7 from Bernhard Rosenkränzer  ---
Created attachment 130671
  --> https://bugs.kde.org/attachment.cgi?id=130671&action=edit
Partial revert that fixes it

The attached patch, a partial revert of the problematic commit, "fixes" the
issue (but of course destroys the advantages of using QScroller).

I'll keep this in our package until the real problem is sorted out, it's not
perfect but better than nothing, at least it restores what was working in
19.12.x

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-08-05 Thread Bernhard Rosenkränzer
https://bugs.kde.org/show_bug.cgi?id=421780

--- Comment #6 from Bernhard Rosenkränzer  ---
The problem seems to be

d->scroller->scrollTo(d->scroller->finalPosition() + QPoint(0, 100 * nSteps),
0);

in slotScrollDown() in ui/pageview.cpp not having any effect (even though
nSteps == 1) when it is called by the keyboard event and wheel event handlers.

I've never used QScroller, so I'm not familiar with its internals -- but at a
first glance, looks like a Qt bug and makes me wonder why others aren't seeing
this (we're using stock qt 5.15).

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-08-05 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=421780

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #5 from Albert Astals Cid  ---
Not a surprise, that patch breaks everything.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-08-05 Thread Bernhard Rosenkränzer
https://bugs.kde.org/show_bug.cgi?id=421780

Bernhard Rosenkränzer  changed:

   What|Removed |Added

Version|1.10.1  |1.10.80

--- Comment #4 from Bernhard Rosenkränzer  ---
Finally got around to bisecting this.

The culprit is

commit 51b90ecd73e37b9646d8a4bbb51e4fa815942912
Author: kezi olio 
Date:   Fri Nov 15 16:08:25 2019 +

Add kinetic scrolling & smooth navigation with cursor keys

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-06-11 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=421780

--- Comment #3 from David Hurka  ---
How about toggling Continuous in various places? See Bug 421399.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-06-10 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421780

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #2 from Nate Graham  ---
Also can't reproduce on Qt 5.15. Okular is working great for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-05-19 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=421780

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #1 from Aleix Pol  ---
Just tested as per Albert's request, can't reproduce.

Running all fresh master, Qt from:
commit 5f03b84e6542f00cf9eccd1d8820f423cee5e2b9 (HEAD -> 5.15, origin/5.15)
Author: Heikki Halmet 
Date:   Tue Apr 28 14:53:47 2020 +0300

-- 
You are receiving this mail because:
You are watching all bug changes.