[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails needs visual polish
https://bugs.kde.org/show_bug.cgi?id=442863 --- Comment #8 from Nate Graham --- I agree, it should probably stay on the thumbnail view. The positioning does look like a hidpi positioning bug. As for the icon chosen, we'll need to hardcode something in the app or pick an icon from the icon theme that is designed for this purpose--those would be emblems. Unfortunately there is no bookmark emblem in the Breeze theme, and I assume not in other themes either. I can create one and make Okular use it, and then hopefully other themes will fall back to Breeze and get the Breeze icon. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails needs visual polish
https://bugs.kde.org/show_bug.cgi?id=442863 --- Comment #7 from Albert Astals Cid --- It looked much better when bookmark was a solid yellow star, then it was not a star anymore, and thus it was less noticeable, the problem of Okular not being in control of the icons used in the app, it can't always make it look nice for all styles and icon set variations. David is right though, the x positioning of the icon on your screenshot looks wrong. I disagree with showing this information in the main view, once you start doing that you'll get reports of "shows the pdf wrong, some artifact in this location". -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails needs visual polish
https://bugs.kde.org/show_bug.cgi?id=442863 --- Comment #6 from David Hurka --- Here it appears in the top-right corner. Looks a bit like a paper clip. Maybe it is not correctly positioned on hiDPI? I think it doesn’t look very beautiful. And it is not very noticeable, when navigating through the document the thumbnails panel scrolls too fast. There is not only this emblem appearing, the whole viewport changes. I think bookmarks should be visible in the main view. Like a speech bubble outside the left or right page border. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails needs visual polish
https://bugs.kde.org/show_bug.cgi?id=442863 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED Severity|normal |wishlist Summary|Bookmark icon overlaid on |Bookmark icon overlaid on |top of thumbnails |top of thumbnails needs ||visual polish --- Comment #5 from Nate Graham --- Oh I see, it's a feature. It isn't very visually polished so I thought it was a bug. :) Typically for a badge/overlay like this, we use an icon designed to look good in an overlay role called an emblem, of which there are many in the Breeze theme. And we usually put it in the corner, not right in the middle. I'll work on a merge request to improve the presentation. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails
https://bugs.kde.org/show_bug.cgi?id=442863 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #4 from Albert Astals Cid --- Yes, if the page is bookmarked we show a bookmark on the page. How is that a bug? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails
https://bugs.kde.org/show_bug.cgi?id=442863 --- Comment #3 from David Hurka --- I think I have seen that before. But same here, I wasn’t aware of it. I never use bookmarks. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails
https://bugs.kde.org/show_bug.cgi?id=442863 --- Comment #2 from Nate Graham --- Hmm, maybe not a recent regression; git bisect shows that this has been the case for ages... have I really just been blind to it? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 442863] Bookmark icon overlaid on top of thumbnails
https://bugs.kde.org/show_bug.cgi?id=442863 --- Comment #1 from Nate Graham --- Bisecting now... -- You are receiving this mail because: You are watching all bug changes.
