[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-28 Thread morashon
https://bugs.kde.org/show_bug.cgi?id=450685

morashon  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #9 from morashon  ---
Since latest build has incidentally fixed this I will close this bug out.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-23 Thread morashon
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #8 from morashon  ---
Sorry for my previous comment, unfamiliar with how this system works with the
replying. After compiling and installing the latest build I was able to
successfully backup and restore a partition twice from my pen drive. So this
issue seems to be resolved in latest build with the changes you mentioned.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-23 Thread morashon
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #7 from morashon  ---
> Well, partition type shouldn't matter and it looks like your backup file is
> already corrupted, so it's not restore process either.
> 
> That's why I was just testing with running backing up and checking partition
> signature with blkid (that should be sufficient to tell whether backup is
> empty file or not).
> 
> Would you be willing to try to compile the latest version of kpmcore and
> partitionmanager (and probably with some diagnostic patches later to see
> where things go wrong)?
> 
> Right now I have no idea what's going wrong. The latest version from git
> does have some changes but I can't tell whether they'll help or not (when
> copying disk data now we open and close files just once rather for each 10
> MiB chunk that we copy).
> 
> By the way, copying happens here:
> https://invent.kde.org/system/kpmcore/-/blob/master/src/util/
> externalcommandhelper.cpp#L239

(In reply to Andrius Štikonas from comment #6)
> (In reply to morashon from comment #5)
> > So I tested twice with btrfs partition. On first test I told KDE Partition
> > Manager to restore the backup overwriting the existing backed-up partition.
> > When running the btrfs check --repair command after closing device it
> > returned "Error". KDE partition manager again saw this as an unknown
> > partition.
> Well, partition type shouldn't matter and it looks like your backup file is
> already corrupted, so it's not restore process either.
> 
> That's why I was just testing with running backing up and checking partition
> signature with blkid (that should be sufficient to tell whether backup is
> empty file or not).
> 
> Would you be willing to try to compile the latest version of kpmcore and
> partitionmanager (and probably with some diagnostic patches later to see
> where things go wrong)?
> 
> Right now I have no idea what's going wrong. The latest version from git
> does have some changes but I can't tell whether they'll help or not (when
> copying disk data now we open and close files just once rather for each 10
> MiB chunk that we copy).
> 
> By the way, copying happens here:
> https://invent.kde.org/system/kpmcore/-/blob/master/src/util/
> externalcommandhelper.cpp#L239

I am willing to do so. I'll get the latest and do a test and report back.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-23 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #6 from Andrius Štikonas  ---
(In reply to morashon from comment #5)
> So I tested twice with btrfs partition. On first test I told KDE Partition
> Manager to restore the backup overwriting the existing backed-up partition.
> When running the btrfs check --repair command after closing device it
> returned "Error". KDE partition manager again saw this as an unknown
> partition.
Well, partition type shouldn't matter and it looks like your backup file is
already corrupted, so it's not restore process either.

That's why I was just testing with running backing up and checking partition
signature with blkid (that should be sufficient to tell whether backup is empty
file or not).

Would you be willing to try to compile the latest version of kpmcore and
partitionmanager (and probably with some diagnostic patches later to see where
things go wrong)?

Right now I have no idea what's going wrong. The latest version from git does
have some changes but I can't tell whether they'll help or not (when copying
disk data now we open and close files just once rather for each 10 MiB chunk
that we copy).

By the way, copying happens here:
https://invent.kde.org/system/kpmcore/-/blob/master/src/util/externalcommandhelper.cpp#L239

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-23 Thread morashon
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #5 from morashon  ---
So I tested twice with btrfs partition. On first test I told KDE Partition
Manager to restore the backup overwriting the existing backed-up partition.
When running the btrfs check --repair command after closing device it returned
"Error". KDE partition manager again saw this as an unknown partition.

Second test I deleted the existing partition and told it to restore the same
backup, this time the check file system returned success, but did not appear to
run the btrfs check --repair command. Then it attempted to resize the file
system from 31 million sectors to 60 million sectors and failed with "The file
system on partition 'dev/sde1' cannot be resized because there is no support
for it." and the same generic "Error" below that. KDE Partition Manager still
sees the restored partition as an unknown partition and if I remove and
reinsert the USB drive I do not get asked to mount it as I usually would.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-23 Thread morashon
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #4 from morashon  ---
(In reply to Andrius Štikonas from comment #3)
> Can you try running it on some other partition and see if you can reproduce
> it on your system?

My previous test was on a HDD so I tried with a 28 GiB pen drive and had the
same result. This was also an ext4 partition. I just noticed yours was btrfs so
I will test with a btrfs partition.

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-22 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #3 from Andrius Štikonas  ---
Can you try running it on some other partition and see if you can reproduce it
on your system?

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-22 Thread Andrius Štikonas
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #2 from Andrius Štikonas  ---
Hmm, I can't reproduce this. Just tried backing up 8 GB partition from my USB
stick and it worked

$ sudo blkid test
test: LABEL="test" UUID="03a4ba3c-058f-4b46-9e6d-99a21d9407d4"
UUID_SUB="7bfe210b-b6e1-4896-99bf-0cf0467bd1ec" BLOCK_SIZE="4096" TYPE="btrfs"

-- 
You are receiving this mail because:
You are watching all bug changes.

[partitionmanager] [Bug 450685] Partition backup feature does not correctly back up data in partition

2022-02-21 Thread morashon
https://bugs.kde.org/show_bug.cgi?id=450685

--- Comment #1 from morashon  ---
Created attachment 147032
  --> https://bugs.kde.org/attachment.cgi?id=147032=edit
fsck results

Forgot to input on other attachment.

-- 
You are receiving this mail because:
You are watching all bug changes.