[partitionmanager] [Bug 471499] Spaces in file system label are displayed as underscores
https://bugs.kde.org/show_bug.cgi?id=471499 Andrius Štikonas changed: What|Removed |Added Version Fixed In||23.08.0 -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 471499] Spaces in file system label are displayed as underscores
https://bugs.kde.org/show_bug.cgi?id=471499 Andrius Štikonas changed: What|Removed |Added Latest Commit||https://invent.kde.org/syst ||em/kpmcore/-/commit/4490081 ||c7acc60ff9a9a158cf8af4d7ed2 ||6a57b4 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Andrius Štikonas --- Git commit 4490081c7acc60ff9a9a158cf8af4d7ed26a57b4 by Andrius Štikonas. Committed on 03/07/2023 at 23:42. Pushed by stikonas into branch 'master'. Obtain file system label from ID_FS_LABEL_ENC. M +1-1src/core/operationrunner.cpp M +35 -3src/plugins/sfdisk/sfdiskbackend.cpp https://invent.kde.org/system/kpmcore/-/commit/4490081c7acc60ff9a9a158cf8af4d7ed26a57b4 -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 471499] Spaces in file system label are displayed as underscores
https://bugs.kde.org/show_bug.cgi?id=471499 Andrius Štikonas changed: What|Removed |Added CC||ch.ehrlic...@gmx.de --- Comment #2 from Andrius Štikonas --- Hmm, there doesn't seem to be canonical way to decode blkid strings in Qt. Qt has a internal function to do that https://github.com/qt/qtbase/blob/9a320b037ce7b63c5f9de6fbb4e391612e857a95/src/corelib/io/qstorageinfo_unix.cpp#L456 which we could presumably "steal" it. But tt seems that it incorrectly decodes backslashes... Christian, would you happen to remember why backslashes are ignored in qstorageinfo_unix.cpp::decodeFsEncString (// but not the backslash to prevent collisions) Because of that conditional, backslash is not decoded and it does seem correct to me. For example, I created a label called rootfs test\test blkid then encodes it to rootfs\x20test\x5ctest which your function decoded to rootfs test\x5ctest -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 471499] Spaces in file system label are displayed as underscores
https://bugs.kde.org/show_bug.cgi?id=471499 Andrius Štikonas changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #1 from Andrius Štikonas --- Oh, that seems to be coming from udev... I ran udevadm command manually and it returns: ID_FS_LABEL=rootfs_test ID_FS_LABEL_ENC=rootfs\x20test So we were reading ID_FS_LABEL but I guess we should read ID_FS_LABEL_ENC and decode it. https://invent.kde.org/system/kpmcore/-/blob/master/src/plugins/sfdisk/sfdiskbackend.cpp#L636 -- You are receiving this mail because: You are watching all bug changes.
