[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=374913

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #34 from Wolfgang Bauer  ---
I did some investigation today, and this does work in latest Plasma 5.12 LTS
(with Qt 5.9.7) and also with all latest upstream versions (Plasma 5.15.3, Qt
5.12.2).

Closing as FIXED again therefore.

It got indeed broken in Leap 15.0 by a plasma-integration update that includes
https://cgit.kde.org/plasma-integration.git/commit/?h=Plasma/5.12=4848bec177b2527662098f97aa745bb839bc15e3.
The reason is that 15.0 ships with Qt 5.9.4 though and doesn't have this fix
yet that's mentioned in comment#3:
https://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.9=4cd90a3579986ae7441c3e982a5f34cdfd92c152

That's tracked downstream now though:
http://bugzilla.opensuse.org/show_bug.cgi?id=1129662

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Christoph]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #33 from Christoph  ---
(In reply to H Richardson from comment #32)
> Working again for me in KDE 5.53.0. I had to upgrade OpenSUSE 15 KDE to
> separate KDE repository as vanilla OpenSUSE + updates still had the bug.

can you please point out which (of your) repos exactly serve the fixed versions 

:) kindly -c-

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[H Richardson]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #32 from H Richardson <68g...@gmail.com> ---
Working again for me in KDE 5.53.0. I had to upgrade OpenSUSE 15 KDE to
separate KDE repository as vanilla OpenSUSE + updates still had the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Shimi Chen]

https://bugs.kde.org/show_bug.cgi?id=374913

Shimi Chen  changed:

   What|Removed |Added

 CC||shimi.c...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Christoph]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #31 from Christoph  ---
(In reply to H Richardson from comment #29)
> Unfortunately after having been fixed a while, this bug has returned in the
> latest round of updates to openSuSE 15.0.
> 
> Opening from a file on SFTP drops you back in at your local home directory
> instead of browsing the server.
> 
> I'm using all the most up-to-date opeSuSE versions of relevant packages, as
> of today. I can't say if this is a openSuSE issue or a Plasma issue in this
> case. 
> 
> Anyone else got the same issue?

i am indeed deeply shocked :-o @Alex did they drop your commit ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Christoph]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #30 from Christoph  ---
(In reply to H Richardson from comment #29)
> Unfortunately after having been fixed a while, this bug has returned in the
> latest round of updates to openSuSE 15.0.

means you are using dolphin 17.12.3 now ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=374913

Nate Graham  changed:

   What|Removed |Added

 CC||a...@cryptomilk.org,
   ||sit...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[H Richardson]

https://bugs.kde.org/show_bug.cgi?id=374913

H Richardson <68g...@gmail.com> changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #29 from H Richardson <68g...@gmail.com> ---
Unfortunately after having been fixed a while, this bug has returned in the
latest round of updates to openSuSE 15.0.

Opening from a file on SFTP drops you back in at your local home directory
instead of browsing the server.

I'm using all the most up-to-date opeSuSE versions of relevant packages, as of
today. I can't say if this is a openSuSE issue or a Plasma issue in this case. 

Anyone else got the same issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Christoph]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #28 from Christoph  ---
thank you !

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Alex Richardson]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #27 from Alex Richardson  ---
Sorry about that, I didn't test that case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=374913

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #26 from David Faure  ---
I believe this fix was wrong, it broke the testSelectUrl unittest, i.e. the
case where the application would call selectUrl directly.

I have just submitted what I believe to be the right fix for this bug, in Qt:
https://codereview.qt-project.org/235473

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Toralf Förster]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #25 from Toralf Förster  ---
(In reply to Alex Richardson from comment #23)
> Git commit cc064e81c6ed51f3b4422c2f2347e5f4e090e628 by Alex Richardson.
> Committed on 08/04/2018 at 14:05.
> Pushed by arichardson into branch 'Plasma/5.12'.

works flawlessly with 5.11.5 too here at a stable Gentoo Linux and fixes a
painful issue I had here with KDE - thx.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Christoph]

https://bugs.kde.org/show_bug.cgi?id=374913

--- Comment #24 from Christoph  ---
loving it :-) i hope it will get ported to KDE Frameworks 5.44.0 / Qt 5.9.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Alex Richardson]

https://bugs.kde.org/show_bug.cgi?id=374913

Alex Richardson  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-integration/bfd41a95530 |sma-integration/cc064e81c6e
   |f90ee8d44cbcfd1fa8c62978334 |d51f3b4422c2f2347e5f4e090e6
   |a2  |28

--- Comment #23 from Alex Richardson  ---
Git commit cc064e81c6ed51f3b4422c2f2347e5f4e090e628 by Alex Richardson.
Committed on 08/04/2018 at 14:05.
Pushed by arichardson into branch 'Plasma/5.12'.

KDEPlatformFileDialog: Fix initial directory selection for remote files

Summary:
Previously KDEPlatformFileDialogHelper::selectFile() would change
options()->initialDirectory() unconditionally even if it was already
set by the QFileDialog code. Since Qt 5.7.1 it is no longer necessary
to derive initialDirectory from the selectFile() call. In fact it is
actuall harmful since it will now override the correct initial directory
that was set by Qt. Without this patch I got the following debug output:

```
KDEPlatformFileDialogHelper::setDirectory
QUrl("sftp://server/home/alr48/cheri/build_sdk.sh;)
KDEPlatformFileDialogHelper::setDirectory
QUrl("sftp://server/home/alr48/cheri/build_sdk.sh;)
KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh")
KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/)
```
The final setDirectory() call is actually a call to
`setDirectory(options->initialDirectory())` which was set in `selectFile()`.

We now depend on Qt 5.9 so we can remove this code without a check for
version >= 5.7.1.

Test Plan: Remote directory is now opened correctly (tested with Qt 5.10.0)

Reviewers: #plasma, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin,
plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4193

M  +0-5src/platformtheme/kdeplatformfiledialoghelper.cpp

https://commits.kde.org/plasma-integration/cc064e81c6ed51f3b4422c2f2347e5f4e090e628

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Alex Richardson]

https://bugs.kde.org/show_bug.cgi?id=374913

Alex Richardson  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-integration/bfd41a95530
   ||f90ee8d44cbcfd1fa8c62978334
   ||a2
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #22 from Alex Richardson  ---
Git commit bfd41a95530f90ee8d44cbcfd1fa8c62978334a2 by Alex Richardson.
Committed on 08/04/2018 at 10:06.
Pushed by arichardson into branch 'master'.

KDEPlatformFileDialog: Fix initial directory selection for remote files

Summary:
Previously KDEPlatformFileDialogHelper::selectFile() would change
options()->initialDirectory() unconditionally even if it was already
set by the QFileDialog code. Since Qt 5.7.1 it is no longer necessary
to derive initialDirectory from the selectFile() call. In fact it is
actuall harmful since it will now override the correct initial directory
that was set by Qt. Without this patch I got the following debug output:

```
KDEPlatformFileDialogHelper::setDirectory
QUrl("sftp://server/home/alr48/cheri/build_sdk.sh;)
KDEPlatformFileDialogHelper::setDirectory
QUrl("sftp://server/home/alr48/cheri/build_sdk.sh;)
KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh")
KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/)
```
The final setDirectory() call is actually a call to
`setDirectory(options->initialDirectory())` which was set in `selectFile()`.

We now depend on Qt 5.9 so we can remove this code without a check for
version >= 5.7.1.

Test Plan: Remote directory is now opened correctly (tested with Qt 5.10.0)

Reviewers: #plasma, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin,
plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4193

M  +0-5src/platformtheme/kdeplatformfiledialoghelper.cpp

https://commits.kde.org/plasma-integration/bfd41a95530f90ee8d44cbcfd1fa8c62978334a2

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 374913] Open does not use directory for currently open file with sftp://

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=374913

Nate Graham  changed:

   What|Removed |Added

Summary|Open does use directory for |Open does not use directory
   |currently open file with|for currently open file
   |sftp:// |with sftp://

-- 
You are receiving this mail because:
You are watching all bug changes.