[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-24 Thread Jan Blackquill
https://bugs.kde.org/show_bug.cgi?id=431923

Jan Blackquill (Carson Black)  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-desktop/commit/b4 |ma/plasma-desktop/commit/c0
   |f3a470e7c477815b1f95f1a8e40 |3bba6eb40bf12f497f05417ef7a
   |bdd1dcf5b83 |b3d40f7edae

--- Comment #20 from Jan Blackquill (Carson Black)  ---
Git commit c03bba6eb40bf12f497f05417ef7ab3d40f7edae by Jan Blackquill.
Committed on 24/02/2021 at 18:21.
Pushed by cblack into branch 'Plasma/5.21'.

kcms/keyboard: handle botched 5.21.0 migration

Since we shipped a botched migration script for 5.21.0, we need to
ship a new migration script that un-botches the effects of the 5.21.0
script. We also change the ID of the plain kcminput_repeat migration so
that we can distinguish between the botched migration and the non-botched
migration, and only reverse migrations applied by the botched migration.
FIXED-IN: 5.21.2
(cherry picked from commit b4f3a470e7c477815b1f95f1a8e40bdd1dcf5b83)

M  +4-0kcms/keyboard/CMakeLists.txt
A  +60   -0kcms/keyboard/kcminputrc_fix_botched_5_21_0.py
A  +35   -0kcms/keyboard/kcminputrc_fix_botched_5_21_0.upd
M  +1-1kcms/keyboard/kcminputrc_repeat.upd

https://invent.kde.org/plasma/plasma-desktop/commit/c03bba6eb40bf12f497f05417ef7ab3d40f7edae

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-24 Thread Jan Blackquill
https://bugs.kde.org/show_bug.cgi?id=431923

Jan Blackquill (Carson Black)  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In|5.21.1  |5.21.2
  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-desktop/commit/64 |ma/plasma-desktop/commit/b4
   |546c81d43f8b10487d9c6c5bb0f |f3a470e7c477815b1f95f1a8e40
   |ab4de457d13 |bdd1dcf5b83

--- Comment #19 from Jan Blackquill (Carson Black)  ---
Git commit b4f3a470e7c477815b1f95f1a8e40bdd1dcf5b83 by Jan Blackquill.
Committed on 24/02/2021 at 18:19.
Pushed by cblack into branch 'master'.

kcms/keyboard: handle botched 5.21.0 migration

Since we shipped a botched migration script for 5.21.0, we need to
ship a new migration script that un-botches the effects of the 5.21.0
script. We also change the ID of the plain kcminput_repeat migration so
that we can distinguish between the botched migration and the non-botched
migration, and only reverse migrations applied by the botched migration.
FIXED-IN: 5.21.2

M  +4-0kcms/keyboard/CMakeLists.txt
A  +60   -0kcms/keyboard/kcminputrc_fix_botched_5_21_0.py
A  +35   -0kcms/keyboard/kcminputrc_fix_botched_5_21_0.upd
M  +1-1kcms/keyboard/kcminputrc_repeat.upd

https://invent.kde.org/plasma/plasma-desktop/commit/b4f3a470e7c477815b1f95f1a8e40bdd1dcf5b83

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #18 from Nate Graham  ---
Yeah, I'm so sorry. :(

We are hoping to finally finally finally have this fixed in Plasma 5.21.2 with
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/355

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-24 Thread Manuel Geißer
https://bugs.kde.org/show_bug.cgi?id=431923

Manuel Geißer  changed:

   What|Removed |Added

 CC||geisse...@gmail.com

--- Comment #17 from Manuel Geißer  ---
I'm not sure whether this is related or not, but also since the update to
Plasma 5.21, navigating through texts with ctrl+arrow which should move by
words has stopped working. In particular, I liked to use that in Konsole. My
input method is set to ibus. Should I open a new issue for that?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-24 Thread Nils
https://bugs.kde.org/show_bug.cgi?id=431923

--- Comment #16 from Nils  ---
I can confirm here, the bug is not yet fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-23 Thread STPR
https://bugs.kde.org/show_bug.cgi?id=431923

STPR  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #15 from STPR  ---
Coming from 45 (which was marked as duplicate of this bug), the comment by
Jan suggests that it was fixed in 5.21.1. Arch repos have the updated packages,
and after installing it, the issue still persists. (Just to add: I have never
installed the beta packages).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

Nate Graham  changed:

   What|Removed |Added

 CC||flyingwaf...@pm.me

--- Comment #14 from Nate Graham  ---
*** Bug 433255 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-20 Thread Thiago Sueto
https://bugs.kde.org/show_bug.cgi?id=431923

Thiago Sueto  changed:

   What|Removed |Added

 CC||s...@keemail.me

--- Comment #13 from Thiago Sueto  ---
*** Bug 45 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-18 Thread Antonio Rojas
https://bugs.kde.org/show_bug.cgi?id=431923

Antonio Rojas  changed:

   What|Removed |Added

 CC||nils.acrimont+kde@protonmai
   ||l.com

--- Comment #12 from Antonio Rojas  ---
*** Bug 433147 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-17 Thread Jan Blackquill
https://bugs.kde.org/show_bug.cgi?id=431923

Jan Blackquill (Carson Black)  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/plasma-desktop/commit/55 |ma/plasma-desktop/commit/64
   |50af1fd10dccda80be4586f19e3 |546c81d43f8b10487d9c6c5bb0f
   |aa0995be2bc |ab4de457d13

--- Comment #11 from Jan Blackquill (Carson Black)  ---
Git commit 64546c81d43f8b10487d9c6c5bb0fab4de457d13 by Jan Blackquill.
Committed on 17/02/2021 at 18:07.
Pushed by cblack into branch 'Plasma/5.21'.

kcms/keyboard: fix migration

TriState::STATE_ON is 0, while TriState::STATE_OFF is 1.
We're currently migrating 0 -> disabled, when it should be
1 -> disabled, * -> enabled.
FIXED-IN: 5.21.1
(cherry picked from commit 5550af1fd10dccda80be4586f19e3aa0995be2bc)

M  +1-1kcms/keyboard/kcminputrc_migrate_repeat_value.py

https://invent.kde.org/plasma/plasma-desktop/commit/64546c81d43f8b10487d9c6c5bb0fab4de457d13

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-17 Thread Jan Blackquill
https://bugs.kde.org/show_bug.cgi?id=431923

Jan Blackquill (Carson Black)  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/commit/55
   ||50af1fd10dccda80be4586f19e3
   ||aa0995be2bc
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.21.1

--- Comment #10 from Jan Blackquill (Carson Black)  ---
Git commit 5550af1fd10dccda80be4586f19e3aa0995be2bc by Jan Blackquill.
Committed on 17/02/2021 at 18:06.
Pushed by cblack into branch 'master'.

kcms/keyboard: fix migration

TriState::STATE_ON is 0, while TriState::STATE_OFF is 1.
We're currently migrating 0 -> disabled, when it should be
1 -> disabled, * -> enabled.
FIXED-IN: 5.21.1

M  +1-1kcms/keyboard/kcminputrc_migrate_repeat_value.py

https://invent.kde.org/plasma/plasma-desktop/commit/5550af1fd10dccda80be4586f19e3aa0995be2bc

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

--- Comment #9 from Nate Graham  ---
Yikes. Thanks for handling this, folks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=431923

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/353

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-17 Thread Antonio Rojas
https://bugs.kde.org/show_bug.cgi?id=431923

Antonio Rojas  changed:

   What|Removed |Added

 CC||aro...@archlinux.org
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #7 from Antonio Rojas  ---
The migration is wrong

https://invent.kde.org/plasma/plasma-desktop/-/blob/master/kcms/keyboard/kcminputrc_migrate_repeat_value.py

KeyboardRepeating was a tri-state in which 0 meant STATE_ON. It's being
migrated to "nothing".

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-17 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=431923

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #6 from Albert Astals Cid  ---
> So the good news is that this won't affect anyone upgrading from Plasma 5.20 
> to 5.21 (i.e. most people).

That's not correct.

I never tried the beta and it broke my settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

--- Comment #5 from Nate Graham  ---
I think I may understand what happened.

We had an update script that changed people's settings to use a new feature
which was stripped out right before the beta, so the update script updated
people's settings incorrectly and caused this problem.

Then later we fixed the update script to update people's settings correctly to
account for the feature being removed and ensure no regressions. However the
automatic system for running update scripts only runs them once. Since we
changed the same update script between the beta and the final release, people
who were running the beta don't get the update script run again with its
correct data when they upgrade from the beta to the final release!

So the good news is that this won't affect anyone upgrading from Plasma 5.20 to
5.21 (i.e. most people).

The bad news is that it will probably affect everyone who tested the beta.
Sorry. :(

Jan, any ideas for how we can migrate beta users to the final configuration
without asking all of them to manually fix this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-02-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=431923

--- Comment #4 from tro...@free.fr ---
Hmm, the bug still happens in Plasma 5.21 (not beta) on Archlinux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-01-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nate Graham  ---
The commit has been reverted so this is no longer an issue for Plasma 5.21.
We'll make sure it doesn't regress in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-01-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

Nate Graham  changed:

   What|Removed |Added

Version|5.20.90 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-01-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

Nate Graham  changed:

   What|Removed |Added

 CC||m...@iyanmv.com

--- Comment #2 from Nate Graham  ---
*** Bug 431938 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 431923] Keeping arrow keys pressed does nothing

2021-01-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=431923

Nate Graham  changed:

   What|Removed |Added

Summary|Keeping arrow keys pressed  |Keeping arrow keys pressed
   |does nothing.   |does nothing
 Ever confirmed|0   |1
   Keywords||regression
 CC||n...@kde.org
   Priority|NOR |VHI
   Target Milestone|1.0 |---
 Status|REPORTED|CONFIRMED
Product|plasmashell |plasma-integration
  Component|general |character alternatives
   ||palette
   Assignee|k...@davidedmundson.co.uk|uhh...@gmail.com

--- Comment #1 from Nate Graham  ---
Ugh, this must be a regression from the key-held stuff. Arrow keys were
supposed to be excluded.

Regardless, the feature will be reverted for Plasma 5.21, but we need to fix
this for 5.22.

Jan, can you please take care of this?

-- 
You are receiving this mail because:
You are watching all bug changes.