[plasma-nm] [Bug 406765] Disappearing connections

2019-04-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=406765

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.15.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-30 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

Oleg Solovyov  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-nm/4cb1e69c1a615523d82f
   ||7986b8437906017a8d2d
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #22 from Oleg Solovyov  ---
Git commit 4cb1e69c1a615523d82f7986b8437906017a8d2d by Oleg Solovyov.
Committed on 30/04/2019 at 13:06.
Pushed by osolovyov into branch 'Plasma/5.15'.

Reset model when there are new available connections

Summary:

NetworkManager will remove all connections (at least wireless) and then add
them again.
When user creates a new connection and clicks "Disconnect" button before adding
connections back, the one which user tried to connect to will disappear from
list of available, and it will become impossible to reactivate it from applet.

Reviewers: jgrulich

Reviewed By: jgrulich

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20788

M  +2-0libs/models/networkmodel.cpp

https://commits.kde.org/plasma-nm/4cb1e69c1a615523d82f7986b8437906017a8d2d

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=406765

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #21 from Oleg Solovyov  ---
https://phabricator.kde.org/D20788

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #20 from Oleg Solovyov  ---
(In reply to Jan Grulich from comment #19)
> What do you mean by "connection without any stored info in NM", do you mean
> creating a connection
I mean "create a completely new connection
e.g. connect to a wireless network you never connected before". 

> It's weird that the device path is empty in your case, because
> I see that "addAvailableConnection()" is being called and
> that's where the device path is set.
But connection is still hidden as unavailable. Seems to be something wrong with
filter invalidation. In my case, filter was not invalidated where it should be.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #19 from Jan Grulich  ---
What do you mean by "connection without any stored info in NM", do you mean
creating a connection, but not saving it to NM (e.g. using
AddConnectionUnsaved() from NM's DBus)? It shouldn't make any difference and I
tried that now, still works as expected. It's weird that the device path is
empty in your case, because I see that "addAvailableConnection()" is being
called and that's where the device path is set.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #18 from Oleg Solovyov  ---
(In reply to Jan Grulich from comment #16)
> I can reproduce what you mentioned, but in your case one network is added
> back according to the log, but it's not visible in the applet, that's what I
> cannot reproduce.

for some reason, AppletProxyModel::filterAcceptsRow filters it out, that's why
it's not visible.

NetworkModelItem::itemType returns NetworkModelItem::UnavailableConnection
because m_devicePath is empty at the moment.

That's what I completely figured out as reason why it happens.
I can't figure out how to fix this - maybe make connection available again if
it can be associated with wireless network?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #17 from Oleg Solovyov  ---
(In reply to Jan Grulich from comment #16)
> I can reproduce what you mentioned, but in your case one network is added
> back according to the log, but it's not visible in the applet, that's what I
> cannot reproduce.

Try with network without any stored info in NM

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #16 from Jan Grulich  ---
I can reproduce what you mentioned, but in your case one network is added back
according to the log, but it's not visible in the applet, that's what I cannot
reproduce.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-24 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #15 from Oleg Solovyov  ---
(In reply to Jan Grulich from comment #14)
> Everything seems to be correct, I don't really see why the "malta"
> connection is not visible in the applet. Is there any other "malta"
> connection? I mean is the same wireless network configured for two
> connections?
> 
> I'm afraid that I will not be able to fix this until I manage to reproduce
> it locally or at least at this moment I have no idea what other information
> you can provide.

NM is removing all networks (at least wireless ones) for a moment and adding
them back for some reason.
It is reproducible if you clicked "Disconnect" button quick enough - before
adding connections back.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #14 from Jan Grulich  ---
Everything seems to be correct, I don't really see why the "malta" connection
is not visible in the applet. Is there any other "malta" connection? I mean is
the same wireless network configured for two connections?

I'm afraid that I will not be able to fix this until I manage to reproduce it
locally or at least at this moment I have no idea what other information you
can provide.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #13 from Oleg Solovyov  ---
Created attachment 119583
  --> https://bugs.kde.org/attachment.cgi?id=119583=edit
complete log

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #12 from Jan Grulich  ---
What is the output of "nmcli -f all device show your_wifi_device"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #11 from Oleg Solovyov  ---
Created attachment 119581
  --> https://bugs.kde.org/attachment.cgi?id=119581=edit
no malta

Wireless network "malta" has been added but there are no malta's in list of
available connections.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #10 from Jan Grulich  ---
Even plasmashell debug confirms what I said at the beginning, the networks are
removed and added later again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

Oleg Solovyov  changed:

   What|Removed |Added

 Attachment #119577|0   |1
is obsolete||

--- Comment #8 from Oleg Solovyov  ---
Created attachment 119579
  --> https://bugs.kde.org/attachment.cgi?id=119579=edit
plasma-nm debug output

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #9 from Oleg Solovyov  ---
Created attachment 119580
  --> https://bugs.kde.org/attachment.cgi?id=119580=edit
patch adding my own debug output

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #7 from Jan Grulich  ---
>From the log I see that all access points disappeared from NM and they were
added again (that's what I said at the beginning). Can you please attach log
from plasmashell with enabled plasma-nm debug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #6 from Oleg Solovyov  ---
Created attachment 119578
  --> https://bugs.kde.org/attachment.cgi?id=119578=edit
dbus-monitor output

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #5 from Jan Grulich  ---
That's not the debug I wanted, read whole "My connection in the applet shows
wrong information" section. You need to run dbus-monitor and restart
plasmashell while enabling debug information for plasma-nm and reproducing the
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #4 from Oleg Solovyov  ---
Created attachment 119577
  --> https://bugs.kde.org/attachment.cgi?id=119577=edit
debug output

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

--- Comment #3 from Jan Grulich  ---
I'm pretty sure it's NM fault, but to be sure, please provide information as
described here [1].  

[1] -
https://techbase.kde.org/Projects/Solid/Plasma-nm#My_connection_in_the_applet_shows_wrong_information

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=406765

Oleg Solovyov  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|NOT A BUG   |---
 Status|RESOLVED|REOPENED

--- Comment #2 from Oleg Solovyov  ---
(In reply to Jan Grulich from comment #1)
> I believe that's NM fault

I don't. nmcli in such cases works fine and all disappearing connections
appears in console.

> since some recent NM version, after you disconnect a wireless connection, 
> they will disappear for a while

Okay, since which recent version?
Reproducible with both NetworkManager 1.16.0 and NetworkManager 1.8.9

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 406765] Disappearing connections

2019-04-23 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=406765

Jan Grulich  changed:

   What|Removed |Added

 CC||jgrul...@redhat.com
 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #1 from Jan Grulich  ---
I believe that's NM fault, this wasn't happening before, but since some recent
NM version, after you disconnect a wireless connection, they will disappear for
a while and appear again as a new scan is probably being performed.

-- 
You are receiving this mail because:
You are watching all bug changes.