[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Lucid changed: What|Removed |Added CC||e...@mink.li --- Comment #13 from Lucid --- The linked merge request looks like some devs are heavily disputing whether it's a good thing to only mute the default device ... I'm new to this bugtracker, but I haven't found a way to press +1 on the bug so I made an account to voice my agreement: The mute button should only mute the main device. not the bluetooth headset. When I disconnect my headset, it is easy to forget to re-mute the laptop, but I want the laptop speaker almost always on mute. When I connect my headset, it is easy to think that the bluetooth driver is broken - not just that the mute button is behaving unexpectedly (by design, but still.. I just had to fix a driver and a software issue before that. It's just not an easy idea to have that you're supposed to unmute the main speaker to listen to the headphones.) Thanks for everybody involved anyway! All in all, I'm really enjoying KDE. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Tamás Pesti changed: What|Removed |Added CC||ptamas2...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Pavol Pitoňák changed: What|Removed |Added CC||pa...@pitonak.com -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #12 from Nate Graham --- No problem at all! Thanks for working on it. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #11 from Benjamin Xiao --- Apologies for the slow progress on this, but I have made a really quick and small patch for a single device mute behavior. Here's the WIP merge request: https://invent.kde.org/plasma/plasma-pa/-/merge_requests/60 Nate, there's two things I would like to ask for clarification on. They're both described in detail in the merge request. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #10 from Nate Graham --- feel free to ping me on matrix directly or try the kde-devel room. :) -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Nate Graham changed: What|Removed |Added Depends on||435199 See Also||https://bugs.kde.org/show_b ||ug.cgi?id=435199 Referenced Bugs: https://bugs.kde.org/show_bug.cgi?id=435199 [Bug 435199] Offer a choice whether mute actions mute all relevant devices, or just the default one -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Nate Graham changed: What|Removed |Added Component|applet |general -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=435142 -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #9 from Benjamin Xiao --- So I've been looking through the source code and I believe that the main file I need to modify is $(KDESRC_BUILD_DIR)/src/plasma/plasma-pa/applet/contents/ui/main.qml. However I can not for the life of me figure out where it goes when I build the project. The plasma-pa Arch package also doesn't seem to include this file and I can't find this file anywhere on my system. Perhaps, I am just not very familiar with how the KDE project is laid out, but if someone could point me in the right direction, it would be greatly appreciated! -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #8 from Benjamin Xiao --- Sorry for the delay, but I've finally got around to setting up a KDE dev environment on a VM and it is all working now. I will start looking through the source code and attempt a fix. To avoid cluttering up this bug report with logistical questions, would the best way to reach you be via the webchat.kde.org Matrix server? -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #7 from Benjamin Xiao --- Sounds good. Thanks for the link, Nate. I'll setup a development VM and get back to you. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #6 from Nate Graham --- Your proposal seems reasonable to me. We do only mute the default microphone, so having the same behavior for muting output devices makes some sense. plasma-pa is chronically short on dev time, so your efforts would be much appreciated! The best way to get started would probably be to read through https://community.kde.org/Get_Involved/development and get a dev environment set up. I'd be happy to help. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 --- Comment #5 from Benjamin Xiao --- If it is intentional, then I propose that this behavior be changed to be more inline with other platforms. Windows, Mac, and Gnome do not do this AFAIK. I also understand that just like bug 432487, the intention here could be to bias towards a simple use case, but this behavior very quickly devolves if users have more than one audio device, which is very common today with HDMI, USB, and Bluetooth devices becoming more and more popular. Here's what I propose: 1.) Mute hotkey should by default only mute default device to match other platforms 2.) The "Force mute all playback devices" menu entry should be a separate "Mute All" icon instead of being hidden in the "More actions" hamburger menu. 3.) "Mute All" should get its own hotkey. I propose "Shift-Mute" if possible. 4.) (Optional) The new "Mute All" icon should display the new hotkey in its tooltip to aid in discovery. 5.) Expose new "Shift-Mute" hotkey in Global Shortcuts settings so that people can swap the behavior if they want to. Additional UI clean up: 1.) "Configure Audio Devices" should be moved out of the "More actions" menu as a separate icon as that's actually a frequently used feature for people who need to switch between HSP/A2DP modes on their Bluetooth headsets. "More actions" will be empty and therefore should be removed. What do you think Nate? Also, sidenote, how much dev effort is going into the Plasma PA widget and are they currently too busy with other tasks? I am a former software dev looking to get back into the swing of things and would love to knock off these types of low hanging fruit if needed. However, I am unfamiliar with KDE development and will probably need a few pointers to get started. Let me know if I can help. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pa] [Bug 434217] Keyboard mute key mutes all devices, not just the default device
https://bugs.kde.org/show_bug.cgi?id=434217 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Summary|Keyboard mute key should|Keyboard mute key mutes all |only mute the default |devices, not just the |device |default device Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |CONFIRMED --- Comment #4 from Nate Graham --- Oh my mistake, I'm so sorry. I thought you were talking about the mic mute key, not the output device mute key. I can confirm that it mutes all devices, not just the default one. This seems to be intentional, but of course that intention may be problematic. :) -- You are receiving this mail because: You are watching all bug changes.
