[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[OlafLostViking via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

OlafLostViking  changed:

   What|Removed |Added

 CC||olaf.the.lost.viking@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||steve...@gmail.com

--- Comment #11 from Kai Uwe Broulik  ---
*** Bug 357019 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

--- Comment #9 from Hugo Pereira Da Costa  ---
In fact, for editable comboboxes, fusion also shows the issue. 
Only for read-only comboboxes it does not, and for such, fusion's rendering
(also in the widget case) is quite non-standard. 
I guess i'll look into how they do it in the QFusionStyle and see if I can get
the code from there. 
Still : this _is_ an upstream bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

--- Comment #8 from Hugo Pereira Da Costa  ---
Thanks Kay !

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

--- Comment #10 from David Edmundson  ---
https://bugreports.qt.io/browse/QTBUG-48252 if you're interested.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||hugo.pere...@free.fr

--- Comment #4 from Kai Uwe Broulik  ---
Hugo, could you perhaps have a look at this? It affects Breeze and Oxygen as
well as Windows 95 style but not the Qt Fusion style. QtQuick Controls ComboBox
uses PE_PanelItemViewRow in its ComboBox popup, perhaps we don't style that
thing properly?

Relevant code:
qApp->style()->drawPrimitive(QStyle::PE_PanelItemViewRow, m_styleoption,
);
if ((style() == "mac" ||
!qApp->style()->styleHint(QStyle::SH_ItemView_ShowDecorationSelected)) &&
selected()) {
pal = QApplication::palette("QAbstractItemView");
pal.setCurrentColorGroup(m_styleoption->palette.currentColorGroup());
pixpainter.fillRect(m_styleoption->rect, pal.highlight());
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

--- Comment #5 from Hugo Pereira Da Costa  ---
(In reply to Kai Uwe Broulik from comment #4)
> Hugo, could you perhaps have a look at this? It affects Breeze and Oxygen as
> well as Windows 95 style but not the Qt Fusion style. QtQuick Controls
> ComboBox uses PE_PanelItemViewRow in its ComboBox popup, perhaps we don't
> style that thing properly?
> 
> Relevant code:
> qApp->style()->drawPrimitive(QStyle::PE_PanelItemViewRow, m_styleoption,
> );
> if ((style() == "mac" ||
> !qApp->style()->styleHint(QStyle::SH_ItemView_ShowDecorationSelected)) &&
> selected()) {
> pal = QApplication::palette("QAbstractItemView");
> pal.setCurrentColorGroup(m_styleoption->palette.currentColorGroup());
> pixpainter.fillRect(m_styleoption->rect, pal.highlight());
> }

Hi Kai,
>From what I can understand, the code above is relevant for the selected item
only, whereas the bug is for unselected ones.
And in fact, comparing the correct and incorrect rendering, what seems to be
the problem is the color used for the list "background". (possibly incorrect
background role).

Anyway, yes, I can try investigate a bit more (but it is likely _not_ in the
code mentionned above.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

--- Comment #6 from Hugo Pereira Da Costa  ---
Any other application than plasmashell (desktop settings) that I could use to
reproduce the issue ? (such as a QtQuickControls demo, for instance ?)

Right now plasmashell crashes on my hybrid system (kde4/kf5) and I don't feel
like recompiling everything to make it work ...

Thanks in advance,

Hugo

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 352653] Dropdowns in widget properties don't follow system color settings. [regression]

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=352653

--- Comment #7 from Kai Uwe Broulik  ---
The you go:
http://code.qt.io/cgit/qt/qtquickcontrols.git/tree/examples/quick/controls/gallery

-- 
You are receiving this mail because:
You are watching all bug changes.