[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=355258

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||n...@kde.org
 Resolution|--- |FIXED
   Version Fixed In||5.12.8

--- Comment #27 from Nate Graham  ---
Seems like it!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Claudius Ellsel]

https://bugs.kde.org/show_bug.cgi?id=355258

Claudius Ellsel  changed:

   What|Removed |Added

 CC||claudius.ell...@live.de

--- Comment #26 from Claudius Ellsel  ---
So can this be closed then?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=355258

Méven Car  changed:

   What|Removed |Added

 CC||meve...@gmail.com

--- Comment #25 from Méven Car  ---
Reading through the comment, it seems fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Maciej Stanczew]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #24 from Maciej Stanczew  ---
Hi,

Confirming the fix works on Plasma 5.13.5. Automounts are no longer triggered
by plasmashell, and it's now possible to unmount them.

Thank you for a very quick reaction!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #23 from Kai Uwe Broulik  ---
Git commit e29ac5c3ff38f48d8b48bddf2e308dcc68dc9ba8 by Kai Uwe Broulik.
Committed on 08/08/2018 at 10:41.
Pushed by broulik into branch 'Plasma/5.12'.

[Solid Device Engine] Don't update free space info for inaccessible storage
devices

This might trigger automounting of devices.

Differential Revision: https://phabricator.kde.org/D14532

M  +1-1dataengines/soliddevice/soliddeviceengine.cpp

https://commits.kde.org/plasma-workspace/e29ac5c3ff38f48d8b48bddf2e308dcc68dc9ba8

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Maciej Stanczew]

https://bugs.kde.org/show_bug.cgi?id=355258

Maciej Stanczew  changed:

   What|Removed |Added

 CC||maciej.stancze...@gmail.com

--- Comment #22 from Maciej Stanczew  ---
I experience a similar issue. I have three NFS mounts in fstab, with option
"x-systemd.automount" set (so they should only be mounted when something tries
accessing corresponding directories). After system boot none of the three
shares is mounted, but then when one is mounted on demand, plasmashell triggers
the mount of other two shares:

Jul 31 22:41:05 hostname systemd[1]: n-media.automount: Got automount request
for /n/media, triggered by 669 (mpd)
Jul 31 22:41:05 hostname systemd[1]: Mounting /n/media...
Jul 31 22:41:05 hostname systemd[1]: Mounted /n/media.
Jul 31 22:41:05 hostname systemd[1]: n-pacman.automount: Got automount request
for /n/pacman, triggered by 518 (plasmashell)
Jul 31 22:41:05 hostname systemd[1]: Mounting /n/pacman...
Jul 31 22:41:05 hostname systemd[1]: Mounted /n/pacman.
Jul 31 22:41:05 hostname systemd[1]: n-backup.automount: Got automount request
for /n/backup, triggered by 518 (plasmashell)
Jul 31 22:41:05 hostname systemd[1]: Mounting /n/backup...
Jul 31 22:41:05 hostname systemd[1]: Mounted /n/backup.

As in original description, it's not possible to unmount any of the shares:

Jul 31 22:44:14 hostname systemd[1]: Unmounting /n/backup...
Jul 31 22:44:14 hostname systemd[1]: n-backup.automount: Got automount request
for /n/backup, triggered by 518 (plasmashell)
Jul 31 22:44:14 hostname systemd[1]: Mounting /n/backup...
Jul 31 22:44:15 hostname systemd[1]: Mounted /n/backup.

This only happens with Device Notifier applet active -- without it, everything
works correctly.

The patch from comment #15 fixes both of above issues -- plasmashell no longer
triggers any unwanted mounts in those scenarios.

Regarding simultaneous unmount (as described in comment #16): manually running
umount with multiple targets always works (all shares are properly unmounted).
It's only when doing this from systemd that sometimes shares are remounted by
plasmashell:

# systemctl stop n-backup.mount n-media.mount n-pacman.mount
Job for n-media.mount canceled.

Jul 31 23:02:53 hostname systemd[1]: Unmounting /n/backup...
Jul 31 23:02:53 hostname systemd[1]: Unmounting /n/media...
Jul 31 23:02:53 hostname systemd[1]: Unmounting /n/pacman...
Jul 31 23:02:53 hostname systemd[1]: n-media.automount: Got automount request
for /n/media, triggered by 508 (plasmashell)
Jul 31 23:02:53 hostname systemd[1]: Unmounted /n/backup.
Jul 31 23:02:53 hostname systemd[1]: Mounting /n/media...
Jul 31 23:02:53 hostname systemd[1]: Unmounted /n/pacman.
Jul 31 23:02:53 hostname systemd[1]: Mounted /n/media.

Still, could the patch from comment #15 be merged regardless of this remaining
issue? In my case the patch only improves the behavior, as it eliminates almost
all of unwanted mounts (leaving only a specific corner-case that is
simultaneous unmounting).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Anthony DeRobertis]

https://bugs.kde.org/show_bug.cgi?id=355258

Anthony DeRobertis  changed:

   What|Removed |Added

 CC||anth...@derobert.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #21 from en...@gmx.de ---
(In reply to Kai Uwe Broulik from comment #20)
> I wonder why it does forceImmediateUpdateOfAllVisualizations() just because
> one device changed.

I'm not familiar with the kde/plasma code, but if you have any further
debugging suggestions, I'm happy to try them out.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #20 from Kai Uwe Broulik  ---
I wonder why it does forceImmediateUpdateOfAllVisualizations() just because one
device changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #19 from en...@gmx.de ---
Created attachment 105803
  --> https://bugs.kde.org/attachment.cgi?id=105803=edit
Log showing the race condition for share4

The attached log illustrates the race condition for share4.

I added following line to your patch before the condition you added:

qDebug() << " XXX: " << udi << " isAccessible(): " <<
storageaccess->isAccessible();

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #18 from en...@gmx.de ---
I did not check the code myself but referred to Comment 12:

> On a disconnect or connect event:
> Device Notifier loops over all elements in my fstab and calls 
> KDiskFreeSpaceInfo on each of them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #17 from Kai Uwe Broulik  ---
It's a start ;)

Where do you see it looping over the list of available devices in response to a
device change?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #16 from en...@gmx.de ---
Thank you very much for the patch! 

It looks much better now. For shares that cannot be mounted because the server
is down, isAccessible() returns false, and thus prevents plasma from blocking.
Great!

However there still seems to be a race condition when there are multiple shares
with the same idle timeout. When the shares are unmounted at the same time by
systemd, plasmashell handles the event for the first share that is unmounted.
It  loops over all shares and checks for isAccessible(). At that time
isAccessible() might still return true for the second share, although it is
currently being unmounted by systemd. Therefore, the rest of
updateStorageSpace() is executed, which results in the original bug where
plasmashell triggers a new automount request for the second share that was just
unmounted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=355258

--- Comment #15 from Kai Uwe Broulik  ---
Created attachment 105780
  --> https://bugs.kde.org/attachment.cgi?id=105780=edit
Possible patch

Completely untested (other than that it compiles), please test, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=355258

Kai Uwe Broulik  changed:

   What|Removed |Added

   Assignee|fa...@kde.org   |k...@privat.broulik.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=355258

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #14 from Kai Uwe Broulik  ---
Perhaps checking for storageaccess->isAccessible() in updateStorageSpace helps.
It already does that before calling into updateStorageSpace in
populateDeviceData but does not in updateSourceEvent, I'll try to come up with
a patch if you can perhaps test them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=355258

en...@gmx.de changed:

   What|Removed |Added

 CC||en...@gmx.de

--- Comment #13 from en...@gmx.de ---
I can confirm this bug on Arch Linux with plasma 5.9.5-1.

Having a share with x-systemd.idle-timeout=1min in /etc/fstab results in
periodic log messages from systemd every minute:
systemd[1]: mnt-temp.automount: Got automount request for /mnt/temp, triggered
by 856 (plasmashell)
If the share is not available, plasma periodically freezes for some seconds.

Is there any solution in sight?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 355258] plasmashell is preventing systemd automount shares from idle unmounting

[Joseph Yasi]

https://bugs.kde.org/show_bug.cgi?id=355258

Joseph Yasi  changed:

   What|Removed |Added

   Target Milestone|--- |1.0
Version|unspecified |5.9.4
   Severity|normal  |major
  Component|general |Device Notifier
Product|frameworks-kio  |plasmashell

--- Comment #12 from Joseph Yasi  ---
Here is the bug:
On a disconnect or connect event:
Device Notifier loops over all elements in my fstab and calls
KDiskFreeSpaceInfo on each of them.
This triggers a stat on the mount points in KMountPoint::List::findByPath which
causes every automount point in my fstab to mount.
Device Notifier is set to only show removable devices. No removable devices are
connected, yet it gathers free space information for devices it will never show
me.
This is a major performance issue. My automounts are set to timeout after 1
minute of inactivity. This bugs causes them to remount every time the time out.
Device notifier should not be asking for free space information for every line
in my fstab when it will never display them. Free space information should only
be requested on demand when the applet needs to show it for a specific device.

-- 
You are receiving this mail because:
You are watching all bug changes.