[plasmashell] [Bug 358135] Media Player widget in expanded mode makes Amarok skip tracks

2016-01-19 Thread Kai Uwe Broulik via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358135

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/plas
   ||ma-workspace/399143457b60de
   ||a463ec11aba13f5575439b21c1
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||5.6.0

--- Comment #4 from Kai Uwe Broulik  ---
Git commit 399143457b60dea463ec11aba13f5575439b21c1 by Kai Uwe Broulik, on
behalf of Eduardo Lara.
Committed on 19/01/2016 at 22:31.
Pushed by broulik into branch 'master'.

Reset seek slider position when changing songs

The attached patch retrieves the position from the player when:
- a new maximum is set to the slider (most cases)
- the the slider is already at the end (when the same song is played again)

Note that adding 1 sec to the slider when the remaining is less than a second
sets the slider to maximum. Handling at that moment seemed to be too soon when
I tried it. Waiting for the next iteration looked to be a better transition

REVIEW: 126779
FIXED-IN: 5.6.0

M  +14   -4applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

http://commits.kde.org/plasma-workspace/399143457b60dea463ec11aba13f5575439b21c1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358135] Media Player widget in expanded mode makes Amarok skip tracks

2016-01-17 Thread Kai Uwe Broulik via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358135

--- Comment #2 from Kai Uwe Broulik  ---
Thank you very much for the patch!

> Amarok does not seem to send position updates to the mpris interface when a 
> new song starts

That seem to be the missing part in the puzzle to figure out what went wrong
all the time. Please head to https://git.reviewboard.kde.org and submit this
patch there for review.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 358135] Media Player widget in expanded mode makes Amarok skip tracks

2016-01-17 Thread via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358135

--- Comment #3 from edward.lara.l...@gmail.com ---
Hi Kal,

Thank you for the link. I was not familiar with the review board. Here is the
request:
https://git.reviewboard.kde.org/r/126779/

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.